python-qt4 4.7.4 breaks git-cola

[daveinthesky]

Binary package hint: python-qt4

Ubuntu 10.10 64-bit
python-qt4: Installed: 4.7.4-0ubuntu1

I need help triaging git-cola bug #62 to the PyQt4 developer.

http://github.com/davvid/git-cola/issues#issue/62

The code in question has worked fine from 4.3.0 to 4.7.3.
I'm concerned about 4.7.4 because of this and other bugs.

For example, issue #65 also seems isolated to this version of PyQt4.
http://github.com/davvid/git-cola/issues#issue/65

In all previous versions, the "Actions" dock widget contains buttons. In 4.7.4, the buttons are missing.

The actions dock widget is created in cola/views/mainwindow.py starting on line 23.
It utilizes a custom widget defined in cola/qt.py

[daveinthesky (davvid)]

I found the issue. PyQt4 <= 4.7.3 would report bool(QLayout()) == True while the new 4.7.4 release treats bool(QLayout()) as False.

This is a behavior change, but it's better for the code to be explicit and check "if foo is None:" instead of checking "if foo:", so it's likely that it was intentional.

In any case, git-cola 1.4.2.5 works around this and is no longer affected.

[Mackenzie Morgan (maco.m)]

I'm going to patch git-cola in the places necessary to work with the new API

[Iulian Udrea (iulian)]

I have just uploaded 1.4.2.5 to Debian experimental.

[Michael von Glasow (michael-vonglasow)]

Any news on this one? 1.4.2.1-1 is definitely broken, so I guess the risk of going to 1.4.2.5 is minimal...

[daveinthesky (davvid)]

On Jan 25, 2011, at 4:22 PM, Michael von Glasow <<email address hidden>
 > wrote:

> Any news on this one? 1.4.2.1-1 is definitely broken, so I guess the
> risk of going to 1.4.2.5 is minimal...

The latest versions of git-cola avoid the old behavior, so we're good
to go.

The difference is that bool(QLayout()) now returns False whereas it
traditionally returned True.

Thanks Michael
--
         David