python-qt4 4.7.4 breaks git-cola

Bug #660363 reported by daveinthesky on 2010-10-14
This bug affects 4 people
Affects Status Importance Assigned to Milestone
git-cola (Ubuntu)
Nominated for Maverick by Mackenzie Morgan

Bug Description

Binary package hint: python-qt4

Ubuntu 10.10 64-bit
python-qt4: Installed: 4.7.4-0ubuntu1

I need help triaging git-cola bug #62 to the PyQt4 developer.

The code in question has worked fine from 4.3.0 to 4.7.3.
I'm concerned about 4.7.4 because of this and other bugs.

For example, issue #65 also seems isolated to this version of PyQt4.

In all previous versions, the "Actions" dock widget contains buttons. In 4.7.4, the buttons are missing.

The actions dock widget is created in cola/views/ starting on line 23.
It utilizes a custom widget defined in cola/

daveinthesky (davvid) wrote :

I found the issue. PyQt4 <= 4.7.3 would report bool(QLayout()) == True while the new 4.7.4 release treats bool(QLayout()) as False.

This is a behavior change, but it's better for the code to be explicit and check "if foo is None:" instead of checking "if foo:", so it's likely that it was intentional.

In any case, git-cola works around this and is no longer affected.

Changed in python-qt4 (Ubuntu):
assignee: nobody → Mackenzie Morgan (maco.m)
Mackenzie Morgan (maco.m) wrote :

I'm going to patch git-cola in the places necessary to work with the new API

Changed in python-qt4 (Ubuntu):
status: New → Confirmed
status: Confirmed → Triaged
affects: python-qt4 (Ubuntu) → git-cola (Ubuntu)
Iulian Udrea (iulian) wrote :

I have just uploaded to Debian experimental.

Ralph Janke (txwikinger) on 2010-11-04
Changed in git-cola (Ubuntu):
importance: Undecided → Medium

Any news on this one? is definitely broken, so I guess the risk of going to is minimal...

On Jan 25, 2011, at 4:22 PM, Michael von Glasow <<email address hidden>
 > wrote:

> Any news on this one? is definitely broken, so I guess the
> risk of going to is minimal...

The latest versions of git-cola avoid the old behavior, so we're good
to go.

The difference is that bool(QLayout()) now returns False whereas it
traditionally returned True.

Thanks Michael

Changed in git-cola (Ubuntu):
assignee: Mackenzie Morgan (maco.m) → nobody
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers