[SRU] Ubuntu 22.10 - Crashing when accessing menus

[Michael Pelley]

[ Impact ]

gigolo will crash with a segfault whenever any user using "ubuntu" desktop session tries to open the preferences dialogue box.
This does not impact users using "Ubuntu on Xorg" desktop session.

[ Test Plan ]

* Click on the gear icon in login screen to select "Ubuntu" and login
* Confirm that it is the "Ubuntu" session.

$ echo $XDG_SESSION_DESKTOP
ubuntu

* open gigolo
* click on edit menu
* click on preferences

If the package is not fixed it will crash, with the fixed package it will display the preferences dialogue box.

Repeat the same test "Ubuntu on Xorg" session to verify that the users with working "gigolo" does not have a regression.

* Click on the gear icon in login screen to select "Ubuntu on Xorg" and login
* Confirm that it is the "Ubuntu on Xorg" session.

$ echo $XDG_SESSION_DESKTOP
ubuntu-xorg

* open gigolo
* click on edit menu
* click on preferences

[ Where problems could occur ]

 * This is an upstream patch which is only simplifying the way it detects the desktop. There is no other change in the code and so the chances of regression are very less.
 worst case possibility is if the code does not get "XDG_CURRENT_DESKTOP" when running in a xfce session then it will incorrectly detect that its not a xfce session. But if XDG_CURRENT_DESKTOP is not defined then I guess the user will have more serious problems to worry about.

[ Other Info ]

This has been fixed in upstream 0.5.3, and so it is aleady fixed in Noble.

[ Original Bug Description ]

When trying to access menus Gigolo crashes:
gigolo[4705]: segfault at 10 ip 000055d867c8a57e sp 00007fffa92bdcb0 error 4 in gigolo[55d867c83000+17000]
Code: 41 5c c3 66 0f 1f 84 00 00 00 00 00 e8 0b b4 ff ff 48 89 c7 e8 93 c2 ff ff 48 8d 3d 70 00 01 00 48 89 c5 48 8b 80 e8 00 00 00 <4c> 8b 60 10 e8 d9 b4 ff ff 45 31 c9 31 c9 48 89 ef 48 89 c2 48 8d

[Sudip Mukherjee (sudipmuk)]

I have tested and can reproduce the crash in Jammy and Mantic. I have also tested and confirmed that the issue is not seen in Focal or Noble.

[Sudip Mukherjee (sudipmuk)]

debdiff for Mantic attached.

[Sudip Mukherjee (sudipmuk)]

debdiff for Jammy attached.

[Graham Inggs (ginggs)]

I sponsored uploads of gigolo 0.5.2-1ubuntu0.22.04.1 and gigolo 0.5.2-1ubuntu0.23.10.1.

[Timo Aaltonen (tjaalton)]

Hello Michael, or anyone else affected,

Accepted gigolo into mantic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gigolo/0.5.2-1ubuntu0.23.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-mantic to verification-done-mantic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-mantic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Timo Aaltonen (tjaalton)]

Hello Michael, or anyone else affected,

Accepted gigolo into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gigolo/0.5.2-1ubuntu0.22.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Sudip Mukherjee (sudipmuk)]

I can confirm that the gigolo in mantic-proposed has fixed the bug for me.

Test done:
1. install gigolo from mantic-proposed
   confirmed that XDG_SESSION_DESKTOP is ubuntu
   open gigolo
   click on edit menu -> preferences

2. reboot
   select Ubuntu on Xorg from login screen
   confirmed that XDG_SESSION_DESKTOP is ubuntu-xorg
   open gigolo
   click on edit menu -> preferences

Test result: the errors with gigolo has been fixed.

Package tested:

$ apt-cache policy gigolo
gigolo:
  Installed: 0.5.2-1ubuntu0.23.10.1
  Candidate: 0.5.2-1ubuntu0.23.10.1
  Version table:
 *** 0.5.2-1ubuntu0.23.10.1 100
        100 http://us.archive.ubuntu.com/ubuntu mantic-proposed/universe amd64 Packages
        100 /var/lib/dpkg/status
     0.5.2-1 500
        500 http://us.archive.ubuntu.com/ubuntu mantic/universe amd64 Packages

[Sudip Mukherjee (sudipmuk)]

I can confirm that the gigolo in jammy-proposed has fixed the bug for me.

Test done:
1. install gigolo from jammy-proposed
   confirmed that XDG_SESSION_DESKTOP is ubuntu
   open gigolo
   click on edit menu -> preferences

2. reboot
   select Ubuntu on Xorg from login screen
   confirmed that XDG_SESSION_DESKTOP is ubuntu-xorg
   open gigolo
   click on edit menu -> preferences

Test result: the errors with gigolo has been fixed.

Package tested:

$ apt-cache policy gigolo
gigolo:
  Installed: 0.5.2-1ubuntu0.22.04.1
  Candidate: 0.5.2-1ubuntu0.22.04.1
  Version table:
 *** 0.5.2-1ubuntu0.22.04.1 500
        500 http://gb.archive.ubuntu.com/ubuntu jammy-proposed/universe amd64 Packages
        100 /var/lib/dpkg/status
     0.5.2-1 500
        500 http://gb.archive.ubuntu.com/ubuntu jammy/universe amd64 Packages

[Launchpad Janitor (janitor)]

This bug was fixed in the package gigolo - 0.5.2-1ubuntu0.23.10.1

---------------
gigolo (0.5.2-1ubuntu0.23.10.1) mantic; urgency=medium

  * Apply upstream patch to detect desktop environment correctly. (LP: #1993899)

 -- Sudip Mukherjee <email address hidden> Thu, 01 Feb 2024 12:16:25 +0000

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for gigolo has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gigolo - 0.5.2-1ubuntu0.22.04.1

---------------
gigolo (0.5.2-1ubuntu0.22.04.1) jammy; urgency=medium

  * Apply upstream patch to detect desktop environment correctly. (LP: #1993899)

 -- Sudip Mukherjee <email address hidden> Thu, 01 Feb 2024 12:16:25 +0000