germinate-update-metapackage: wrong handling of seed duplicates

[Paride Legovini]

When generating the d/changelog entries germinate-update-metapackage compares the "old" (pre-update) dependencies to the "new" ones, and checks if packages have been added or removed. However if a package is seeded more than once, it will always appear as an "added" dependency, even if already present in the "old" dependencies, and no actual change is made.

This is due to the fact that germinate_update_metapackage.py stores the "old" dependencies in a set (duplicates not allowed), and "new" dependencies in a list (duplicates allowed).

For an actual case where this was hit see:

https://code.launchpad.net/~paride/ubuntu/+source/ubuntu-meta/+git/ubuntu-meta/+merge/394577

Also see how the changelog line

  * Added wpasupplicant to desktop-raspi

appears more than once in the ubuntu-meta changelog.

[Launchpad Janitor (janitor)]

This bug was fixed in the package germinate - 2.36

---------------
germinate (2.36) unstable; urgency=medium

  [ Christian Ehrhardt ]
  * Improve ordering of rescued packages (LP: #1895106).

 -- Colin Watson <email address hidden> Mon, 25 Jan 2021 12:56:40 +0000