instable map view in gps-bar

Bug #946361 reported by Boris Daniel
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
geeqie (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

geeqie-gps (geeqie 1.0-8)
The appearance of the OpenStreetmap map in the gps bar is only sometime working and crashes often. I fixed this faulty behavior with the following patch ( removing g_object_unref(map_source), I think the library is taking ownership of the map_source object).
By the way I fixed another small bug: The position of the map is initialized with coordinates rounded to integer values (so the map starts often at a position somewhere in luxembourg, where I have never been and take a photo).

--- ../bar_gps.c 2010-02-17 22:21:19.000000000 +0100
+++ bar_gps.c 2012-03-04 14:48:52.138819580 +0100
@@ -352,9 +352,7 @@
   {
   g_object_set(G_OBJECT(pgd->gps_view), "map-source", map_source, NULL);
   g_object_unref(map_factory);
- }
-
- g_object_unref(map_source);
+ }
 }

 void bar_pane_gps_enable_markers_checked_toggle_cb(GtkWidget *menu_widget, gpointer data)
@@ -809,8 +807,8 @@
   }

  bar_pane_translate_title(PANE_COMMENT, id, &title);
- latitude = int_latitude / 1000000;
- longitude = int_longitude / 1000000;
+ latitude = (gdouble)int_latitude / (gdouble)1000000;
+ longitude = (gdouble)int_longitude / (gdouble)1000000;
  ret = bar_pane_gps_new(id, title, map_id, zoom, latitude, longitude, expanded, height);
  g_free(title);
  g_free(map_id);

Revision history for this message
Boris Daniel (em11) wrote :
Colin Clark (colinclark)
Changed in geeqie (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.