gdm logins should fail if a sourced session script fails

[Gary Coady]

When /etc/gdm/Xsession sources various other scripts, logging in will still succeed if a script returns a non-zero exit code. All other login managers have the opposite behaviour - logging in fails - because /etc/X11/Xsession includes "set -e".

This can cause failures to go unseen by developers, if they generally use gdm during development (see Malone #35852 for an example).

I really just want all login managers to have the same behaviour here, so if this bug is rejected, I'll go and hassle the xorg team ;-) But "fail early" sounds like it's more appropriate, IMHO.

[Sebastien Bacher (seb128)]

Thanks for your bug. I've forwarded it upstream: http://bugzilla.gnome.org/show_bug.cgi?id=343297

[Sebastien Bacher (seb128)]

comment from upstream:

"I would be happy to accept a patch to fix the GDM xsession script to work
better. You aren't very clear about which specific "other scripts" need
attention."