gdm init script should support the 'status' action

Bug #251375 reported by Andres Rodriguez on 2008-07-24
4
Affects Status Importance Assigned to Milestone
gdm (Ubuntu)
Wishlist
Andres Rodriguez

Bug Description

Binary package hint: gdm

GDM need to have 'status' action on init script

Related branches

Changed in gdm:
assignee: nobody → andreserl
Revision history for this message
Andres Rodriguez (andreserl) wrote :

Hope it is good :)

Changed in gdm:
status: New → In Progress
Revision history for this message
Dustin Kirkland  (kirkland) wrote :

Hi Andres-

Patch looks good to me. My only comment would be that I tend to quote shell variables when referencing them, such as:
 * status_of_proc -p "$PIDFILE" "$DAEMON" gdm && exit 0 || exit $?

I suggest that you subscribe ubuntu-main-sponsors, and bug someone with core-dev privileges if it hasn't been sponsored within a week or so.

Good work, thanks!
:-Dustin

Revision history for this message
Andres Rodriguez (andreserl) wrote :

Ok, modified debdiff with your suggestions, and suscribing to ubuntu-main-sponsors

Revision history for this message
Andres Rodriguez (andreserl) wrote :

Thanks for the review btw!! :)

Changed in gdm:
status: In Progress → Confirmed
importance: Undecided → Wishlist
Changed in gdm:
status: Confirmed → Triaged
Revision history for this message
Sebastien Bacher (seb128) wrote :

the change looks good, thanks for your work, it'll be applied to the next upload

Changed in gdm:
status: Triaged → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gdm - 2.20.7-0ubuntu3

---------------
gdm (2.20.7-0ubuntu3) intrepid; urgency=low

  [ Martin Pitt ]
  * Add debian/patches/67_guest-account.patch: If a flexisession with user
    name ":guest" is requested (which is an impossible system user name), and
    guest session setup/teardown scripts are available in
    /usr/share/gdm/guest-session/ (shipped by separate gdm-guest-user
    package), run a guest session without requiring a password. This
    flexiserver command requires standard gdm authentication, and thus can
    only be run by users who are already logged into the machine.
    Guest sessions call /usr/share/gdm/guest-session/Xsession instead of
    /etc/gdm/Xsession, so that we can wrap AppArmor (or other MAC system)
    rules around it.
    (https://wiki.ubuntu.com/DesktopTeam/Specs/Intrepid/GuestAccount)

  [ Andres Rodriguez ]
  * debian/control.in: Depend on lsb >= 3.2-14, which has the
    status_of_proc() function.
  * debian/gdm.init: Add the 'status' action (LP: #251375).

 -- Martin Pitt <email address hidden> Tue, 29 Jul 2008 11:51:29 +0200

Changed in gdm:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers