Activity log for bug #1315442

Date Who What changed Old value New value Message
2014-05-02 16:11:42 Owen Dunn bug added bug
2014-06-12 13:20:22 Launchpad Janitor gdm (Ubuntu): status New Confirmed
2014-09-22 13:14:33 babazako@yahoo.com bug added subscriber babazako@yahoo.com
2015-03-01 22:18:09 Tim Lunn bug task added ubuntu-gnome
2015-03-01 22:18:17 Tim Lunn ubuntu-gnome: milestone vivid
2015-03-01 22:19:51 Tim Lunn nominated for series Ubuntu Trusty
2015-03-01 22:19:51 Tim Lunn bug task added gdm (Ubuntu Trusty)
2015-03-31 18:31:02 Launchpad Janitor gdm (Ubuntu Trusty): status New Confirmed
2015-04-03 03:15:53 not-used-anymore attachment added Fix for LP: #1315442 - removed line 73 (extra "fi") - tested on Ubuntu-Gnome vivid https://bugs.launchpad.net/ubuntu/+source/gdm/+bug/1315442/+attachment/4364854/+files/gdm_3.14.1-0ubuntu3.debdiff
2015-04-03 04:04:52 Adam Conrad tags patch
2015-04-03 04:05:13 Adam Conrad bug added subscriber Ubuntu Sponsors Team
2015-04-03 04:05:27 Adam Conrad nominated for series Ubuntu Utopic
2015-04-03 04:05:27 Adam Conrad bug task added gdm (Ubuntu Utopic)
2015-04-03 10:41:42 not-used-anymore attachment added trusty fix for LP: #1315442 - removed line 73 (extra "fi") - tested on Ubuntu-Gnome trusty https://bugs.launchpad.net/ubuntu/+source/gdm/+bug/1315442/+attachment/4364972/+files/trusty-gdm_3.10.0.1-0ubuntu3.2.debdiff
2015-04-03 14:55:08 not-used-anymore attachment added utopic fix for LP: #1315442 - removed line 78 (extra "fi") - tested on Ubuntu-Gnome utopic https://bugs.launchpad.net/ubuntu/+source/gdm/+bug/1315442/+attachment/4365125/+files/gdm_3.10.0.1-0ubuntu7.2.debdiff
2015-04-03 14:56:13 not-used-anymore attachment removed vivid fix for LP: #1315442 - removed line 73 (extra "fi") - tested on Ubuntu-Gnome vivid https://bugs.launchpad.net/ubuntu/+source/gdm/+bug/1315442/+attachment/4364854/+files/gdm_3.14.1-0ubuntu3.debdiff
2015-04-03 14:56:41 not-used-anymore attachment removed utopic fix for LP: #1315442 - removed line 78 (extra "fi") - tested on Ubuntu-Gnome utopic https://bugs.launchpad.net/ubuntu/+source/gdm/+bug/1315442/+attachment/4365125/+files/gdm_3.10.0.1-0ubuntu7.2.debdiff
2015-04-03 15:00:49 not-used-anymore attachment added utopic fix for LP: #1315442 - removed line 78 (extra "fi") - tested on Ubuntu-Gnome utopic https://bugs.launchpad.net/ubuntu/+source/gdm/+bug/1315442/+attachment/4365128/+files/gdm_3.10.0.1-0ubuntu7.2.debdiff
2015-04-03 21:18:18 not-used-anymore attachment added vivid fix for LP: #1315442 - removed line 73 (extra "fi") - tested on Ubuntu-Gnome vivid https://bugs.launchpad.net/ubuntu/+source/gdm/+bug/1315442/+attachment/4365455/+files/vivid-gdm_3.14.1-0ubuntu3.debdiff
2015-04-03 23:44:52 Launchpad Janitor branch linked lp:ubuntu/vivid-proposed/gdm
2015-04-03 23:56:52 Launchpad Janitor gdm (Ubuntu): status Confirmed Fix Released
2015-04-04 00:53:35 Adam Conrad gdm (Ubuntu Trusty): status Confirmed Fix Committed
2015-04-04 00:53:38 Adam Conrad bug added subscriber Ubuntu Stable Release Updates Team
2015-04-04 00:53:39 Adam Conrad bug added subscriber SRU Verification
2015-04-04 00:53:42 Adam Conrad tags patch patch verification-needed
2015-04-04 00:54:19 Adam Conrad gdm (Ubuntu Utopic): status New Fix Committed
2015-04-04 00:54:37 Adam Conrad removed subscriber Ubuntu Sponsors Team
2015-04-04 01:02:24 Launchpad Janitor branch linked lp:ubuntu/trusty-proposed/gdm
2015-04-04 01:02:25 Launchpad Janitor branch linked lp:ubuntu/utopic-proposed/gdm
2015-04-04 03:23:40 not-used-anymore description Ubuntu release 14.04 LTS gdm 3.10.0.1-0ubuntu3 I just tried to start gdm with "/etc/init.d/gdm start " and got the message: /etc/init.d/gdm: 79: /etc/init.d/gdm: Syntax error: "fi" unexpected (expecting "}") I'm aware of service(8) but cjwatson said I should report this as a bug anyway! Owen Ubuntu release 14.04 LTS gdm 3.10.0.1-0ubuntu3 I just tried to start gdm with "/etc/init.d/gdm start " and got the message: /etc/init.d/gdm: 79: /etc/init.d/gdm: Syntax error: "fi" unexpected (expecting "}") I'm aware of service(8) but cjwatson said I should report this as a bug anyway! Owen SRU Information: [Impact] * Anyone who tries to use the sysv style /etc/init.d/gdm script to control gdm may get a syntax error which disallows the script from running, bombing out to the command line with an unfriendly error * This problem effects vivid, utopic and trusty. Without this fix backported, the functionality of the sysv style script for controlling the gdm service is broken under certain circumstances. The resulting unfriendly error is also unprofessional and gives a feeling of brokenness to Ubuntu in all three of these releases, including the ones to be backported to. * This upload is a series of three patches. The syntax error results from a single line in each of the debian/gdm.init files which get installed as the /etc/init.d/gdm shell script. The problem is an extra unmatched "fi" that results in a syntax error if the corresponding line is interpreted [Test Case] * To test the fix in vivid, type the following commands before and after the updated package is installed: cd /etc/init.d sudo ./gdm If the script exits with a syntax error before the package with the fix is installed, you have verified the bug. If the script exits with a syntax error after the package is installed, the fix did not work. If the script does not indicate a syntax error after the package is installed, the fix worked To test the fix on utopic, do the identical test as in vivid above but instead use the following single command to invoke the script: sudo /etc/init.d/gdm To test the fix on trusty, do the test as in vivid and utopic, but use the following commands to change directories and invoke the script: cd /etc/init.d sudo ./gdm sudo ./gdm start In this case, both times you run the script it should exit with the syntax error before installing the package and neither time after installing the package. [Regression Potential] * Any scripts which may call this script which happen to mistakenly rely on it to fail could perhaps behave differently, with unknown results possible [Other Info] * Using or not using sudo before each command may affect the tests with varying output that may be unexpected. In all cases, however, if the script bombs on a syntax error happens mentioning a line number and "fi" the test definitely either verified the bug or definitively showed the package did not fix the bug (or was not installed correctly). A situation which arose during the testing is that depending on the whether the patch is on vivid, utopic or trusty, calling the script in different ways (fully qualified path vs. changing the current directory to /etc/init.d and using ./gdm, for instance, or including or not including the 'start' parameter) causes the test to behave differently, for instance failing silently or working depending on how the script is called even with the syntax error present. This is why there are different command lines for each version of the patch for testing. I did some tracing on why this happened, and the reasons seem buried deep within the trees of scripts called beneath /etc/init.d/gdm and are outside the scope of this fix and do not invalidate this fix. This fix deals with a simple top level shell script syntax error that can be successfully tested for as indicated above.
2015-04-05 21:13:23 Tim Lunn ubuntu-gnome: milestone vivid trusty.3
2015-04-30 05:46:40 Mathew Hodson tags patch verification-needed patch trusty verification-needed
2015-07-08 19:33:41 Ubuntu Foundations Team Bug Bot bug added subscriber Brian Murray
2015-07-08 19:33:44 Ubuntu Foundations Team Bug Bot tags patch trusty verification-needed patch trusty verification-failed verification-needed
2015-10-23 04:51:51 Tim Lunn tags patch trusty verification-failed verification-needed patch trusty verification-needed
2015-10-23 04:52:42 Tim Lunn bug added subscriber Tim
2015-10-26 06:12:15 Mathew Hodson gdm (Ubuntu Utopic): status Fix Committed Won't Fix
2015-10-26 06:15:40 Mathew Hodson gdm (Ubuntu Utopic): importance Undecided Low
2015-10-26 06:15:43 Mathew Hodson gdm (Ubuntu Trusty): importance Undecided Low
2015-10-26 06:15:45 Mathew Hodson gdm (Ubuntu): importance Undecided Low
2015-12-06 10:49:03 Bruce Pieterse ubuntu-gnome: status New Triaged
2016-03-08 20:30:26 Ubuntu Foundations Team Bug Bot tags patch trusty verification-needed patch removal-candidate trusty verification-needed
2016-03-08 23:09:38 Tim Lunn tags patch removal-candidate trusty verification-needed patch trusty verification-done
2016-03-09 17:52:40 Launchpad Janitor gdm (Ubuntu Trusty): status Fix Committed Fix Released
2016-03-09 17:52:47 Chris J Arges removed subscriber Ubuntu Stable Release Updates Team
2016-04-25 14:09:44 Bruce Pieterse ubuntu-gnome: status Triaged Fix Released
2016-04-25 14:09:46 Bruce Pieterse ubuntu-gnome: importance Undecided Low