Remove automatically added groups from os-login

[Steve Beattie]

[Impact]

The google_oslogin_control script included in the google-compute-engine-oslogin binary package adds every new user to several unnecessary/unexpected groups. Upstream recommends disabling this behavior.

[Test Case]

Examine the /usr/bin/google_oslogin_control and ensure that the variable
assignment for

  group_conf_entry

in the modify_group_conf() function does not contain any of the following groups:

  dip, plugdev, adm, docker, lxd

[Regression Potential]

Implemented incorrectly, this could break group setup for users on new gce instances. Users may also have to alter configuration management tools that expect users to already have access to e.g. the docker or lxd group by default.

[References]

Upstream PR and commits:

  https://github.com/GoogleCloudPlatform/guest-oslogin/pull/29

  https://github.com/GoogleCloudPlatform/guest-oslogin/commit/50b0fb7b5804c22ef9581e7dc91875801dfa5469

  https://github.com/GoogleCloudPlatform/guest-oslogin/pull/30

  https://github.com/GoogleCloudPlatform/guest-oslogin/commit/88f1ba85e20b3b3a07bfad2eeb723a6b06e41fc8

[Launchpad Janitor (janitor)]

This bug was fixed in the package gce-compute-image-packages - 20190801-0ubuntu5

---------------
gce-compute-image-packages (20190801-0ubuntu5) groovy; urgency=medium

  * Disable automatic adding of groups to all users (LP: #1878654)
    - d/p/0006-Remove-OS-Login-users-from-admin-groups.-29.patch: remove
      adm, docker, and lxd groups
    - d/p/0007-Remove-local-user-groups-for-OS-Login-users.-30.patch:
      remove dip and plugdev groups

 -- Steve Beattie <email address hidden> Thu, 14 May 2020 15:25:37 -0700

[Steve Beattie (sbeattie)]

Because these packages may end up getting copied to the security pockets, these have been built in the ubuntu-security-proposed ppa:

  https://launchpad.net/~ubuntu-security-proposed/+archive/ubuntu/ppa/

Direct links to the packages are

focal:
  https://launchpad.net/~ubuntu-security-proposed/+archive/ubuntu/ppa/+sourcepub/11292227/+listing-archive-extra

eoan:
  https://launchpad.net/~ubuntu-security-proposed/+archive/ubuntu/ppa/+sourcepub/11292236/+listing-archive-extra

bionic:
  https://launchpad.net/~ubuntu-security-proposed/+archive/ubuntu/ppa/+sourcepub/11292244/+listing-archive-extra

xenial:
  https://launchpad.net/~ubuntu-security-proposed/+archive/ubuntu/ppa/+sourcepub/11292249/+listing-archive-extra

[David Krauser (davidkrauser)]

The updated packages have been verified in GCE and work as expected.

[Steve Beattie (sbeattie)]

Thanks, David, for the feedback, marking all versions as verification-done.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gce-compute-image-packages - 20190801-0ubuntu4.1

---------------
gce-compute-image-packages (20190801-0ubuntu4.1) focal; urgency=medium

  * Disable automatic adding of groups to all users (LP: #1878654)
    - d/p/0006-Remove-OS-Login-users-from-admin-groups.-29.patch: remove
      adm, docker, and lxd groups
    - d/p/0007-Remove-local-user-groups-for-OS-Login-users.-30.patch:
      remove dip and plugdev groups

 -- Steve Beattie <email address hidden> Thu, 14 May 2020 15:25:37 -0700

[Launchpad Janitor (janitor)]

This bug was fixed in the package gce-compute-image-packages - 20190801-0ubuntu1.1

---------------
gce-compute-image-packages (20190801-0ubuntu1.1) eoan; urgency=medium

  * Disable automatic adding of groups to all users (LP: #1878654)
    - d/p/0006-Remove-OS-Login-users-from-admin-groups.-29.patch: remove
      adm, docker, and lxd groups
    - d/p/0007-Remove-local-user-groups-for-OS-Login-users.-30.patch:
      remove dip and plugdev groups

 -- Steve Beattie <email address hidden> Thu, 14 May 2020 16:42:42 -0700

[Launchpad Janitor (janitor)]

This bug was fixed in the package gce-compute-image-packages - 20190801-0ubuntu1~18.04.1

---------------
gce-compute-image-packages (20190801-0ubuntu1~18.04.1) bionic; urgency=medium

  * Disable automatic adding of groups to all users (LP: #1878654)
    - d/p/0006-Remove-OS-Login-users-from-admin-groups.-29.patch: remove
      adm, docker, and lxd groups
    - d/p/0007-Remove-local-user-groups-for-OS-Login-users.-30.patch:
      remove dip and plugdev groups

 -- Steve Beattie <email address hidden> Thu, 14 May 2020 16:44:15 -0700

[Launchpad Janitor (janitor)]

This bug was fixed in the package gce-compute-image-packages - 20190801-0ubuntu1~16.04.1

---------------
gce-compute-image-packages (20190801-0ubuntu1~16.04.1) xenial; urgency=medium

  * Disable automatic adding of groups to all users (LP: #1878654)
    - d/p/0006-Remove-OS-Login-users-from-admin-groups.-29.patch: remove
      adm, docker, and lxd groups
    - d/p/0007-Remove-local-user-groups-for-OS-Login-users.-30.patch:
      remove dip and plugdev groups

 -- Steve Beattie <email address hidden> Thu, 14 May 2020 17:05:31 -0700

[Łukasz Zemczak (sil2100)]

Hello Steve, or anyone else affected,

Accepted google-compute-engine-oslogin into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/google-compute-engine-oslogin/20200925.00-0ubuntu3~18.04.0 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Łukasz Zemczak (sil2100)]

Hello Steve, or anyone else affected,

Accepted google-compute-engine-oslogin into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/google-compute-engine-oslogin/20200925.00-0ubuntu3~20.04.0 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Łukasz Zemczak (sil2100)]

Hello Steve, or anyone else affected,

Accepted google-compute-engine-oslogin into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/google-compute-engine-oslogin/20200925.00-0ubuntu3~16.04.0 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Łukasz Zemczak (sil2100)]

This bug has been pulled in via the backported changelog of google-compute-engine-oslogin. Let's mark this as 'verification-done' and perform all the actual verification in LP: #1899629 instead.

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for google-compute-engine-oslogin has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.