Shutdown scripts do not run on 1404 images with gce-compute-image-packages installed

[Philip Roche]

[Impact]

 * Trusty images with gce-compute-image-packages package installed do not run shutdown scripts.

[Test Case]

We have a number of automated tests that run against all GCE builds that include this package.

 * There are numerous tests:
   * ntp conf
   * expected packages are installed
   * expected services are running
   * SSH access
   * Kernel Config
   * Hosts file is as expected

These run as part of Ubuntu cloud image for GCE creation.

All of these tests pass.

 * The simplest way to test this patch manually is to launch a GCE instance with this package installed specifying a shutdown script

`gcloud compute instances create daily-ubuntu-shutdown2-1404-trusty-v20170222-2 --image-project ubuntu-os-cloud-devel --image "daily-ubuntu-shutdown2-1404-trusty-v20170222" --metadata shutdown-script="#! /bin/bash
touch /home/ubuntu/shutdowntrusty.txt"`

reboot or shutdown this instance. Upon restarting the instance you will notice that /home/ubuntu/shutdowntrusty.txt has been created.

[Regression Potential]

 * Most harmful regression potential is GCE instance not shutting down. This has been tested and is not the case.

[Other Info]

 * This change has been requested by GCE and is a requirement for any future Ubuntu cloud images for GCE. They are very eager to get this fixed.

* Should you wish to test/observe previous behaviour, image daily-ubuntu-philroche-1404-trusty-v20170216 in ubuntu-os-cloud-devel has the previous version of the package installed and does not run the shutdown scripts.

_Original Description_

Trusty images with gce-compute-image-packages package installed so not run shutdown scripts.

Image daily-ubuntu-philroche-1404-trusty-v20170216 in ubuntu-os-cloud-devel is one such image.

[Philip Roche (philroche)]

Fix where GCE shutdown scripts are run during shutdown when using Upstart

[Philip Roche (philroche)]

The above patch has passed all internal tests and been verified by the GCE team.

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "lp1667277-fix-shutdown-script-ordering-upstart.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

[Mathieu Trudel-Lapierre (cyphermox)]

Sponsored the changes. These do not apply to zesty as they are specific to upstart use.

[Philip Roche (philroche)]

Updated patch using correct version number 20160930-0ubuntu3~14.04.1

[Steve Langasek (vorlon)]

Hello Philip, or anyone else affected,

Accepted gce-compute-image-packages into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gce-compute-image-packages/20160930-0ubuntu3~14.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Philip Roche (philroche)]

This has now been verified successfully manually and with automated testing. I have tagged this bug verification-done

[Launchpad Janitor (janitor)]

This bug was fixed in the package gce-compute-image-packages - 20160930-0ubuntu3~14.04.1

---------------
gce-compute-image-packages (20160930-0ubuntu3~14.04.1) trusty; urgency=medium

  * Fix where GCE shutdown scripts are run during shutdown when using Upstart (LP: #1667277)

 -- Phil Roche <email address hidden> Thu, 23 Feb 2017 13:29:15 -0500

[Steve Langasek (vorlon)]

The verification of the Stable Release Update for gce-compute-image-packages has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.