reboot tests fail to build on gccgo

[Curtis Hovey]

The reboot tests cannot be built on ppc64el which uses the gccgo compiler.

We see
    FAIL github.com/juju/juju/api/reboot [build failed]

which is confirmed by this output earlier in the unittest log

# testmain
/tmp/go-build573700990/github.com/juju/juju/api/reboot/_test/github.com/juju/juju/api/libreboot.a(reboot.o): In function `github_com_juju_juju_api_reboot.ClearReboot.pN37_github_com_juju_juju_api_reboot.State':
/home/ubuntu/juju-core_1.21-alpha2/src/github.com/juju/juju/api/reboot/reboot.go:67: multiple definition of `github_com_juju_juju_api_reboot.ClearReboot.pN37_github_com_juju_juju_api_reboot.State'
/tmp/go-build573700990/github.com/juju/juju/api/libreboot.a(reboot.o):/home/ubuntu/juju-core_1.21-alpha2/src/github.com/juju/juju/api/reboot/reboot.go:67: first defined here
/tmp/go-build573700990/github.com/juju/juju/api/reboot/_test/github.com/juju/juju/api/libreboot.a(reboot.o): In function `github_com_juju_juju_api_reboot.GetRebootAction.pN37_github_com_juju_juju_api_reboot.State':
/home/ubuntu/juju-core_1.21-alpha2/src/github.com/juju/juju/api/reboot/reboot.go:90: multiple definition of `github_com_juju_juju_api_reboot.GetRebootAction.pN37_github_com_juju_juju_api_reboot.State'
/tmp/go-build573700990/github.com/juju/juju/api/libreboot.a(reboot.o):/home/ubuntu/juju-core_1.21-alpha2/src/github.com/juju/juju/api/reboot/reboot.go:90: first defined here
/tmp/go-build573700990/github.com/juju/juju/api/reboot/_test/github.com/juju/juju/api/libreboot.a(reboot.o): In function `github_com_juju_juju_api_reboot.RequestReboot.pN37_github_com_juju_juju_api_reboot.State':
/home/ubuntu/juju-core_1.21-alpha2/src/github.com/juju/juju/api/reboot/reboot.go:45: multiple definition of `github_com_juju_juju_api_reboot.RequestReboot.pN37_github_com_juju_juju_api_reboot.State'
/tmp/go-build573700990/github.com/juju/juju/api/libreboot.a(reboot.o):/home/ubuntu/juju-core_1.21-alpha2/src/github.com/juju/juju/api/reboot/reboot.go:45: first defined here
/tmp/go-build573700990/github.com/juju/juju/api/reboot/_test/github.com/juju/juju/api/libreboot.a(reboot.o): In function `github_com_juju_juju_api_reboot.WatchForRebootEvent.pN37_github_com_juju_juju_api_reboot.State':
/home/ubuntu/juju-core_1.21-alpha2/src/github.com/juju/juju/api/reboot/reboot.go:30: multiple definition of `github_com_juju_juju_api_reboot.WatchForRebootEvent.pN37_github_com_juju_juju_api_reboot.State'
/tmp/go-build573700990/github.com/juju/juju/api/libreboot.a(reboot.o):/home/ubuntu/juju-core_1.21-alpha2/src/github.com/juju/juju/api/reboot/reboot.go:30: first defined here
/tmp/go-build573700990/github.com/juju/juju/api/reboot/_test/github.com/juju/juju/api/libreboot.a(reboot.o):(.data.rel.ro.__go_tdn_github_com_juju_juju_api_reboot.State+0x0): multiple definition of `__go_tdn_github_com_juju_juju_api_reboot.State'
/tmp/go-build573700990/github.com/juju/juju/api/libreboot.a(reboot.o):(.data.rel.ro.__go_tdn_github_com_juju_juju_api_reboot.State+0x0): first defined here
/tmp/go-build573700990/github.com/juju/juju/api/reboot/_test/github.com/juju/juju/api/libreboot.a(reboot.o): In function `github_com_juju_juju_api_reboot.State$hash':
/home/ubuntu/juju-core_1.21-alpha2/src/github.com/juju/juju/api/reboot/export_test.go:12: multiple definition of `github_com_juju_juju_api_reboot.State$hash'
/tmp/go-build573700990/github.com/juju/juju/api/libreboot.a(reboot.o):/home/ubuntu/juju-core_1.21-alpha2/src/github.com/juju/juju/api/reboot/reboot.go:109: first defined here
/tmp/go-build573700990/github.com/juju/juju/api/reboot/_test/github.com/juju/juju/api/libreboot.a(reboot.o): In function `github_com_juju_juju_api_reboot.State$equal':
/home/ubuntu/juju-core_1.21-alpha2/src/github.com/juju/juju/api/reboot/export_test.go:12: multiple definition of `github_com_juju_juju_api_reboot.State$equal'
/tmp/go-build573700990/github.com/juju/juju/api/libreboot.a(reboot.o):/home/ubuntu/juju-core_1.21-alpha2/src/github.com/juju/juju/api/reboot/reboot.go:109: first defined here
/tmp/go-build573700990/github.com/juju/juju/api/reboot/_test/github.com/juju/juju/api/libreboot.a(reboot.o):(.rodata.github_com_juju_juju_api_reboot.NewState$descriptor+0x0): multiple definition of `github_com_juju_juju_api_reboot.NewState$descriptor'
/tmp/go-build573700990/github.com/juju/juju/api/libreboot.a(reboot.o):(.rodata.github_com_juju_juju_api_reboot.NewState$descriptor+0x0): first defined here
/tmp/go-build573700990/github.com/juju/juju/api/reboot/_test/github.com/juju/juju/api/libreboot.a(reboot.o): In function `github_com_juju_juju_api_reboot.NewState':
/home/ubuntu/juju-core_1.21-alpha2/src/github.com/juju/juju/api/reboot/reboot.go:20: multiple definition of `github_com_juju_juju_api_reboot.NewState'
/tmp/go-build573700990/github.com/juju/juju/api/libreboot.a(reboot.o):/home/ubuntu/juju-core_1.21-alpha2/src/github.com/juju/juju/api/reboot/reboot.go:20: first defined here
collect2: error: ld returned 1 exit status

I believe these tests were introduced in commit 6ffffa3

[Martin Packman (gz)]

This is reminiscent of bug 1289067 but it's not clear why the reboot api addition triggered the failures. I can't reproduce the linker error on amd64 with gccgo.

[Martin Packman (gz)]

As this is blocking developers landing code, I am going ahead and working around this by not building the problem test file. There is almost certainly a ppc64/gccgo bug in need of fixing here.

[Casey Marshall (cmars)]

I am getting the above error when I try to run tests on amd64 with gccgo 4.9.

http://paste.ubuntu.com/8827836/

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Casey Marshall (cmars)]

^^ in juju master @ a7e1ea03bb98064a5173e2200335d641fde511a5

[Michael Hudson-Doyle (mwhudson)]

Here's a gccgo-go patch that fixes the problem.

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "avoid-duplicate-symbols-when-testing.diff" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

[Martin Packman (gz)]

Thanks Michael! I guess I'll need to be pretty conservative about removing the workaround in juju as we're testing on multiple ubuntu releases.

[Michael Hudson-Doyle (mwhudson)]

Yes, unless we can get this fix into all releases we care about (just as
far back as trusty, right?)

[Michael Hudson-Doyle (mwhudson)]

FWIW, I've send the fix upstream now the tree has reopened: https://go-review.googlesource.com/1840

[Dimiter Naydenov (dimitern)]

Related bug 1417771. Let's release an updated version of gccgo-go for trusty at least, if not precise. In vivid, a more recent release (1.2.1-0ubuntu7 ) has the fix.

[Dimiter Naydenov (dimitern)]

It turns out the vivid package does not yet have the needed patch from https://go-review.googlesource.com/#/c/1840/ we'll have to wait for an upstream release I guess.

[Dave Cheney (dave-cheney)]

The attached patch for gccgo-1.2.1~ubuntu1 ensures that the external test package is always presented to the linker before the internal test package.

Tested against juju/juju 1.23 (something) by building and running all tests.

No linking failures during the test run

[Matthias Klose (doko)]

it's not clear what needs to be done for gcc-4.9. please specify.

[Matthias Klose (doko)]

gccgo-go is removed in vivid, superseded by gccgo-5

[Dave Cheney (dave-cheney)]

The fix for gccgo-5 has landed upstream

https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=221782

Can gccgo-5 in Vivid be rebuilt at or after revision 221782.

The patch is also available and should apply cleanly to gccgo-go in Trusty.

https://codereview.appspot.com/222890043

[Launchpad Janitor (janitor)]

This bug was fixed in the package gccgo-5 - 5-20150401-0ubuntu1

---------------
gccgo-5 (5-20150401-0ubuntu1) vivid; urgency=medium

  * Update to SVN 20150401.
    - go/cmd/go: always link external test packages first. LP: #1381671.
 -- Matthias Klose <email address hidden> Wed, 01 Apr 2015 11:57:15 +0200