Upstart loses track of gmond depending on user configuration

[Dylan McCall]

The Upstart script for ganglia-monitor (/etc/init/ganglia-monitor.conf) uses `expect fork`, then runs gmond assuming it will be daemonized. This is what happens by default, but it does not always happen! The gmond config file (/etc/ganglia/gmond.conf) includes a "daemonize" parameter, and the debug parameter will also force gmond to run in the foreground. If any of these are changed from their defaults, Upstart will wrongly expect gmond to be daemonized and it will lose track of the process, breaking the service until the system is restarted. This is unexpected behaviour and a bad thing :)

Instead, the Upstart script should not include `expect fork`, and it should explicitly run gmond in the foreground (`exec /usr/sbin/gmond --foreground`), which will override user configuration to the contrary.