no Multi-Arch support

[Stephan Lachnit]

@seb128 please rebase gamemode against the Debian version 1.5.1-4 and include Multi-Arch support. There are a lot of upstream bug reports because 32bit support is missing in Ubuntu.

[Sebastien Bacher (seb128)]

Thank you for taking the time to report this bug and help make Ubuntu better. Unfortunately, we cannot work on this bug because your description didn't include enough information. You may find it helpful to read 'How to report bugs effectively' http://www.chiark.greenend.org.uk/~sgtatham/bugs.html. We'd be grateful if you would then provide a more complete description of the problem.

We have instructions on debugging some types of problems at http://wiki.ubuntu.com/DebuggingProcedures.

At a minimum, we need:
1. The specific steps or actions you took that caused you to encounter the problem.
2. The behavior you expected.
3. The behavior you actually encountered (in as much detail as possible).

Thanks!

[Sebastien Bacher (seb128)]

Could you give example of reports? Is what you are asking for a 32 bits build?

[Stephan Lachnit (stephanlachnit)]

Yes, I'm asking for 32 bit builds, since that is required to inject gamemode to a 32 bit game.

Here are some Bug reports: https://github.com/FeralInteractive/gamemode/issues/254 https://github.com/lutris/lutris/issues/2917 https://github.com/FeralInteractive/gamemode/issues/216 https://github.com/FeralInteractive/gamemode/issues/252

But it's not enough to enable the current build files on 32 bit since that will fail.
The problematic files are debian/libgamemode0.install and debian/libgamemodeauto0.install

There are two easy solutions for that problem:
1) Import the Debian package, it has full Multi-Arch support by now. This requires to put libinih1 into main though.
2) Rebase debian/patch/revert_libinih_depends.patch against the code on Salsa (https://salsa.debian.org/games-team/gamemode)

[Launchpad Janitor (janitor)]

This bug was fixed in the package gamemode - 1.5.1-0ubuntu6

---------------
gamemode (1.5.1-0ubuntu6) groovy; urgency=medium

  * debian/*.install:
    - use the correct paths for other architectures

 -- Sebastien Bacher <email address hidden> Thu, 25 Jun 2020 17:58:01 +0200

[Sebastien Bacher (seb128)]

@Stephan

could you give some details on this statement

> But it's not enough to enable the current build files on 32 bit since that will fail. The problematic files are debian/libgamemode0.install and debian/libgamemodeauto0.install

What's the issue exactly you are refering to? The lack of Multi-Arch informations?
I did an update to G with some of the Debian changes, we should go back in sync later but best to work on a minimal diff to be able to do a stable update with the changes.

The package isn't currently built on 386 yet since it needs to be added to the whitelist, that's being work on and the bug will be updated once it's available for testing

[Steve Langasek (vorlon)]

Seb, if this is a request for addition of this as a top-level library to be supported on i386, please do document this in the discourse thread so we have the rationale all in one place.

There are no requirements beyond that - if someone needs the library and it's not onerous to support, then we provide it on i386.

[Stephan Lachnit (stephanlachnit)]

> What's the issue exactly you are refering to? The lack of Multi-Arch informations?

No I was talking about the things you fixed in 1.5.1-0ubuntu6, thanks btw! But Multi-Arch information is required as well ofc, but that's also already fixed. Should be go to now from what I see.

> I did an update to G with some of the Debian changes, we should go back in sync later but best to work on a minimal diff to be able to do a stable update with the changes.

I think it's fine for now, but once https://bugs.launchpad.net/ubuntu/+source/libinih/+bug/1883890 is fixed I think it makes sense to sync with Debian again. If there are any issues with the package (or possible improvements), feel free to open an issue / PR on the Salsa repo, I will try to comply to reduce duplicate efforts.

[Sebastien Bacher (seb128)]

> I think it's fine for now, but once https://bugs.launchpad.net/ubuntu/+source/libinih/+bug/1883890 is fixed I think it makes sense to sync with Debian again.

Right, I didn't merge with Debian yet because I wanted to do an upload with the minimal changeset needed so it allows us to 'simulate' the SRU. Once we validate that the G package is fine and working the next steps are to SRU that version to focal and then include the other Debian changes