Fwupd missing uefi plugin for riscv64

[Heinrich Schuchardt]

Architecture riscv64 is missing for package fwupd-signed.

[Mario Limonciello (superm1)]

I've made the changes to the packaging for this, I need to get it sponsored in Debian and then it will come back to Ubuntu.

https://salsa.debian.org/efi-team/fwupd-efi/-/commit/b3a4d994820f7e8061f12ca12dfe718703e39995

[Mario Limonciello (superm1)]

So I had a look some more and this is still going to fail, it needs changes in fwupd too.

If you want to see this happen, I'll need you to help with a few things:

0) Does riscv64 have the concept of UEFI secure boot?
If not, then we need to think about what gets signed lots of various code paths in fwupd and fwupd-efi. My template packaging changes might not even make sense anymore.

1) What is the suffix for EFI binaries on riscv64? I looked and don't see GRUB or SHIM building binaries for it.

2) Please submit a patch to fwupd upstream with the support for this suffix here: https://github.com/fwupd/fwupd/blob/204da7a7750d1fa126f3cb913372446821eb6d0b/plugins/uefi-capsule/fu-uefi-common.c#L18

3) can you please make sure that both fwupd and fwupd-efi source packages can build on riscv64 and don't need other code changes?

I'll help land any changes that are needed upstream, but I'll need you to find them first.

[Mario Limonciello (superm1)]

You can see the build failure for fwupd-efi when riscv64 is added to architectures:
https://launchpadlibrarian.net/580380222/buildlog_ubuntu-jammy-riscv64.fwupd-efi_1%3A1.1-4_BUILDING.txt.gz

[Heinrich Schuchardt (xypron)]

Hello Mario,

first thing to work on will be https://github.com/fwupd/fwupd-efi.

I have forked it on https://github.com/xypron/fwupd-efi/tree/riscv. But when building on riscv64 it gave me an error for some x86_64 specific include (cpuid.h). Any suggestions?

Best regards

Heinrich

[Mario Limonciello (superm1)]

I opened up this upstream https://github.com/fwupd/fwupd-efi/issues/19. Share your build log there and hughsie and I can comment on any ideas we have.

[Launchpad Janitor (janitor)]

This bug was fixed in the package fwupd-efi - 1:1.2-2

---------------
fwupd-efi (1:1.2-2) unstable; urgency=medium

  * Correct the signing template to use binary package not source package

 -- Mario Limonciello <email address hidden> Wed, 26 Jan 2022 13:15:00 -0600

[Mario Limonciello (superm1)]

That closing the bug was not correct; it's still not sorted upstream, pending Heinrich's work.

[Mario Limonciello (superm1)]

Upstream fwupd-efi now has riscv support.
https://github.com/fwupd/fwupd-efi/commit/1a794fc7ce481176926687f4e88e6e0c8d5e9699

[Mario Limonciello (superm1)]

Fwupd 1.9.14 is built with uefi capsules plugin for this architecture.

[Jeremy Bícha (jbicha)]

I expect we'll be syncing fwupd-efi 1.5 from Debian in the next few days which adds riscv64 support

[Mario Limonciello (superm1)]

> I expect we'll be syncing fwupd-efi 1.5 from Debian in the next few days which adds riscv64 support

It also means syncing gnu-efi 3.0.18. Is that OK at this stage?