| 2019-01-23 20:06:50 |
Seth Forshee |
bug |
|
|
added bug |
| 2019-01-23 20:06:52 |
Seth Forshee |
tags |
|
kernel-adt-failure |
|
| 2019-01-23 22:47:19 |
Colin Ian King |
fwts (Ubuntu): assignee |
|
Colin Ian King (colin-king) |
|
| 2019-01-23 22:47:21 |
Colin Ian King |
fwts (Ubuntu): importance |
Undecided |
High |
|
| 2019-01-23 22:47:25 |
Colin Ian King |
fwts (Ubuntu): status |
New |
In Progress |
|
| 2019-01-24 10:17:20 |
Colin Ian King |
nominated for series |
|
Ubuntu Bionic |
|
| 2019-01-24 10:17:20 |
Colin Ian King |
bug task added |
|
fwts (Ubuntu Bionic) |
|
| 2019-01-24 10:17:20 |
Colin Ian King |
nominated for series |
|
Ubuntu Xenial |
|
| 2019-01-24 10:17:20 |
Colin Ian King |
bug task added |
|
fwts (Ubuntu Xenial) |
|
| 2019-01-24 10:17:20 |
Colin Ian King |
nominated for series |
|
Ubuntu Disco |
|
| 2019-01-24 10:17:20 |
Colin Ian King |
bug task added |
|
fwts (Ubuntu Disco) |
|
| 2019-01-24 10:17:20 |
Colin Ian King |
nominated for series |
|
Ubuntu Cosmic |
|
| 2019-01-24 10:17:20 |
Colin Ian King |
bug task added |
|
fwts (Ubuntu Cosmic) |
|
| 2019-01-24 10:25:49 |
Colin Ian King |
description |
Testing failed on:
amd64: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-disco-canonical-kernel-team-unstable/disco/amd64/f/fwts/20190123_163310_2b561@/log.gz
arm64: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-disco-canonical-kernel-team-unstable/disco/arm64/f/fwts/20190123_164249_2b561@/log.gz
armhf: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-disco-canonical-kernel-team-unstable/disco/armhf/f/fwts/20190123_164402_2b561@/log.gz
i386: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-disco-canonical-kernel-team-unstable/disco/i386/f/fwts/20190123_163518_2b561@/log.gz
ppc64el: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-disco-canonical-kernel-team-unstable/disco/ppc64el/f/fwts/20190123_163508_2b561@/log.gz |
== SRU Justification, Xenial, Bionic, Cosmic ==
The DKMS kernel module fails to build if new 5.0 kernels are used because of an API change in access_ok().
== Fix ==
Add a kernel version detection and a macro compat fix to paper over the API differences between the two version:
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(5, 0, 0)
+#define ACCESS_OK(type, addr, size) access_ok(addr, size)
+#else
+#define ACCESS_OK(type, addr, size) access_ok(type, addr, size)
+#endif
and use ACCESS_OK instead of access_ok.
== Regression Potential ==
Minimal - this build time change will select the appropriate API, so the final resultant compiled code will be identical to the original before the patch for current kernels, and only different for 5.0+ kernels.
== How To test ==
Install fwts with a 5.0 kernel. Without the fix the dkms build of the efi driver will fail. With the fix it will succeed.
--------------------------------------------------------------------------
Testing failed on:
amd64: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-disco-canonical-kernel-team-unstable/disco/amd64/f/fwts/20190123_163310_2b561@/log.gz
arm64: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-disco-canonical-kernel-team-unstable/disco/arm64/f/fwts/20190123_164249_2b561@/log.gz
armhf: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-disco-canonical-kernel-team-unstable/disco/armhf/f/fwts/20190123_164402_2b561@/log.gz
i386: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-disco-canonical-kernel-team-unstable/disco/i386/f/fwts/20190123_163518_2b561@/log.gz
ppc64el: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-disco-canonical-kernel-team-unstable/disco/ppc64el/f/fwts/20190123_163508_2b561@/log.gz |
|
| 2019-01-24 10:26:25 |
Colin Ian King |
fwts (Ubuntu Xenial): importance |
Undecided |
Low |
|
| 2019-01-24 10:26:27 |
Colin Ian King |
fwts (Ubuntu Bionic): importance |
Undecided |
Low |
|
| 2019-01-24 10:26:31 |
Colin Ian King |
fwts (Ubuntu Cosmic): importance |
Undecided |
Low |
|
| 2019-01-24 10:26:38 |
Colin Ian King |
fwts (Ubuntu Xenial): status |
New |
In Progress |
|
| 2019-01-24 10:26:39 |
Colin Ian King |
fwts (Ubuntu Bionic): status |
New |
In Progress |
|
| 2019-01-24 10:26:42 |
Colin Ian King |
fwts (Ubuntu Cosmic): status |
New |
In Progress |
|
| 2019-01-24 11:02:27 |
Colin Ian King |
bug |
|
|
added subscriber Ubuntu SRU developers |
| 2019-01-24 11:40:43 |
Launchpad Janitor |
fwts (Ubuntu Disco): status |
In Progress |
Fix Released |
|
| 2019-01-25 16:08:57 |
Colin Ian King |
fwts (Ubuntu Cosmic): assignee |
|
Colin Ian King (colin-king) |
|
| 2019-01-25 16:08:59 |
Colin Ian King |
fwts (Ubuntu Bionic): assignee |
|
Colin Ian King (colin-king) |
|
| 2019-01-25 16:09:00 |
Colin Ian King |
fwts (Ubuntu Xenial): assignee |
|
Colin Ian King (colin-king) |
|
| 2019-01-31 23:12:54 |
Brian Murray |
fwts (Ubuntu Cosmic): status |
In Progress |
Fix Committed |
|
| 2019-01-31 23:12:57 |
Brian Murray |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2019-01-31 23:13:00 |
Brian Murray |
bug |
|
|
added subscriber SRU Verification |
| 2019-01-31 23:13:04 |
Brian Murray |
tags |
kernel-adt-failure |
kernel-adt-failure verification-needed verification-needed-cosmic |
|
| 2019-01-31 23:13:54 |
Brian Murray |
fwts (Ubuntu Bionic): status |
In Progress |
Fix Committed |
|
| 2019-01-31 23:13:59 |
Brian Murray |
tags |
kernel-adt-failure verification-needed verification-needed-cosmic |
kernel-adt-failure verification-needed verification-needed-bionic verification-needed-cosmic |
|
| 2019-01-31 23:14:56 |
Brian Murray |
fwts (Ubuntu Xenial): status |
In Progress |
Fix Committed |
|
| 2019-01-31 23:15:03 |
Brian Murray |
tags |
kernel-adt-failure verification-needed verification-needed-bionic verification-needed-cosmic |
kernel-adt-failure verification-needed verification-needed-bionic verification-needed-cosmic verification-needed-xenial |
|
| 2019-02-01 10:12:45 |
Colin Ian King |
tags |
kernel-adt-failure verification-needed verification-needed-bionic verification-needed-cosmic verification-needed-xenial |
kernel-adt-failure verification-done verification-done-bionic verification-done-cosmic verification-done-xenial |
|
| 2019-02-11 09:48:38 |
Łukasz Zemczak |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
| 2019-02-11 09:58:40 |
Launchpad Janitor |
fwts (Ubuntu Cosmic): status |
Fix Committed |
Fix Released |
|
| 2019-02-18 10:15:12 |
Launchpad Janitor |
fwts (Ubuntu Bionic): status |
Fix Committed |
Fix Released |
|
| 2019-02-18 10:15:37 |
Launchpad Janitor |
fwts (Ubuntu Xenial): status |
Fix Committed |
Fix Released |
|
