fwts PCIe ASPM tests are throwing Segmentation fault
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
fwts (Ubuntu) |
Fix Released
|
High
|
Colin Ian King | ||
Trusty |
Fix Released
|
High
|
Colin Ian King |
Bug Description
Problem Description
===================
while running fwts Test in Firestone system on ubuntu14.
Steps to Reproduce
===================
1- Install Firestone system with ubuntu14.
2-install fwts user space tool
3- run test
LOG:
===========
root@system :~# fwts --batch --interactive --power-states
Running 14 tests, results appended to results.log
Test: Gather kernel system information.
Gather kernel signature. 1 info only
Gather kernel system information. 1 info only
Gather kernel boot command line. 1 info only
Gather ACPI driver version. 1 info only
Test: Scan kernel log for Oopses.
Kernel log oops check. 2 passed
Test: Scan kernel log for errors and warnings.
Kernel log error check. 1 passed
Test: General ACPI information test.
Determine Kernel ACPI version. 1 info only
Determine machine's ACPI version.
Determine AML compiler. 1 info only
Test: UEFI secure boot test.
Test aborted..
Test: Test firmware has set PCI Express MaxReadReq to a higher value on n..
Test firmware settings MaxReadReq for PCI Express de.. 1 passed
Test: PCIe ASPM test.
Segmentation faultest. : 42.9% /
root@system:~#
[SRU Justification]
fwts segfaults because the ASPM test on this machine is returning no ACPI tables and the test is not checking for a NULL table and hence dereferencing it causing the segfault While debugging this I also noticed that if /dev/mem is not available then two /dev/mem mmaps may also cause a segfault, so I've added fixes for this too.
[Fix]
Upstream fix 9992dcca169282a
https:/
https:/
[Testcase]
Run fwts on a system without ACPI tables. Will segfault. With the fix, it runs w/o a segfault
affects: | ubuntu → fwts (Ubuntu) |
Changed in fwts (Ubuntu): | |
assignee: | Taco Screen team (taco-screen-team) → Canonical Kernel Team (canonical-kernel-team) |
tags: |
added: severity-high targetmilestone-inin14044 removed: severity-medium targetmilestone-inin14043 |
Changed in fwts (Ubuntu): | |
assignee: | Canonical Kernel Team (canonical-kernel-team) → Colin Ian King (colin-king) |
description: | updated |
Changed in fwts (Ubuntu Trusty): | |
importance: | Undecided → Medium |
importance: | Medium → High |
Changed in fwts (Ubuntu Trusty): | |
assignee: | nobody → Colin Ian King (colin-king) |
Changed in fwts (Ubuntu): | |
status: | In Progress → Fix Committed |
status: | Fix Committed → Fix Released |
Default Comment by Bridge