| 2013-07-12 11:47:51 |
Colin Ian King |
description |
ASL now has some very useful "Remark" feedback, so we should think about getting this output also logged in the syntaxcheck test. I suggest a --syntaxcheck-pedantic option that turns this on, or maybe we should just enable it by default and make the warnings a low level failure.
Example remark:
DSDT.dsl 5811: Method (_BIF, 0, NotSerialized)
Remark 2120 - ^ Control Method should be made Serialized (due to creation of named objects within)
..so this is useful since the _BIF control is tagged as NotSerialized yet it should be to stop potential race conditions.
This requires:
1. Working through all the ASL remarks and adding this to the .json database
2. Either adding the --syntaxcheck-pedantic flag, or enabling this by default. |
ASL now has some very useful "Remark" feedback, so we should think about getting this output also logged in the syntaxcheck test. I suggest a --syntaxcheck-pedantic option that turns this on, or maybe we should just enable it by default and make the warnings a low level failure.
Example remark:
DSDT.dsl 5811: Method (_BIF, 0, NotSerialized)
Remark 2120 - ^ Control Method should be made Serialized (due to creation of named objects within)
..so this is useful since the _BIF control is tagged as NotSerialized yet it should be to stop potential race conditions.
This requires:
1. Working through all the ASL remarks and adding these to the .json database
2. Either adding the --syntaxcheck-pedantic flag, or enabling this by default. |
|
