Mentions disappear

Bug #1272101 reported by Kai Mast
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
friends (Ubuntu)
Invalid
Undecided
Kai Mast

Bug Description

Sometimes the mention tab is just empty. I am not sure why this is happening but I guess there is some cleanup in friends that removes old messages?

I would expect that at least 20 of the most recent mentions are show but they aren't.

Rob: Can you point me to where this could happen? I just looked through the code but couldn't find any "cleanup" stuff.

Related branches

Revision history for this message
Robert Bruce Park (robru) wrote :

In main.py it calls prune_model(2000). So if you've received 2000 new messages since the last time you were mentioned, then yes, the mentions will disappear.

Changed in friends-app (Ubuntu):
status: New → Invalid
Revision history for this message
Kai Mast (kai-mast) wrote :

Ah thanks.

So, we would need to change this to prune per stream. Otherwise, the mentions Tab sometimes is empty or just contains one or two messages which looks kind of broken.

Kai Mast (kai-mast)
Changed in friends (Ubuntu):
assignee: nobody → Kai Mast (kai-mast)
status: New → In Progress
Revision history for this message
Kai Mast (kai-mast) wrote :

Think I need some help on how to use GVariant here.

Basically I want to find out which stream each row belongs to so I do something like that while iterating over them:

iter = Model.get_iter_at_row(pos)
stream = Model.get_row(iter).stream

But then I get:
  File "/usr/lib/python3/dist-packages/gi/overrides/Dee.py", line 24, in __getattr__
    raise AttributeError("object has no attribute '%s'" % name)
AttributeError: object has no attribute 'stream'

Not sure if I use it correctly

Revision history for this message
Robert Bruce Park (robru) wrote :

It'd be "Model.get_row(iter)['stream']" i think.

Revision history for this message
Kai Mast (kai-mast) wrote :

Okay I think this is implemented now. Will test it for a week and see if something broke :)

no longer affects: friends-app (Ubuntu)
Revision history for this message
Kai Mast (kai-mast) wrote :

Going to close this as friends is not in development anymore...

Changed in friends (Ubuntu):
status: In Progress → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.