2014-12-28 14:14:35 |
Sebastian Marsching |
bug |
|
|
added bug |
2014-12-28 14:14:35 |
Sebastian Marsching |
attachment added |
|
Suggested patch for logrotate script https://bugs.launchpad.net/bugs/1406105/+attachment/4288786/+files/freeradius_logrotate.patch |
|
2014-12-28 14:21:43 |
Sebastian Marsching |
attachment added |
|
Revised patch for the logrotate script https://bugs.launchpad.net/ubuntu/+source/freeradius/+bug/1406105/+attachment/4288787/+files/freeradius_logrotate.patch |
|
2014-12-28 16:22:09 |
Ubuntu Foundations Team Bug Bot |
tags |
|
patch |
|
2014-12-28 16:22:17 |
Ubuntu Foundations Team Bug Bot |
bug |
|
|
added subscriber Ubuntu Review Team |
2015-02-02 16:10:35 |
Launchpad Janitor |
freeradius (Ubuntu): status |
New |
Confirmed |
|
2015-02-03 12:12:36 |
Robie Basak |
bug |
|
|
added subscriber Ubuntu Server Team |
2015-08-04 15:54:34 |
Robert C Jennings |
freeradius (Ubuntu): assignee |
|
Robert C Jennings (rcj) |
|
2015-08-04 19:25:28 |
Robert C Jennings |
freeradius (Ubuntu): assignee |
Robert C Jennings (rcj) |
|
|
2015-08-05 02:39:10 |
Robert C Jennings |
attachment added |
|
trusty_freeradius_lp1406105.debdiff https://bugs.launchpad.net/ubuntu/+source/freeradius/+bug/1406105/+attachment/4439415/+files/trusty_freeradius_lp1406105.debdiff |
|
2015-08-05 02:39:15 |
Robert C Jennings |
freeradius (Ubuntu): assignee |
|
Robert C Jennings (rcj) |
|
2015-08-05 02:39:30 |
Robert C Jennings |
bug |
|
|
added subscriber Chris J Arges |
2015-08-05 02:39:42 |
Robert C Jennings |
bug |
|
|
added subscriber Robie Basak |
2015-08-05 17:33:33 |
Robert C Jennings |
attachment added |
|
trusty_freeradius_lp1406105.patch https://bugs.launchpad.net/ubuntu/+source/freeradius/+bug/1406105/+attachment/4439874/+files/trusty_freeradius_lp1406105.patch |
|
2015-08-05 17:33:50 |
Robert C Jennings |
freeradius (Ubuntu): status |
Confirmed |
In Progress |
|
2015-08-05 17:36:06 |
Robert C Jennings |
description |
The freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu 14.04 LTS (Trusty Tahr) has a bug in the logrotate script (/etc/logrotate.d/freeradius):
The command /etc/init.d/freeradius reload is used for reloading freeradius after its logfile(s) have been rotated. However, in Ubuntu 14.04 LTS freeradius is managed by Upstart, so that the script cannot work (the PID file does not exist).
Therefore, the logrotate script should use initctl reload freeradius instead. Please note that this might not work either at the moment, due to bug #1282683. However, when this bug is finally fixed, the command mentioned earlier should work. |
The freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu 14.04 LTS (Trusty Tahr) has a bug in the logrotate script (/etc/logrotate.d/freeradius):
The command /etc/init.d/freeradius reload is used for reloading freeradius after its logfile(s) have been rotated. However, in Ubuntu 14.04 LTS freeradius is managed by Upstart, so that the script cannot work (the PID file does not exist).
Therefore, the logrotate script should use initctl reload freeradius instead. Please note that this might not work either at the moment, due to bug #1282683. However, when this bug is finally fixed, the command mentioned earlier should work.
WORKAROUND:
Add an 'exec' in /etc/init/freeradius.conf per the patch in comment #8 and change /etc/logrotate.d/freeradius to use 'service freeradius reload' rather then '/etc/init.d/freeradius reload' as per the same patch in comment #8. Attempt a 'service freeradius stop' and check that the freeradius process is not running (or manually kill it). From there the service can now be started with 'service freeradius start' |
|
2015-08-05 18:49:42 |
Robert C Jennings |
nominated for series |
|
Ubuntu Wily |
|
2015-08-05 18:49:42 |
Robert C Jennings |
nominated for series |
|
Ubuntu Vivid |
|
2015-08-05 18:49:42 |
Robert C Jennings |
nominated for series |
|
Ubuntu Trusty |
|
2015-08-05 18:50:35 |
Robie Basak |
bug task added |
|
freeradius (Ubuntu Trusty) |
|
2015-08-05 18:50:52 |
Robie Basak |
bug task added |
|
freeradius (Ubuntu Vivid) |
|
2015-08-05 18:51:46 |
Robert C Jennings |
freeradius (Ubuntu Vivid): status |
New |
Invalid |
|
2015-08-05 18:51:59 |
Robie Basak |
freeradius (Ubuntu Trusty): status |
New |
Triaged |
|
2015-08-05 18:52:17 |
Robie Basak |
freeradius (Ubuntu Trusty): importance |
Undecided |
Medium |
|
2015-08-05 18:52:39 |
Robert C Jennings |
freeradius (Ubuntu): status |
In Progress |
Invalid |
|
2015-08-05 18:52:45 |
Robert C Jennings |
freeradius (Ubuntu Trusty): status |
Triaged |
In Progress |
|
2015-08-05 18:52:49 |
Robert C Jennings |
freeradius (Ubuntu Trusty): assignee |
|
Robert C Jennings (rcj) |
|
2015-08-05 19:09:36 |
Robert C Jennings |
description |
The freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu 14.04 LTS (Trusty Tahr) has a bug in the logrotate script (/etc/logrotate.d/freeradius):
The command /etc/init.d/freeradius reload is used for reloading freeradius after its logfile(s) have been rotated. However, in Ubuntu 14.04 LTS freeradius is managed by Upstart, so that the script cannot work (the PID file does not exist).
Therefore, the logrotate script should use initctl reload freeradius instead. Please note that this might not work either at the moment, due to bug #1282683. However, when this bug is finally fixed, the command mentioned earlier should work.
WORKAROUND:
Add an 'exec' in /etc/init/freeradius.conf per the patch in comment #8 and change /etc/logrotate.d/freeradius to use 'service freeradius reload' rather then '/etc/init.d/freeradius reload' as per the same patch in comment #8. Attempt a 'service freeradius stop' and check that the freeradius process is not running (or manually kill it). From there the service can now be started with 'service freeradius start' |
[Impact]
* freeradius can not be reloaded, upstart will lose track of the process and leave the original process running (blocking future service starts)
* log rotation will not function as intended. The service is not reloaded and the file handles for the rotated logs will not be dropped. Logging after rotation occurs will consume storage but be inaccessible to the user for review.
[Test Case]
* 'service freeradius start'
* 'service freeradius reload'
* 'service freeradius status' Result stop/waiting
* 'ps -ef|grep freeradius' Result: prior freeradius process still running, new process can not be started. Existing process can not be stopped
* 'service freeradius stop' Result: process does not stop, not tracked up upstart
OR
* 'service freeradius start' Result: PID displayed is for 'sh' not 'freeradius'
* logrotate --verbose --force /etc/logrotate.d/freeradius
* 'service freeradius status' Result: stop/waiting
* 'ps -ef | grep freeradius' Result: freeradius still running (never received HUP)
[Regression Potential]
* Upgrade testing needs to ensure that upgrade does not make a system which still could stop/restart freeradius no longer able to stop/restart without manually killing the freeradius process. Mitigated because the postinst for freeradius will restart the service. The postinst for freeradius-* will reload but will be run after the freeradius postinst has restarted to use our fixed upstart configuration.
* If the user has attempted to reload the service prior to upgrade, which results in freeradius running but no longer managed by upstart, the upgrade will not regress nor fix this environment. In that case the workaround, below, will need to be run (or server restarted) so that upstart can manage freeradius.
[Other Info]
* None
ORIGINAL DESCRIPTION:
The freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu 14.04 LTS (Trusty Tahr) has a bug in the logrotate script (/etc/logrotate.d/freeradius):
The command /etc/init.d/freeradius reload is used for reloading freeradius after its logfile(s) have been rotated. However, in Ubuntu 14.04 LTS freeradius is managed by Upstart, so that the script cannot work (the PID file does not exist).
Therefore, the logrotate script should use initctl reload freeradius instead. Please note that this might not work either at the moment, due to bug #1282683. However, when this bug is finally fixed, the command mentioned earlier should work.
In this case, freeradius is not reloaded so the file handles for the rotated logs will remain open. Logging will cause the disk utilization to increase (log rotation is ineffective) and due to rotation the user can not view the logs from that point forward.
Additionally, if 'service freeradius reload' is run, the service will not be HUP'ed and upstart will lose track of the service, leaving the process running.
WORKAROUND:
Add an 'exec' in /etc/init/freeradius.conf per the patch in comment #8 and change /etc/logrotate.d/freeradius to use 'service freeradius reload' rather then '/etc/init.d/freeradius reload' as per the same patch in comment #8. Attempt a 'service freeradius stop' and check that the freeradius process is not running (or manually kill it). From there the service can now be started with 'service freeradius start' |
|
2015-08-05 19:42:38 |
Robert C Jennings |
attachment added |
|
trusty_freeradius_lp1406105.patch https://bugs.launchpad.net/ubuntu/+source/freeradius/+bug/1406105/+attachment/4439936/+files/trusty_freeradius_lp1406105.patch |
|
2015-08-26 14:43:09 |
Chris J Arges |
freeradius (Ubuntu Trusty): status |
In Progress |
Fix Committed |
|
2015-08-26 14:43:11 |
Chris J Arges |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
2015-08-26 14:43:13 |
Chris J Arges |
bug |
|
|
added subscriber SRU Verification |
2015-08-26 14:43:23 |
Chris J Arges |
tags |
patch |
patch verification-needed |
|
2015-08-26 15:09:56 |
Launchpad Janitor |
branch linked |
|
lp:ubuntu/trusty-proposed/freeradius |
|
2015-08-31 12:14:01 |
Sebastian Marsching |
tags |
patch verification-needed |
patch verification-done |
|
2015-09-09 00:46:15 |
Launchpad Janitor |
freeradius (Ubuntu Trusty): status |
Fix Committed |
Fix Released |
|
2015-09-09 00:46:21 |
Chris Halse Rogers |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
2016-09-09 00:52:46 |
Mathew Hodson |
bug task deleted |
freeradius (Ubuntu Vivid) |
|
|
2016-09-09 00:56:03 |
Mathew Hodson |
freeradius (Ubuntu): status |
Invalid |
Fix Released |
|
2016-09-09 00:56:05 |
Mathew Hodson |
freeradius (Ubuntu): importance |
Undecided |
Medium |
|