Freeplane fails to start in Ubuntu 17.10

[Franck]

SRU for 17.10

[Impact]

The program refuse to start due to file missing from the binary package (MANIFEST.MF)

[Test case]
1. Install freeplane.
2. Attempt to run freeplane.

Expected: program starts and shows a window.
Currently: crashes with the error message below.

[Regression potential]
Low. It rebuilds the package, but with parallel builds disabled. Patch is taken from the latest Debian package.

[Additional notes]
This bug has been a bit annoying, which in turn have led to a possibly confusing bug report. It was initially assumed that a rebuild would fix the issue, and this was verified locally, but since the official build servers ran the build in parallel the issue didn't go away in build1.
Thus, by getting an SRU and through the verification process it should be easier to guarantee and verify that the proposed package contains the required and expected files.

Original report:

Since recent upgrades, freeplane won't start anymore, with this message:

Created Framework: org.knopflerfish.framework, version=8.0.5.
java.io.FileNotFoundException: /usr/share/freeplane/core/org.freeplane.core/META-INF/MANIFEST.MF (Aucun fichier ou dossier de ce type)
 at java.io.FileInputStream.open0(Native Method)
 at java.io.FileInputStream.open(FileInputStream.java:195)
 at java.io.FileInputStream.<init>(FileInputStream.java:138)
 at org.knopflerfish.framework.bundlestorage.file.Archive.downloadArchive(Archive.java:226)
 at org.knopflerfish.framework.bundlestorage.file.BundleArchiveImpl.<init>(BundleArchiveImpl.java:133)
 at org.knopflerfish.framework.bundlestorage.file.BundleStorageImpl.insertBundleJar(BundleStorageImpl.java:219)
 at org.knopflerfish.framework.Bundles.install0(Bundles.java:162)
 at org.knopflerfish.framework.SecurePermissionOps$14.run(SecurePermissionOps.java:737)
 at org.knopflerfish.framework.SecurePermissionOps$14.run(SecurePermissionOps.java:733)
 at java.security.AccessController.doPrivileged(Native Method)
 at org.knopflerfish.framework.SecurePermissionOps.callInstall0(SecurePermissionOps.java:733)
 at org.knopflerfish.framework.Bundles.install(Bundles.java:119)
 at org.knopflerfish.framework.BundleContextImpl.installBundle(BundleContextImpl.java:125)
 at org.knopflerfish.framework.Main.handleArgs(Main.java:550)
 at org.knopflerfish.framework.Main.start(Main.java:224)
 at org.knopflerfish.framework.Main.main(Main.java:156)
 at org.freeplane.launcher.Launcher.run(Launcher.java:127)
 at org.freeplane.launcher.Launcher.launch(Launcher.java:80)
 at org.freeplane.launcher.Launcher.main(Launcher.java:67)
Error: Command "-istart org.freeplane.core" failed, Failed to install bundle: java.io.FileNotFoundException: /usr/share/freeplane/core/org.freeplane.core/META-INF/MANIFEST.MF (Aucun fichier ou dossier de ce type)

ProblemType: Bug
DistroRelease: Ubuntu 17.10
Package: freeplane 1.6.6-1
ProcVersionSignature: Ubuntu 4.13.0-12.13-generic 4.13.3
Uname: Linux 4.13.0-12-generic x86_64
NonfreeKernelModules: zfs zunicode zavl zcommon znvpair
ApportVersion: 2.20.7-0ubuntu2
Architecture: amd64
CurrentDesktop: GNOME
Date: Sun Oct 1 18:48:01 2017
EcryptfsInUse: Yes
PackageArchitecture: all
ProcEnviron:
 TERM=xterm-256color
 PATH=(custom, no user)
 XDG_RUNTIME_DIR=<set>
 LANG=fr_FR.UTF-8
 SHELL=/bin/bash
SourcePackage: freeplane
UpgradeStatus: No upgrade log present (probably fresh install)

[Hans Joachim Desserud (hjd)]

Thanks for taking your time to report this issue and help making Ubuntu better.

I get the same error message when attempting to start freeplane 1.6.6-1 on Ubuntu Artful.

It looks like the underlying issue is the file /usr/share/freeplane/core/org.freeplane.core/META-INF/MANIFEST.MF which is present in the Debian package [1], but the exact same version doesn't contain it in Ubuntu [2]. Not sure how that might happen, but looks like an Ubuntu-only issue.

[1] https://packages.debian.org/sid/all/freeplane/filelist
[2] https://packages.ubuntu.com/artful/all/freeplane/filelist

[Felix Natter (fnatter)]

hello Franck, hello Hans,

thank you for the report. I see a similar issue on Debian sid and buster
(the OSGi plugins are not loaded), but not the same error (Manifests not found).

The problem vanishes on Debian (sid and testing) if I rebuild the same version
(with debian/1.6.6-1 tag) and install it.
So my hope is that this is remediated with a rebuild.

If not, then I need help from Ubuntu devs.
(in this case the short release cycles of Ubuntu are really bad, the package
in this shape should not be part of Ubuntu stable)

If you are desperate to use the latest freeplane on Ubuntu, you can download
the upstream package which includes all dependencies:
https://sourceforge.net/projects/freeplane/files/freeplane%20stable/

Cheers and Best Regards,
Felix

[Hans Joachim Desserud (hjd)]

Hi Felix

I tried a rebuild locally and it seems to have worked. I'm not too familiar with this package but it starts without any error messages and from clicking around a bit it seems to work as expected.

So a no-change rebuild should fix this. Not quite sure why the manifest was missing originally, but it might be some part of the build toolchain out of sync with Debian (?). Hope there aren't too many other packages like this.

I've attached a debdiff, though not sure if that's required for a rebuild. It is there, just in case though ;)

[Simon Quigley (tsimonq2)]

Sponsored.

[Launchpad Janitor (janitor)]

This bug was fixed in the package freeplane - 1.6.6-1build1

---------------
freeplane (1.6.6-1build1) artful; urgency=medium

  * No-change rebuild to pick up MANIFEST.MF file (Fixes LP: #1720670)

 -- Hans Joachim Desserud <email address hidden> Tue, 03 Oct 2017 11:36:50 -0500

[Hans Joachim Desserud (hjd)]

Ok, so it turns out that the rebuild worked fine on my local machine, but the package built by the official build servers still have a missing MANIFEST.MF (https://packages.ubuntu.com/artful/all/freeplane/filelist) :(

Talked a bit with the Debian maintainer which found that the underlying issue is the parallel build of the package. (I suppose the build servers do more aggressive parallelizing than my computer.) A fix is underway for Debian, and we hope to be able to sync or patch the Ubuntu package before the release of Artful as well.

Also found a corresponding bug report in Debian now, so attaching a bug watch.

[Hans Joachim Desserud (hjd)]

As mentioned above, the rebuild only happened to work locally on my machine, but the official build from the build servers still has the same issue in 17.10.

I've therefore picked up the same fix as Debian has in version 1.6.6-3 (see https://anonscm.debian.org/cgit/pkg-java/freeplane.git/commit/?id=48b7e433715de338b8605c6d2ae20e7af9f5b4e1 or the attached bug watch for details). Since the newer version will be synced from Debian to the BB development release, that will effectively be fixed, but an SRU will be needed for 17.10. (That also makes it possible to test and verify that the binary package indeed include the expected files when parallel builds are disabled.

[Robie Basak (racb)]

Thank you for taking care of this!

Uploaded with one minor change: the changelog should target artful, not artful-updates. artful is the current convention (even for SRUs), and I'm told the difference is important.

[Brian Murray (brian-murray)]

Hello Franck, or anyone else affected,

Accepted freeplane into artful-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/freeplane/1.6.6-1ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-artful to verification-done-artful. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-artful. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Franck (alci)]

Freeplane now works with -proposed upgrade.
Thanks !

[Hans Joachim Desserud (hjd)]

Thanks for testing Franck.

I briefly tested the -proposed package too, and it contains the MANIFEST.MF file(s) and starts as expected.

I'm therefore adding the tags as requested, which should make this migrate to -updates pretty soon. :)

[David Thompson (daititt-n)]

Thanks, Brian. I downloaded the pre-releaase version via my Muon Package Manager, and it works fine. I did lose all my previous setting, but this is a small price to pay. I use Freeplane daily for my writing and being deprived of it is a major hardship.
This is at least the second time that a Kubuntu upgrade broke Freeplane. I wonder if anything can be done to prevent it happening again in future upgrades? David

[Launchpad Janitor (janitor)]

This bug was fixed in the package freeplane - 1.6.6-1ubuntu1

---------------
freeplane (1.6.6-1ubuntu1) artful; urgency=medium

  * Fix broken builds by disabling parallel builds (Fixes LP: #1720670)

 -- Hans Joachim Desserud <email address hidden> Fri, 20 Oct 2017 19:48:47 +0200

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for freeplane has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[sinus_asperitatis (sinus-asperitatis)]

Freplane 1.6.6 for me still don't run, if running by terminal I have:

phenom9650@phenom9650-desktop:~$ freeplane
/usr/bin/freeplane: line 210: /usr/lib/jvm/java-7-openjdk-amd64/jre/bin/java/bin/java: No such file or directory

???
I need install java 7 ???

not working with java 8 ???

Thanks

[Hans Joachim Desserud (hjd)]

Hello sinus_asperitatis

Freeplane should run fine with Java8, and it requires either the default-jre package or package provided by openjdk-8-jre (https://packages.ubuntu.com/artful-updates/freeplane). Have you by any chance had Java7 installed at some point, but then removed it? Based on the output it looks like the system has been configured to use Java7, but that it is no longer in place.

Could you please attach the output of the following two commands:
apt policy openjdk-*-jre*
ls -la /etc/alternatives/java
This will tell us which Java (jre) packages you have installed, as well as which one the system will try to use when running java.