FreeImage JXR loading broken due to leaking define

[Fabian Wiesel]

1) Ubuntu 18.04.3 LTS
2) libfreeimage-dev=3.17.0+ds1-5build2, libjxr-dev=1.1-6build1
3) Loading a Jpeg XR file over the api should work, as it is reported as supported.
4) It fails with "unsupported format", because the conversion fails in the libfreeimage library, while the target image is not defined.

In essence, the JXR loading functionality is broken.

In FreeImage.h:132 _WINDOWS_ is defined, leaking over to any other include file.

Injxrlib/guiddef.h:45, the field Data1 is "unsigned long" for windows and 32-bit systems, as the windows abi defaults to 32-bit "unsigned int", while it should be 32-bit.
By becoming 64-bit, the GUID is now 4 bytes longer, which are filled then with "random" data.

Undefining "_WINDOWS_" before including "JXRGlue.h" in PluginJXR.cpp should fix the behaviour.
Better would probably to not leak the definition in the first place, but that seems a more involved task.

Find enclosed the code to attempt to load a jpeg-xr, once directly with jxr, and then with the freeimage library.

[Fabian Wiesel (fwiesel)]

Discovered the upstream bug-report: https://sourceforge.net/p/freeimage/bugs/294/

[Fabian Wiesel (fwiesel)]

Attached a patch, which applies after all previous patches in the debian package.

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "Fix-PluginJXR.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]