fluid missing menu icon

Bug #139980 reported by ChrisC on 2007-09-16
2
Affects Status Importance Assigned to Milestone
fltk1.1 (Debian)
Fix Released
Unknown
fltk1.1 (Ubuntu)
Undecided
Unassigned

Bug Description

Binary package hint: fluid

after installing fluid(1.1.7) there is no icon in applications/programming menu (or elsewhere
for that matter)

xtknight (xt-knight) wrote :

I will work on it. Looks like it puts a shortcut in /usr/share/applnk instead of /usr/share/applications.

Changed in fltk1.1:
assignee: nobody → xt-knight
status: New → In Progress
xtknight (xt-knight) wrote :

This patch should fix the issue. It modifies every occurrence of "applnk/Development" and "applnk/Games" to "applications".

I am not sure about the one such as this:

-%dir %{prefix}/share/applnk
-%{prefix}/share/applnk/Games/*
+%dir %{prefix}/share/applications
+%{prefix}/share/applications/*

The %dir seems to lack Games while the line below it includes Games. In my patch they are both just applications. I am not sure if this will cause any problems, but to my knowledge there are no Games being compiled with the package, and the old way wouldn't have worked.

Using this for the FLUID icon doesn't seem to make a difference, anyhow. The icon shows up and works.

-%dir %{prefix}/share/applnk
-%{prefix}/share/applnk/Development/*
+%dir %{prefix}/share/applications
+%{prefix}/share/applications/*

There were many occurrences of this in the Makefiles and those were also changed. The patch works fine.

xtknight (xt-knight) wrote :

Could someone take a look at the patch, please?

Changed in fltk1.1:
assignee: xt-knight → nobody
status: In Progress → Confirmed
xtknight (xt-knight) wrote :

I just found out this patch may remove the shortcut from KDE. I believe KDE uses /usr/share/applnk?

Daniel Holbach (dholbach) wrote :

Bumping back to 'incomplete' until it's verified that it works for KDE and GNOME

Changed in fltk1.1:
status: Confirmed → Incomplete
xtknight (xt-knight) wrote :

I've gotten report it works with KDE. Reopening.

Changed in fltk1.1:
status: Incomplete → Confirmed
xtknight (xt-knight) wrote :

Actually, I'm going to test this in my own VM and also investigate if Icon should be Icon=fluid rather than the full path. A Debian script (dh_icons or dh_iconcache) may be missing, causing a missing menu icon.

Changed in fltk1.1:
assignee: nobody → xt-knight
status: Confirmed → In Progress
xtknight (xt-knight) wrote :

Thoroughly tested with KDE and GNOME. Works flawlessly in both.

xtknight (xt-knight) wrote :

Would someone take a look at the patch? Thanks.

Changed in fltk1.1:
assignee: xt-knight → nobody
status: In Progress → Confirmed
Daniel Holbach (dholbach) wrote :

Can this change go to Debian and upstream too? I'm not so happy with the direct changes in the fltk source itself, as with the next upstream version things will have to be changed again.

Changed in fltk1.1:
status: Confirmed → Incomplete
Daniel Holbach (dholbach) wrote :

What do you think?

xtknight (xt-knight) wrote :

Daniel Holbach: I think it's a good idea. I will report the bug to the fltk project along with my proposed patch.

But, what do you want to do for now? Just send it upstream to Debian, have it fixed there with my fix, and then sync that to the Ubuntu package? Or do you want to wait until the fltk project is fixed and then implement or backport whatever patch they decide on?

Then, hopefully by the next time Debian pulls packages, it will grab the updated sourceforge. By the time Ubuntu syncs from Debian the problem will be completely gone.

Changed in fltk1.1:
status: Unknown → New
Daniel Holbach (dholbach) wrote :

Thanks for forwarding it. I'd just prefer to have it in upstream before changing so much of the entrails of fltk. Maybe we can find a simple workaround for the problem that lives just in debian/?

Changed in fltk1.1:
status: Incomplete → New
xtknight (xt-knight) wrote :

Daniel: I agree.

What do you mean by a "simple workaround" and which problem (dh_icons?)

Daniel Holbach (dholbach) wrote :

A fix that does not alter the upstream code but only things in debian/ - do you think that's possible?

xtknight (xt-knight) wrote :

Daniel: It is probably possible but the workaround may be a pretty nasty hack. I don't have a whole lot of experience with debian rules files but from what I can tell it is only installing what the Makefile gives it. If the Makefile gives it /usr/share/applnk then debian/rules will expect that to exist. The root of the problem definitely lies in the configure/Makefile itself, which is called during the building of the package.

If you would rather it be a hack than an upstream modification then I'll see what I can do but I'll leave it to others as well if they would like to attempt a "debian/"-only fix. For now I'm not sure how it would work. Maybe the answer lies in a debhelper script to install menus.

xtknight (xt-knight) wrote :

Perhaps somehow symlinking "applications" to "applnk" in the DEBIAN tmp dir of the pkg would do it. Or, renaming that folder after it has compiled but before it installs. I'll see what I can come up with.

Daniel Holbach (dholbach) wrote :

Great. Unsubscribing ubuntu-main-sponsors for now. Please re-subscribe.

xtknight (xt-knight) wrote :

Here is a patch that modifies the debian/ dir only. Can someone take a look at it?

Changed in fltk1.1:
status: New → Confirmed
Daniel Holbach (dholbach) wrote :

Please name it ubuntu1 instead of build2. *build* is for rebuilds only (only changes in debian/changelog).

Changed in fltk1.1:
status: Confirmed → In Progress
xtknight (xt-knight) wrote :

Here you go. I hope this is what you mean.

fltk1.1_1.1.7-4ubuntu1

Changed in fltk1.1:
status: In Progress → Confirmed
Daniel Holbach (dholbach) wrote :

Last thing: http://wiki.ubuntu.com/DebianMaintainerField - but I fixed this myself.

Thanks for the work you put into this and thanks for your patience! Uploading.

xtknight (xt-knight) wrote :

fltk1.1 (1.1.7-4ubuntu1) gutsy; urgency=low

  * debian/rules and debian/fluid.install: move usr/share/applnk/Development
    to usr/share/applications so shortcut appears in GNOME. (LP: #139980)
  * debian/rules: run dh_icons so icon cache is updated.

 -- Andy Matteson <email address hidden> Sat, 06 Oct 2007 16:05:30 -0400

Changed in fltk1.1:
status: Confirmed → Fix Released
Changed in fltk1.1:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.