Adopt to new python-werkzeug 3.0 API

[Lukas Märdian]

Python-werkzeug 3.0 was syncronized from Debian experimental.

The 3.x track is not API compatible with the 2.x track:
https://werkzeug.palletsprojects.com/en/3.0.x/urls/
https://werkzeug.palletsprojects.com/en/2.3.x/urls/

Especially the werkzeug.urls.url_decode method is gone, which leads to import failures like this:

==================================== ERRORS ====================================
_____________ ERROR collecting tests/consumer/storage/test_sqla.py _____________
ImportError while importing test module '/<<PKGBUILDDIR>>/tests/consumer/storage/test_sqla.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/lib/python3.11/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/consumer/storage/test_sqla.py:10: in <module>
    from flask_login import (
/usr/lib/python3/dist-packages/flask_login/__init__.py:12: in <module>
    from .login_manager import LoginManager
/usr/lib/python3/dist-packages/flask_login/login_manager.py:33: in <module>
    from .utils import _create_identifier
/usr/lib/python3/dist-packages/flask_login/utils.py:14: in <module>
    from werkzeug.urls import url_decode
E ImportError: cannot import name 'url_decode' from 'werkzeug.urls' (/usr/lib/python3/dist-packages/werkzeug/urls.py)

[Lukas Märdian (slyon)]

python-werkzeug 3.x from experimental was a dependency to get flask to be Python 3.12 compatible.

[Lukas Märdian (slyon)]

flask-dance should be fixed in 7.0.1 (which FTBFS): https://github.com/singingwolfboy/flask-dance/pull/426

But it depends on the flask-login FTBFS to be fixed first.

[Lukas Märdian (slyon)]

https://launchpad.net/ubuntu/+source/flask-login/0.6.3-1ubuntu1 (This should probably also unlock flask-dance)

[Lukas Märdian (slyon)]

Onionshare, see https://github.com/onionshare/onionshare/issues/1809

[Lukas Märdian (slyon)]

Lektor, see https://github.com/lektor/lektor/pull/1172 (to be fixed in lektor v3.4)

We need to drop the "python-werkzeug < 3" dependency definition in debian/control to fix the installability. And get the required changes land in lektor codebase to make it actually work with that new version of werkzeug3.

[Julian Andres Klode (juliank)]

Unsubscribing Ubuntu sponsors as there are no debdiffs here - and the merges have their own ubuntu sponsors assignee

[Pushkar Kulkarni (pushkarnk)]

Update

Submitted Debian bug reports [1][2] and an MRs [3][4] for lektor and onionshare. [3] has been merged.

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1061361
[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1061360
[3] https://salsa.debian.org/debian/lektor/-/merge_requests/2
[4] https://salsa.debian.org/pkg-privacy-team/onionshare/-/merge_requests/3

[Jeremy Bícha (jbicha)]

I'm adding a flask task so that this shows on the excuses report. Feel free to close the task when this transition is done.

[Pushkar Kulkarni (pushkarnk)]

Debian MRs for onionshare and lektor were merged and the Ubuntu packages synced from Debian.

[Pushkar Kulkarni (pushkarnk)]

Transitioned to main.