update-flashplugin doesn't works

[Xavier Claessens]

flashplugin-nonfree doesn't work since a long time ago... I just read the code and I was VERY surprised by the *poor* quality of update-flashplugin.

1) check_update() checks a list of mirrors to see if a mirror works. But if the host is online but the page on the server doesn't exist anymore this function doesn't try with the next mirror and quit with error message "No new version is detected. ( = not installed)". Here is a patch to solve this error:

--- update-flashplugin 2006-01-10 01:16:15.000000000 +0100
+++ /usr/sbin/update-flashplugin 2006-03-11 20:35:27.000000000 +0100
@@ -290,6 +290,10 @@ class FlashUpdater
             next
           end
         }
+ if !version
+ $stderr.print "E: invalide page format: #{host}\n"
+ failed = true
+ end
         find = host
       rescue Errno::ECONNREFUSED
         $stderr.print "E: Connection was refused: #{host}\n"
2) Assume check_update() find a host, get_file( host ) is called with the host found in parametre... but the first thing this function does is (and i'm not joking):
    host = "fpdownload.macromedia.com"
    path = "/get/flashplayer/current/"
So if we find a valid host we *always* uses fpdownload.macromedia.com/get/flashplayer/current/ instead !!!
The patch for that is easy, just remove those 2 lines and add this mirror in update-flashplugin.conf.rb

3) first mirror of update-flashplugin.conf.rb is dead (host online but page not found) I suggest to remove it (sluglug.ucsc.edu/macromedia/site_ucsc.html)

This bug is very easy to fix, please commit changes before dapper release !