Drop old UC20 boot args

[Dimitri John Ledkov]

[Impact]

 * During early development of uc20 core-initrd additional kernel command-line arguments were required. These were dropped on 20th of April 2020 in the pc gadget.

 * They made it into flash-kernel, and were not dropped at the same time.

 * They are now redundant and mostly harmless during normal mode of operation. However, they get in the way when trying to debug pi initrd.

[Test Plan]

 * Rebuild pi gadget with this update

 * Boot UC20 on pi-armhf or pi-arm64

 * Check that kernel command does not have "systemd.gpt_auto=0 rd.systemd.unit=basic.target"

[Where problems could occur]

 * snapd now has new functionality to append or replace kernel command line. The remain argument that remains is "panic=-1". I am not too sure if the flash-kernel uboot script actually is compatible with the snapd's cmdline full / extra functionality.

[Other Info]

 * Reported at https://github.com/snapcore/core-initrd/pull/28

[Ian Johnson (anonymouse67)]

> I am not too sure if the flash-kernel uboot script actually is compatible with the snapd's cmdline full / extra functionality.

It is not yet compatible unfortunately, and it's not on our immediate roadmap

[Launchpad Janitor (janitor)]

This bug was fixed in the package flash-kernel - 3.104ubuntu5

---------------
flash-kernel (3.104ubuntu5) impish; urgency=medium

  * Drop the "systemd.gpt_auto=0 rd.systemd.unit=basic.target" values from
    the snapd_standard_params, which have not been needed since pre-GA of
    UC20 and were removed in pc gadget on 20th April 2020. LP: #1933093

 -- Dimitri John Ledkov <email address hidden> Mon, 21 Jun 2021 12:12:21 +0100

[Łukasz Zemczak (sil2100)]

Hello Dimitri, or anyone else affected,

Accepted flash-kernel into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/flash-kernel/3.103ubuntu1~20.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Dimitri John Ledkov (xnox)]

Triggered builds of
https://launchpad.net/~canonical-foundations/+snap/pi-armhf-20/+build/1456832
https://launchpad.net/~canonical-foundations/+snap/pi-arm64-20/+build/1456831

They both currently build with proposed by default, and both have been built with the new flash-kernel 3.103ubuntu1~20.04.2

The revisions for them are 104 and 105 published in 20/edge channel.

Will wait for tomorrow's daily pi dangerous edge images and will test boot them over testflinger to verify this sru.

[Dimitri John Ledkov (xnox)]

Submitted:

job_queue: rpi4b8g
provision_data:
    url: https://cdimage.ubuntu.com/ubuntu-core/20/dangerous-edge/20210706/ubuntu-core-20-arm64+raspi.img.xz
test_data:
  test_cmds: |
    ssh ubuntu@$DEVICE_IP snap list
    ssh ubuntu@$DEVICE_IP cat /proc/cmdline

Got back

jq -r .test_output
**************************************************
* Starting testflinger test phase on rpi4b8g-001 *
**************************************************
2021-07-07 11:35:12,118 rpi4b8g_001 INFO: DEVICE AGENT: BEGIN testrun
Name Version Rev Tracking Publisher Notes
core20 20210702 1084 latest/edge canonical* base
pi 20-1 105 20/edge canonical* gadget
pi-kernel 5.4.0-1039.42 314 20/edge canonical* kernel
snapd 2.51.1+git809.gd43ffb4 12587 latest/edge canonical* snapd
 coherent_pool=1M 8250.nr_uarts=1 snd_bcm2835.enable_compat_alsa=0 snd_bcm2835.enable_hdmi=1 video=HDMI-A-1:1920x1080M@60,margin_left=48,margin_right=48,margin_top=48,margin_bottom=48 smsc95xx.macaddr=DC:A6:32:AD:53:33 vc_mem.mem_base=0x3ec00000 vc_mem.mem_size=0x40000000 dwc_otg.lpm_enable=0 console=ttyS0,115200 elevator=deadline rng_core.default_quality=700 vt.handoff=2 quiet splash quiet splash snapd_recovery_mode=run snapd_recovery_system=20210706 panic=-1
2021-07-07 11:35:12,587 rpi4b8g_001 INFO: DEVICE AGENT: END testrun

It confirms that 105 pi gadget was used, and that the kernel cmdline no longer has systemd.gpt_auto=0 rd.systemd.unit=basic.target

Thus this is now verified on arm64.

[Dimitri John Ledkov (xnox)]

Did testflinger submit of

job_queue: rpi4b4g
provision_data:
    url: https://cdimage.ubuntu.com/ubuntu-core/20/dangerous-edge/20210706/ubuntu-core-20-armhf+raspi.img.xz
test_data:
  test_cmds: |
    ssh ubuntu@$DEVICE_IP snap list
    ssh ubuntu@$DEVICE_IP cat /proc/cmdline

which resulted in:

**************************************************
* Starting testflinger test phase on rpi4b8g-001 *

**************************************************

2021-07-07 14:49:49,500 rpi4b8g_001 INFO: DEVICE AGENT: BEGIN testrun
Name Version Rev Tracking Publisher Notes
core20 20210619 1074 latest/edge canonical* base
pi 20-1 104 20/edge canonical* gadget
pi-kernel 5.4.0-1039.42 313 20/edge canonical* kernel
snapd 2.51.1+git809.gd43ffb4 12588 latest/edge canonical* snapd
 coherent_pool=1M 8250.nr_uarts=1 snd_bcm2835.enable_compat_alsa=0 snd_bcm2835.enable_hdmi=1 video=HDMI-A-1:1920x1080M@60,margin_left=48,margin_right=48,margin_top=48,margin_bottom=48 smsc95xx.macaddr=DC:A6:32:AD:53:33 vc_mem.mem_base=0x3ec00000 vc_mem.mem_size=0x40000000 dwc_otg.lpm_enable=0 console=ttyS0,115200 elevator=deadline rng_core.default_quality=700 vt.handoff=2 quiet splash quiet splash snapd_recovery_mode=run snapd_recovery_system=20210706 panic=-1
2021-07-07 14:49:51,629 rpi4b8g_001 INFO: DEVICE AGENT: END testrun

again correct kernel commandline without the extra gpt_auto or rd.systemd.unit options. on armhf this time.

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for flash-kernel has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package flash-kernel - 3.103ubuntu1~20.04.2

---------------
flash-kernel (3.103ubuntu1~20.04.2) focal; urgency=medium

  * Drop the "systemd.gpt_auto=0 rd.systemd.unit=basic.target" values from
    the snapd_standard_params, which have not been needed since pre-GA of
    UC20 and were removed in pc gadget on 20th April 2020. LP: #1933093

 -- Dimitri John Ledkov <email address hidden> Thu, 24 Jun 2021 14:50:39 +0100