[SRU/dapper & edgy] Cannot purge Firestarter

[Matti Lindell]

Binary package hint: firestarter

Ubuntu Edgy
firestarter 1.0.3-1.2ubuntu3

Firestarter package cannot be currently purged. Theres something wrong with .postrm script:

The following packages will be REMOVED:
  firestarter{p}
0 packages upgraded, 0 newly installed, 1 to remove and 0 not upgraded.
Need to get 0B of archives. After unpacking 0B will be used.
Do you want to continue? [Y/n/?] y
Writing extended state information... Done
(Reading database ... 95501 files and directories currently installed.)
Removing firestarter ...
Purging configuration files for firestarter ...
dpkg: error processing firestarter (--purge):
 subprocess post-removal script returned error exit status 1
Errors were encountered while processing:
 firestarter
E: Sub-process /usr/bin/dpkg returned an error code (1)
A package failed to install. Trying to recover:

[Matti Lindell (mlind)]

.postrm script dies when it tries to remove firestarter hook from /etc/dhclient-exit-hooks. workaround is to manually remove the hook and then purge.

[Nicolas DERIVE (kalon33)]

I've the same problem with this package on Edgy too. Mark it as "Confirmed".

[Nicolas DERIVE (kalon33)]

Hello Daniel, I subscribed you to this bug because it seems that this package is orphan : the uploader nor the maintainer have a launchpad account... So I need your help to solve this bug. Thanks for your help.

[Nicolas DERIVE (kalon33)]

Assigned to me : try to find a way to get helped to solve this bug.

[Matti Lindell (mlind)]

Hi Nicolas,

I'll try take a look at the the .postrm script later today and submit a debdiff for the package.

[Nicolas DERIVE (kalon33)]

Can you tell me here when you will have submitted it ? Thanks for you help and your work.

[Matti Lindell (mlind)]

I haven't been able to create the debdiff yet, but I'll try to do it on weekend.

I guess the problem is that firestarter.postrm sets -e for sh shell, which means that the script will bail out if something returns with value 1. This happens if /etc/dhclient-exit-hooks contains only one line (hook that firestarter installed there) and postrm starts grepping with -v option.

Ugly fix would be to remove "set -e" from debian/postrm script. Better way would probably be to use alternative method to remove firestarter hook from /etc/dhclient-exit-hooks. Using sed maybe (sed -i "/firestarter/d" /etc/dhclient-exit-hooks).

[Nicolas DERIVE (kalon33)]

Mlind, had you been able to work on this problem since your previous message ?

[Matti Lindell (mlind)]

sorry I totally forgot this one. I attached a debdiff for edgy which *should* work, but it includes additional dependency for sed. Maybe there's a non-hacky solution to get this work this grep too..

[Matti Lindell (mlind)]

by the way, this seems to affect Feisty's firestarter too.

[Paul Cupis (paul-cupis)]

Is this fixed in Debians current version 1.0.3-2? From the changelog:

  * Fix postrm script on purge (closes: #303973, #338550, #375189)

[Matti Lindell (mlind)]

Yes, it's fixed in Debian.

[Lionel Le Folgoc (mrpouit)]

I merged the debian package.

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Tue, 10 Apr 2007 11:52:55 +0200
Source: firestarter
Binary: firestarter
Architecture: source
Version: 1.0.3-2ubuntu1
Distribution: feisty
Urgency: low
Maintainer: Ubuntu MOTU Developers <email address hidden>
Changed-By: Lionel Le Folgoc <email address hidden>
Description:
 firestarter - gtk program for managing and observing your firewall
Launchpad-Bugs-Fixed: 83728
Changes:
 firestarter (1.0.3-2ubuntu1) feisty; urgency=low
 .
   * Merge from debian unstable. (fixes removal/purge issue, see LP: #83728)
   * Remaining Ubuntu changes:
     + Add "GNOME" to .desktop Categories (closes Ubuntu #42452, #42501)
     + Don't run browser as root (closes Ubuntu #569)
     + debian/firestarter.init: apply patch from Daniel Robitaille adding
       lsb-base functions. Thanks also to Lionel Le Folgoc for taking note of
       this. (Closes: Malone #34217)
   * Adhere to DebianMaintainerField.
   * debian/postinst: use /bin/bash instead of /bin/sh (possible bashism).
Files:
 e355ce680348a55373010a120ee93270 813 admin optional firestarter_1.0.3-2ubuntu1.dsc
 99193fb949b983e30d8e4e6de7a7498e 55540 admin optional firestarter_1.0.3-2ubuntu1.diff.gz
Original-Maintainer: Yann Verley <email address hidden>

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFGG17sRaA1e1F5WRARAqObAJ9krxKwPZgEqp3DWS3szBkALXmOxgCgh283
LrV3EWHyHN1ViYXj8Oc3Pzo=
=hrPU
-----END PGP SIGNATURE-----

[Nicolas DERIVE (kalon33)]

The new version is in the Official Feisty repos.

[Nicolas DERIVE (kalon33)]

Please review the backporting of the new firestarter version which solves this bug to edgy and dapper. Thanks.

[Lionel Le Folgoc (mrpouit)]

Fix backported to edgy. Uploaded into edgy-proposed, awaiting for approval. If it is ack'ed, I'll do the same for dapper-proposed.

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Tue, 10 Apr 2007 21:06:14 +0200
Source: firestarter
Binary: firestarter
Architecture: source
Version: 1.0.3-1.2ubuntu3.1
Distribution: edgy-proposed
Urgency: low
Maintainer: Yann Verley <email address hidden>
Changed-By: Lionel Le Folgoc <email address hidden>
Description:
 firestarter - gtk program for managing and observing your firewall
Changes:
 firestarter (1.0.3-1.2ubuntu3.1) edgy-proposed; urgency=low
 .
   * debian/postrm: backported from feisty to fix removal/purge issues.
     (LP: #83728)
Files:
 b833ca957986b804357b08eea37412dc 746 admin optional firestarter_1.0.3-1.2ubuntu3.1.dsc
 fc757d5b5e04fdf53802ae04da7ca405 32394 admin optional firestarter_1.0.3-1.2ubuntu3.1.diff.gz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)

iD8DBQFGG+NrRaA1e1F5WRARAidBAJ9CUXV/lTTKNdheRFn/uktu73cq9ACdGpev
5PjlUpIP48Xgt+d3cNaZLc0=
=nZGt
-----END PGP SIGNATURE-----

[Martin Pitt (pitti)]

Accepted into edgy-proposed, please go ahead with QA testing.

[Matti Lindell (mlind)]

verified as fixed in edgy-proposed, thanks.

[Cyril Lavier (davromaniak)]

verified as fixed in edgy-proposed too, thanks.

Bye.

[Lionel Le Folgoc (mrpouit)]

Thanks for testing. Uploaded into edgy-updates, waiting for approval.
I am going to prepare the proposed fix for dapper as well.

[Martin Pitt (pitti)]

Lionel, I had to reject your edgy-updates upload because it contains an unrelated change to debian/control:

-Maintainer: Yann Verley <email address hidden>
+Maintainer: Ubuntu MOTU Developers <email address hidden>
+XSBC-Original-Maintainer: Yann Verley <email address hidden>

While this was justified for Feisty, the package tools have not been tested for this new field in Edgy. Please upload it again without the change, using the same version number. Thank you!

[Martin Pitt (pitti)]

Lionel, same applies to the dapper-proposed upload.

[Lionel Le Folgoc (mrpouit)]

Hi,

Martin, I just reuploaded with the DebianMaintainerField.
For dapper-proposed, I also removed the ~proposed1 in the revision according to the new SRU policy.

Thanks.

[Lionel Le Folgoc (mrpouit)]

> Martin, I just reuploaded with the DebianMaintainerField.
Sorry, I meant 'without' of course. ;)

[Kyle McMartin (kyle)]

Accepted into dapper-proposed, please solicit testing as per http://wiki.ubuntu.com/MOTU/SRU

[gapz (gapz-gz-deactivatedaccount)]

works for me (removes/purges without problem)

[Matti Lindell (mlind)]

verified as fixed in dapper-proposed as well, thanks guys.

[Martin Pitt (pitti)]

Upload accepted into edgy-updates.

[Martin Pitt (pitti)]

dapper-proposed upload copied to dapper-updates, thanks for testing.