don't quote log prefix

Bug #253843 reported by avdd
10
Affects Status Importance Assigned to Milestone
firehol (Debian)
New
Undecided
Unassigned
firehol (Ubuntu)
Low
Unassigned

Bug Description

Binary package hint: firehol

firehol's logging looks like this:

Aug 1 11:02:15 foo kernel: [78388.922568] 'IN-WORLD':IN=eth9....

The quotes are unnecessary and annoying. Please remove them.

Related branches

Revision history for this message
Johnathon (kirrus) wrote :

Hello Avdd,

This logging is the standard produced by the underlying inferstructure of firehol (Linux's "iptables"). I'm afraid it can't be altered.

Kind Regards,

Johnathon

Changed in firehol:
status: New → Invalid
Revision history for this message
avdd (avdd) wrote :

Wrong answer. See patch.

Revision history for this message
Johnathon (kirrus) wrote :

My bad :S

Changed in firehol:
status: Invalid → New
Revision history for this message
Brian Murray (brian-murray) wrote :

The patch still applies but seems like a better target for Karmic than Jaunty.

Changed in firehol (Ubuntu):
importance: Undecided → Low
status: New → Triaged
Revision history for this message
Nigel Babu (nigelbabu) wrote :

Thank you for the patch. It doesn't apply anymore to the maverick sources. If you could please refresh it and also forward the patch upstream, that would be great.

tags: added: patch-needswork
Revision history for this message
Phil Whineray (pdw-slightly-cracked) wrote :

Is the reason is that the change (or similar) was already made upstream?

See:
  http://firehol.cvs.sourceforge.net/viewvc/firehol/firehol/firehol.sh?r1=1.292&r2=1.293

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package firehol - 1.296-1

---------------
firehol (1.296-1) unstable; urgency=low

  * New maintainer (Closes: #660524).
  * New upstream version (Closes: #607785):
    - Removed depedency to get-iana.sh and to RESERVED_IPS
      (Closes: #583176, #565737, #574458, #598324, #455754, #536609, #558288),
      thanks to Cristian Ionescu-Idbohrn <email address hidden>
      (#536609), to Adrian Bridgett <email address hidden> (#583176);
    - Updated documentations (Closes: #571727);
    - Improved kernel modules management (Closes: #610249);
    - Simplified quoting in log prefix (Closes: #443051) (LP: #253843);
    - Passive FTP fix (Closes: #563655), thanks to Toni Mueller
      <email address hidden>;
    - Minor improvements and fixes.
  * Update to source format 3.0 (quilt).
  * Bump debhelper build-dep to >= 9.
  * Bump Standards Version to 3.9.4.
  * Rewrite debian/rules:
    - use dh sequencer with minimal external Makefile.
  * Revisit debian/control.
  * Add empty but commented watch file.
  * Correct manpages.
  * Remove RESERVED_IPS as it is no more mandatory, nevertheless
    /usr/share/doc/firehol/examples contains an updated minimal version.
  * Move get-iana.sh to /usr/share/doc/firehol/examples
    as RESERVED_IPS is no more mandatory.
  * Render /etc/init.d/firehol independ from /usr tree.
  * Add `status' option support to /etc/init.d/firehol (LP: #185978).
  * Convert debian/copyright to DEP-5 format.
  * Conform debian/patches/ patches to DEP-3 format.
  * Generate now temporary directory with mktemp (Closes: #496424),
    thanks to Phil Whineray for pointing to it.
  * Now plainly use iproute (Red Hat Bugzilla: #784520),
    thanks to Phil Whineray for hardening the original RedHat patch.
  * Temporary files are now left behind in case of error (Closes: #703341),
    thanks to Phil Whineray who backported the sanewall patch to FireHOL.
  * `panic' option has been rationalized (Closes: #536675),
    thanks to Andrew Schulman and Phil Whineray.
  * Standard patch naming scheme (Closes: #705731), thanks to
    Jari Aalto <email address hidden>.
  * Whitespace cleanup, thanks to Jari Aalto <email address hidden>.

 -- Jerome Benoit <email address hidden> Sat, 20 Apr 2013 07:06:57 +0000

Changed in firehol (Ubuntu):
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers