firefox fails to start on armel

[Oliver Grawert]

on the oneiric beta images for armel it is not possible to start firefox, after starting it it immediately fires up a crash dialog. apparently this has been reported (and worked on) upstream in bug http://bugzilla.mozilla.org/show_bug.cgi?id=675618 already apparently, but the fix has not entered our build. this bug is for tracking the merge of the upstream fix.

[Mh+mozilla (mh+mozilla)]

Thanks to this GNU ld bug: http://sourceware.org/bugzilla/show_bug.cgi?id=13049 , building with a recent GNU ld (>= 2.21.1 are affected for sure, not sure about older ones ; 2.19 is definitely not affected) on ARM leads to a crash.

[Mh+mozilla (mh+mozilla)]

Created attachment 549783
Work around recent ARM GNU ld bug with -fdata-sections and variables names starting with "stub" leading to crash

A workaround is to avoid using variables with a name starting with "stub".

js/src/jsdhash.cpp has the same variable name, but as it is compiled as C++, its name is mangled and thus doesn't start with "stub".

[Respindola (respindola)]

Can we use gold for this?

[Mh+mozilla (mh+mozilla)]

(In reply to comment #2)
> Can we use gold for this?

It's not only a problem for us. It's a problem for those that use GNU ld on ARM.

[Benjamin Smedberg (Mozilla) [:bs] (benjamin-smedbergs)]

Comment on attachment 549783
Work around recent ARM GNU ld bug with -fdata-sections and variables names starting with "stub" leading to crash

Since pldhash is jsdhash, can we just compile it as C++ and move on?

[Mh+mozilla (mh+mozilla)]

Created attachment 551473
Compile pldhash as C++

> Since pldhash is jsdhash, can we just compile it as C++ and move on?

We can.

[Mh+mozilla (mh+mozilla)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/3d20269baeee

[Ehsan-mozilla (ehsan-mozilla)]

http://hg.mozilla.org/mozilla-central/rev/3d20269baeee

[Daniel Holbert (dholbert)]

For the record, this requires a clobber to build successfully, or else you'll get errors like:
> make[8]: *** No rule to make target `pldhash.c', needed by `pldhash.o'. Stop.

(noting here in case any devs / projec-branch-owners encounter this error and do a bugzilla search to see if it's reported anywhere)

[Pedro Villavicencio (pedro)]

Chris may you please look at this ? Thanks.