[UIFe] Please add unity quicklist item for 'new window' and maybe 'new tab'

Bug #741046 reported by Bilal Akhtar
32
This bug affects 5 people
Affects Status Importance Assigned to Milestone
firefox (Ubuntu)
High
Unassigned

Bug Description

Binary package hint: firefox

A Unity static quicklist item that opens up a new window would be nice. This would fire up firefox -new-window.

A proper rationale for this change is explained in comment #5 below. Moreover, according to comments by didrocks on bug #709707, we need to patch up desktop files to make up for the dropped 'Open a new window of this application' feature in Unity. My patch to fix that in Unity was rejected, and hence we had to follow the procedure of adding this feature to only those applications which support multiple instances.

Once we get a UIFe for both the string additions, then we will upload the change for 'Open a New Window', with the 'Open a New Tab' change following soon. Both these changes have been announced to the ubuntu-doc and ubuntu-translators MLs, and the translations for both of these have been set up on https://wiki.ubuntu.com/Translations/Wanted/FirefoxDesktop . Moreover, the translated strings for 3 locales have already been merged with the desktop file in the attached debdiff. The 'Open a New Tab' change later will also incorporate the translations for both the strings done till that point of time.

Announcement on ubuntu-doc ML: https://lists.ubuntu.com/archives/ubuntu-doc/2011-March/015493.html
Announcement on ubuntu-translators ML: https://lists.ubuntu.com/archives/ubuntu-translators/2011-March/004527.html

Changed in firefox (Ubuntu):
assignee: nobody → Bilal Akhtar (bilalakhtar)
importance: Undecided → Wishlist
status: New → In Progress
Revision history for this message
Bilal Akhtar (bilalakhtar) wrote :

This debdiff fixes the bug. Kindly sponsor. Thanks!

Changed in firefox (Ubuntu):
status: In Progress → Triaged
assignee: Bilal Akhtar (bilalakhtar) → nobody
Revision history for this message
Bilal Akhtar (bilalakhtar) wrote :

This is an improved version of the previous debdiff. Changes: Add the quicklist entries on all desktop files, and use @APPNAME@ instead of firefox.

Revision history for this message
Chris Coulson (chrisccoulson) wrote :

Thanks, removing sponsors as changes to Firefox don't go through the usual sponsoring process

Revision history for this message
Bilal Akhtar (bilalakhtar) wrote :

Another debdiff, this one contains the change from Open a new tab -> Open a New Tab (as suggested by David Planella)

tags: added: patch
Revision history for this message
Rick Spencer (rick-rickspencer3) wrote : Re: Please add unity quicklist item for 'new window' and maybe 'new tab'

Here's why New Import is vital to the usabliity of Unity:

1. Work away on your netbook, have one or more browser widnows open
2. decide to navigate to a new workspace to transition to a different task set
3. navigate to the works space
4. open a browser window

Result:
with no middle button, you can't open the window, if you click the browser you end up going back to the old workspace

This happens to me daily, and is infuriating.

This will need a UI Freeze exception, so we should do it asap to avoid impact there
It may also need a FFE

Changed in firefox (Ubuntu):
importance: Wishlist → High
summary: - Please add unity quicklist item for 'new tab'
+ Please add unity quicklist item for 'new window' and maybe 'new tab'
Revision history for this message
Chris Coulson (chrisccoulson) wrote :

Bilal - would you mind updating your current patch to just add "Open a New Window" for now? We talked about it on IRC and I think a new window entry makes more sense right now.

We can still keep the request for "Open a New Tab" translations on https://wiki.ubuntu.com/Translations/Wanted/FirefoxDesktop though, as it will give us the option of adding the extra item at a later date.

Thanks!

Changed in firefox (Ubuntu):
assignee: nobody → Bilal Akhtar (bilalakhtar)
Revision history for this message
Bilal Akhtar (bilalakhtar) wrote :

I feel it would be better to have both 'Open a New Tab' and 'Open a New Window' options in the quicklist. What do you say? If you give me the go-ahead I'll make the change on the debdiff, notify dpm, and follow the UIFe procedure.

Revision history for this message
Bilal Akhtar (bilalakhtar) wrote :

This is the new debdiff. I am following the UIFe procedure now.

description: updated
description: updated
summary: - Please add unity quicklist item for 'new window' and maybe 'new tab'
+ [UIFe] Please add unity quicklist item for 'new window' and maybe 'new
+ tab'
description: updated
description: updated
description: updated
Revision history for this message
Martin Pitt (pitti) wrote :

This is harmless enough, so UIFe approved.

However, I wonder if there is any way that these strings could be in a package which already uses gettext, or whether we could add PO files to firefox for translating this?

Revision history for this message
Bilal Akhtar (bilalakhtar) wrote :

Hi Martin,

Thanks for the UIFe approval!

The answer to your question is on https://wiki.ubuntu.com/Translations/Wanted/FirefoxDesktop . Mozilla packages don't use gettext, and hence its difficult to merge translations for desktop files. Hence, we have to do it manually.

Revision history for this message
Chris Coulson (chrisccoulson) wrote :

Martin,

We can discuss that at UDS when we figure out the right way to do FIrefox translations :)

Revision history for this message
Chris Coulson (chrisccoulson) wrote :

bzr commit -m '* Add some missing symlinks in the SDK
  - update debian/firefox-dev.links.in
* Add Hebrew, Slovene, Bengali and updated Catalan translations, plus
  add static quicklist translations for French and Russian
* debian/firefox-*.desktop.in: Add static quicklist item 'Open a New
  Window'. (LP: #741046)' --fixes 'lp:741046'
Committing to: /home/chr1s/src/firefox/4.0/
modified debian/changelog
modified debian/firefox-beta.desktop.in
modified debian/firefox-dev.links.in
modified debian/firefox-final.desktop.in
modified debian/firefox-nightly.desktop.in
modified debian/firefox-unofficial.desktop.in
Committed revision 823.

Changed in firefox (Ubuntu):
assignee: Bilal Akhtar (bilalakhtar) → nobody
status: Triaged → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package firefox - 4.0~rc2+build3+nobinonly-0ubuntu2

---------------
firefox (4.0~rc2+build3+nobinonly-0ubuntu2) natty; urgency=low

  [ Chris Coulson <email address hidden> ]
  * Ship a mozilla-plugin.pc and libxul.pc rather than our custom
    firefox-plugin.pc. No other source packages are aware of firefox-plugin
    and this way avoids patching a whole bunch of apps. We now conflict
    with the xulrunner SDK though
    - rename debian/pkgconfig/firefox-plugin.pc.in =>
       debian/pkgconfig/mozilla-plugin.pc.in
    - update debian/pkgconfig/mozilla-plugin.pc.in
    - add debian/pkgconfig/libxul.pc.in
    - add debian/pkgconfig/mozilla-nspr.pc.in
    - update debian/rules
    - update debian/control.pp
  * Add some missing symlinks in the SDK
    - update debian/firefox-dev.links.in
  * Add Asturian, Bengali, Croatian, Danish, Galician, Hebrew, Kurdish,
    Lithuanian, Romanian, Slovene, Uyghur and Ukrainian, and updated
    Catalan and French translations, plus add static quicklist translations
    for Chinese, Dutch, French, Hungarian, Italian and Russian
    - update debian/firefox-*.desktop.in
  * Update globalmenu-extension code to 0.6.1. Pressing Alt shows the menu
    now

  [ Bilal Akhtar <email address hidden> ]
  * debian/firefox-*.desktop.in: Add static quicklist item 'Open a New
    Window'. (LP: #741046)
 -- Chris Coulson <email address hidden> Thu, 31 Mar 2011 17:54:51 +0100

Changed in firefox (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Bilal Akhtar (bilalakhtar) wrote :

I guess its time to add a quicklist item for 'Open a New Tab' as well?

Its already up for translations, and many many translators have already translated both those strings. Thoughts?

Revision history for this message
Mar-castelluccio (mar-castelluccio) wrote :

I don't see the quicklist in Oneiric, maybe because I've updated from Natty?

Revision history for this message
Michael Hall (mhall119) wrote :

It's not in Precise either.

Changed in firefox (Ubuntu):
assignee: nobody → Nekhelesh Ramananthan (nik90)
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

It has been requested to include a quicklist option to "Open a new Tab". However I think this is redundant since you can do this from File->New Tab and also from the new tab button present always. Hence I suggest the following quicklist for firefox.

Open a new window
Open firefox in Safe Mode
Switch between Private/Normal mode
--------------------------------------------------------
Firefox Web Browser
--------------------------------------------------------
Unlock from Launcher
Quit

Revision history for this message
Micah Gersten (micahg) wrote :

Please file a new bug rather than commenting on an already fixed one.

Revision history for this message
Chris Coulson (chrisccoulson) wrote :

Or not. We don't want a new-tab entry :)

Changed in firefox (Ubuntu):
assignee: Nekhelesh Ramananthan (nik90) → nobody
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers