Comment 15 for bug 481541

Revision history for this message
In , Jcginn (jcginn) wrote :

Ok guys, I have always wanted the prefs to stay in the options window. With that
said, IF this patch lands (or something similar), than the current wording of
the options clearly become even more problematic. When a user can’t even figure
out what the options mean in the first place, then there is no point for the
options to be there. If the devs approve new strings, than I am more than happy
to withdraw my suggestion. Otherwise, I don’t think leaving in the strings as
they are is a good idea -> they are too confusing. When the localization freeze
ends, the strings can be corrected and the options added back.

(In reply to comment #14)
> Why add another pref? Just keep the existing one for left-click links, and add
> new meanings to browser.link.external (IIRC). The way I did it with the
> equivalent TBP pref, extensions.tabprefs.externalLinkTarget, was:
>
> 0 - New window.
> 1 - New tab in current (recent) window, focused.
> 2 - Current tab in current (recent) window.
> 3 - New tab in current (recent) window, unfocused.

Easily done. If browser.link.open_newwindow and browser.link.open_external = 3
open tab in focus = 4 open tab in background. Also, I was thinking of TBP when I
asked for an extension to step up.