Incorrect .desktop files

Bug #194970 reported by Saivann Carignan on 2008-02-24
14
Affects Status Importance Assigned to Milestone
firefox (Ubuntu)
Low
Alexander Sack
firefox-3.0 (Ubuntu)
Medium
Fabien Tassin
lightning-sunbird (Ubuntu)
Low
Saivann Carignan
thunderbird (Ubuntu)
Low
Alexander Sack

Bug Description

Binary package hint: firefox

Actual desktop files in the hardy package does not comply with the specification according to desktop-file-validate.

A side effect of this problem is that Firefox icon does not appear on the Desktop (because of the .png in the icon name). Tested Debdiff that fixes this problem is attached.

Saivann Carignan (oxmosys) wrote :
Changed in firefox:
assignee: nobody → saivann
importance: Undecided → Medium
status: New → Triaged
Saivann Carignan (oxmosys) wrote :

I forgot the (LP: #194970) line in the changelog. Here's the good debdiff.

Saivann Carignan (oxmosys) wrote :
Changed in mozilla-thunderbird:
assignee: nobody → saivann
importance: Undecided → Medium
status: New → Triaged
Saivann Carignan (oxmosys) wrote :

This bug also affect Thunderbird.

Saivann Carignan (oxmosys) wrote :
Alexander Sack (asac) wrote :

milestoning. Thanks.

Changed in mozilla-thunderbird:
milestone: none → ubuntu-8.04-beta
Changed in firefox:
milestone: none → ubuntu-8.04-beta
Saivann Carignan (oxmosys) wrote :

Also affect sunbird

Changed in lightning-sunbird:
importance: Undecided → Medium
status: New → Triaged
assignee: nobody → saivann
Saivann Carignan (oxmosys) wrote :
Changed in lightning-sunbird:
milestone: none → ubuntu-8.04-beta

I looked at the final desktop file for Firefox here and I noticed that the translations got dropped ( https://bugs.launchpad.net/ubuntu/+source/firefox-3.0/+bug/196953 ). Is that true?

Alexander Sack (asac) wrote :

didn't made the beta train. pushing milestone ahead

Changed in firefox:
milestone: ubuntu-8.04-beta → ubuntu-8.04
Changed in lightning-sunbird:
milestone: ubuntu-8.04-beta → ubuntu-8.04
Changed in mozilla-thunderbird:
milestone: ubuntu-8.04-beta → ubuntu-8.04
Alexander Sack (asac) wrote :

fta, would you mind to take this to firefox-3.0.head?

Changed in firefox-3.0:
status: New → Confirmed
assignee: nobody → fta
milestone: none → ubuntu-8.04
importance: Undecided → Medium
Fabien Tassin (fta) wrote :

asac, already done while doing #195013

Changed in firefox-3.0:
status: Confirmed → Fix Committed
Launchpad Janitor (janitor) wrote :
Download full text (4.1 KiB)

This bug was fixed in the package firefox-3.0 - 3.0~b5+nobinonly-0ubuntu1

---------------
firefox-3.0 (3.0~b5+nobinonly-0ubuntu1) hardy; urgency=low

  * Firefox 3.0 Beta 5 package - "ready for prime-time"!

  * Multiple fixes and improvements to debian/rules: "rewrite substitution
    rules", "bad .autoreg install path makes package ftbfs", "Firefox must not
    ship reporter extension; its shipped in xulrunner-1.9", "enable
    mozilla-devscript's in binary-post-install", "--disable-debug passed twice
    in configure"
    - update debian/rules

       * Alexander Sack <email address hidden>
       * Fabien Tassin <email address hidden>

  * Multiple fixes to the apport hook: "remove .pyc file garbage during prerm",
    "bad install path", "bad extension directories used to gather data"
    - update debian/apport/firefox-3.0.py
    - update debian/firefox-3.0.prerm
    - update debian/firefox-3.0.install

       * Alexander Sack <email address hidden>
       * Fabien Tassin <email address hidden>

  * Multiple fixes required by libxul linkage with jemalloc: "libjemalloc.so
    cannot be installed - doesn't exist", "-Wl,-Bsymbolic-functions in LDFLAGS
    cause crashes at startup"
    - update debian/firefox-3.0.install
    - update debian/rules

       * Fabien Tassin <email address hidden>

  * Fix multiple misc bugs: "migration creates double dots for abandoned
    profiles", "Wikipedia search plugin shipped upstream", "blocklist.xml not
    installed", "use LIBDIR when touching .autoreg in postinst", "Fix restart
    notification misbehaviour", "Improve package description (LP: #207199)"
    - update debian/firefox.sh.in
    - drop debian/wikipedia.*
    - update debian/firefox-3.0.install
    - update debian/rules
    - update debian/firefox-3.0.postinst.in
    - update debian/firefox-3.0-restart-required.update-notifier

       * Alexander Sack <email address hidden>
       * Fabien Tassin <email address hidden>

  * Misc package housekeeping changes: "Bump xulrunner-1.9
    dependencies to b5", "Adjust patches", "desktop files not valid
    (LP: #194970)", "relax dependencies on xulrunner. no upper bounds":
    - update debian/control
    - update debian/patches/dont_depend_on_nspr_sources.patch
    - update debian/patches/nspr_flags_by_pkg_config_hack.patch

       * Fabien Tassin <email address hidden>

  * Multiple Translation related fixes and improvements: "Reuse translations
    from firefox 2 .desktop file", "include lp-export-xpi.mk from
    mozilla-devscripts and export en-US.xpi to debian/lp-export-xpis/
    directory"
    - update debian/firefox-final.desktop
    - update debian/rules
    - update debian/control

       * Alexander Sack <email address hidden>
       * Fabien Tassin <email address hidden>

  * Fixing chrome registration issues by properly shipping
    $(DEBIAN_FF3_DIR)/.autoreg and touching it in postinst maintainer scripts
    - update debian/rules
    - update debian/firefox-3.0.postinst.in
    - add debian/firefox-3.0-gnome-support.postinst

       * Alexander Sack <email address hidden>
       * Fabien Tassin <email address hidden>

  * fix LP: #185622 - "Firefox 3 doesn't act as the default browser"; we
    always check for and use /usr/bin/firef...

Read more...

Changed in firefox-3.0:
status: Fix Committed → Fix Released
John Vivirito (gnomefreak) wrote :

this is fixed in our pre build so far for sunbird 0.8 it will be fixed when we ship it in Intrepid and possibly backport it for Hardy.

Steve Langasek (vorlon) wrote :

The impact of this bug is said to be "[the] Firefox icon does not appear on the Desktop (because of the .png in the icon name)". I've just tested adding a thunderbird launcher to my GNOME desktop, though, and that works fine here?

Changed in mozilla-thunderbird:
milestone: ubuntu-8.04 → none
Saivann Carignan (oxmosys) wrote :

You're right, this effect is not reproducible anymore but it was the case with previous Hardy alpha release. Lowering priority to low and dropping milestones.

Changed in mozilla-thunderbird:
importance: Medium → Low
Changed in lightning-sunbird:
importance: Medium → Low
milestone: ubuntu-8.04 → none
Changed in firefox:
importance: Medium → Low
milestone: ubuntu-8.04 → none
John Vivirito (gnomefreak) wrote :

This has been fixed most likely in 0.7 my 0.8 already has that fixed.

Changed in lightning-sunbird:
status: Triaged → Fix Released
Changed in firefox:
assignee: saivann → nobody
Changed in mozilla-thunderbird:
assignee: saivann → nobody
Alexander Sack (asac) wrote :

ok, will review and apply for firefox 2

Changed in firefox:
assignee: nobody → asac
status: Triaged → In Progress
Alexander Sack (asac) wrote :

dito for tbird

Changed in mozilla-thunderbird:
assignee: nobody → asac
status: Triaged → In Progress
Alexander Sack (asac) wrote :

do we care enough to land this in stable releases or is intrepid enough? Saivann?

Alexander Sack (asac) wrote :

Saivann, maybe consider to propose your branches for merging to the branches you feel they should end up in.

Saivann Carignan (oxmosys) wrote :

Alexander Sack : No, you can drop any nomination for 8.04. This was a more serious problem during Hardy alpha because it caused the icons to disappears. This problem does not appears since hardy beta. Intrepid is enough IMO.

Alexander Sack (asac) wrote :
Changed in mozilla-thunderbird:
status: In Progress → Fix Committed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package thunderbird - 2.0.0.18+nobinonly-0ubuntu1

---------------
thunderbird (2.0.0.18+nobinonly-0ubuntu1) jaunty; urgency=low

  * security/stability update 2.0.0.18 (USN-668-1)
  * fix LP: #302388: add arm(el) xpcom patches from icedove package
    - add debian/patches/18_arm_xpcom_unused_attribute.dpatch
    - add debian/patches/38_arm_xpcom_optim.dpatch
    - update debian/patches/series
  * rerun autoconf2.13 to adjust configure patch
    - update debian/patches/autoconf-regen

  [ Saïvann Carignan <email address hidden> ]
  * Fix LP: #194970, LP: #190688 - desktop-file-validate warnings: among others
    we update Icon field to not use a file extension
    - update debian/thunderbird.desktop

 -- Alexander Sack <email address hidden> Wed, 26 Nov 2008 12:18:33 +0100

Changed in thunderbird:
status: Fix Committed → Fix Released
John Vivirito (gnomefreak) wrote :

Closing firefox task as it is no longer supported

Changed in firefox:
status: In Progress → Invalid
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers