Unnecessary patch to cleanup old distributions

Bug #1885903 reported by Standard8 on 2020-07-01
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
firefox (Ubuntu)
Medium
Rico Tzschichholz

Bug Description

When we raised bug #1885006 we stated that the `cleanup-old-distribution-search-engines.patch` is no longer necessary, as this has been fixed in other ways, namely:

https://bugzilla.mozilla.org/show_bug.cgi?id=1623597

Unfortunately this was not addressed by #1885006.

The patch is no longer necessary - since that bug landed in 76 we have been correctly marking distribution engines as app provided, and distribution engines previously not marked as app provided will have been corrected.

If you feel it is still necessary, please explain why. If there are still bugs existing in relation to it, please let us know so we can fix the search service properly.

Olivier Tilloy (osomon) wrote :

Thank you Mark for filing this bug to follow up on bug #1885006.

Dropping cleanup-old-distribution-search-engines.patch sounds reasonable to me (the description of the patch even explicitly says it can be dropped at some point in the future), and doing that early in the 79 beta cycle is best.

description: updated
Olivier Tilloy (osomon) wrote :

The patch was dropped in the firefox-beta branches used to build beta packages.

Changed in firefox (Ubuntu):
status: New → Fix Committed
assignee: nobody → Rico Tzschichholz (ricotz)
importance: Undecided → Medium
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package firefox - 79.0+build1-0ubuntu0.20.04.1

---------------
firefox (79.0+build1-0ubuntu0.20.04.1) focal; urgency=medium

  * New upstream stable release (79.0+build1)

  [ Olivier Tilloy ]
  * Remove obsolete search plugins and related patches and default settings.
    These were added to upstream's Ubuntu distribution configuration
    (https://bugzilla.mozilla.org/show_bug.cgi?id=1651330).
    - debian/install-distribution-searchplugins.py
    - debian/searchplugins/*.xml
    - debian/config/searchplugins.conf
    - debian/patches/no-region-overrides-for-google-search.patch
    - debian/patches/partially-revert-google-search-update.patch
  * Update packaging scripts accordingly
    - debian/distribution.ini
    - debian/firefox.{dirs,install,links}.in
    - debian/rules
  * Add a new autopkgtest that verifies that search engine customizations are
    applied
    - debian/tests/control
    - debian/tests/search-engines

  [ Rico Tzschichholz ]
  * Require python >= 3.6
    - debian/control{,.in}
  * Update patches
    - debian/patches/fix-armhf-webrtc-build.patch
  * Bump build-dep on rustc >= 1.43.0 and cargo >= 0.44
    - debian/control{,.in}
  * Drop unnecessary patch to cleanup old distributions (LP: #1885903)
    - debian/patches/cleanup-old-distribution-search-engines.patch

 -- Olivier Tilloy <email address hidden> Mon, 27 Jul 2020 18:08:25 +0200

Changed in firefox (Ubuntu):
status: Fix Committed → Fix Released
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package firefox - 79.0+build1-0ubuntu0.18.04.1

---------------
firefox (79.0+build1-0ubuntu0.18.04.1) bionic; urgency=medium

  * New upstream stable release (79.0+build1)

  [ Olivier Tilloy ]
  * Remove obsolete search plugins and related patches and default settings.
    These were added to upstream's Ubuntu distribution configuration
    (https://bugzilla.mozilla.org/show_bug.cgi?id=1651330).
    - debian/install-distribution-searchplugins.py
    - debian/searchplugins/*.xml
    - debian/config/searchplugins.conf
    - debian/patches/no-region-overrides-for-google-search.patch
    - debian/patches/partially-revert-google-search-update.patch
  * Update packaging scripts accordingly
    - debian/distribution.ini
    - debian/firefox.{dirs,install,links}.in
    - debian/rules
  * Add a new autopkgtest that verifies that search engine customizations are
    applied
    - debian/tests/control
    - debian/tests/search-engines

  [ Rico Tzschichholz ]
  * Require python >= 3.6
    - debian/control{,.in}
  * Update patches
    - debian/patches/fix-armhf-webrtc-build.patch
    - debian/patches/unity-menubar.patch
  * Bump build-dep on rustc >= 1.43.0 and cargo >= 0.44
    - debian/control{,.in}
  * Drop unnecessary patch to cleanup old distributions (LP: #1885903)
    - debian/patches/cleanup-old-distribution-search-engines.patch

 -- Olivier Tilloy <email address hidden> Mon, 27 Jul 2020 17:46:24 +0200

Changed in firefox (Ubuntu):
status: Fix Committed → Fix Released
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package firefox - 79.0+build1-0ubuntu0.16.04.2

---------------
firefox (79.0+build1-0ubuntu0.16.04.2) xenial; urgency=medium

  * Fix new autopkgtest's shebang so that it works in the virtualenv wrapper
    - debian/tests/search-engines

 -- Olivier Tilloy <email address hidden> Mon, 27 Jul 2020 17:36:40 +0200

Changed in firefox (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.