Comment 157 for bug 1160569

Revision history for this message
In , Mh+mozilla (mh+mozilla) wrote :

(In reply to Karl Tomlinson (ni?:karlt back June 30) from comment #112)
> I had intentionally chosen not to override an existing G_SLICE environment
> variable so that this could be overridden or debug-blocks could be used if
> desired. That's not a show-stopper, but avoiding overriding would avoid
> having to copy the old value to restore.

I guess that would work just as much. I was worried that some systems might have G_SLICE set for some wrong reasons. I don't have a strong opinion anyways.

> I don't know why you are preferring setenv over putenv here.
> I had chosen putenv to avoid the leak.

I chose setenv to avoid having both "G_SLICE" and "G_SLICE=always-malloc" as .rodata.