get-orig-source should target the 'default' (hg) branch instead of 'tip'

Bug #454166 reported by Fabien Tassin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
firefox-3.5 (Ubuntu)
Fix Released
Medium
Fabien Tassin
xulrunner-1.9.1 (Ubuntu)
Fix Released
Medium
Fabien Tassin

Bug Description

Binary package hint: firefox-3.5

By default, get-orig-source gets the tip of the upstream hg tree. This is bad as is catches tags and sub-branches.
It should target the 'defaut' branch.

Revision history for this message
In , Alexander Sack (asac) wrote :

Created an attachment (id=405845)
catch GetTarget exception

Revision history for this message
In , Mh+mozilla (mh+mozilla) wrote :

You don't assign oldValue, this ain't gonna work ;)

Revision history for this message
In , Alexander Sack (asac) wrote :

Created an attachment (id=405846)
oops

Revision history for this message
In , Dtownsend (dtownsend) wrote :

(From update of attachment 405846)
GetTarget only throws when it is passed invalid arguments. We should fix the caller to not do that instead.

Revision history for this message
In , Alexander Sack (asac) wrote :

(In reply to comment #4)
> (From update of attachment 405846 [details])
> GetTarget only throws when it is passed invalid arguments. We should fix the
> caller to not do that instead.

invalid in what way? I always thought that GetTarget also throws if "source" resource does not exist for example.

Revision history for this message
In , Dtownsend (dtownsend) wrote :

GetTarget only throws if source or property are null, however the error message you're getting isn't from GetTarget throwing, it is xpconnect throwing because source or property are not null or JS objects that it can pretend are nsIRDFResources.

Revision history for this message
In , Mozilla-bugs-micahscomputing (mozilla-bugs-micahscomputing) wrote :
Revision history for this message
Fabien Tassin (fta) wrote : get-orig-source should target the 'default' (hg) branch, which is not always 'tip'

Binary package hint: firefox-3.5

By default, get-orig-source gets the tip of the upstream hg tree. This is bad as is catches tags and sub-branches.
It should target the 'defaut' branch.

Changed in firefox-3.5 (Ubuntu):
assignee: nobody → Fabien Tassin (fta)
importance: Undecided → High
status: New → In Progress
Fabien Tassin (fta)
Changed in xulrunner-1.9.1 (Ubuntu):
status: New → In Progress
importance: Undecided → High
assignee: nobody → Fabien Tassin (fta)
Fabien Tassin (fta)
summary: - get-orig-source should target the 'default' (hg) branch, which is not
- always 'tip'
+ get-orig-source should target the 'default' (hg) branch instead of 'tip'
Fabien Tassin (fta)
Changed in firefox-3.5 (Ubuntu):
status: In Progress → Fix Committed
Changed in xulrunner-1.9.1 (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
In , Alexander Sack (asac) wrote :

Created an attachment (id=407108)
fix type of newVersion property...

ok newVersion was just a string while setItemProperty/setProperty requires a nsIRDFResource ... this patch fixes it by using EM_R("newVersion")

That said I noticed that setItemProperty assumes a nsIRDFResource as "property", while getItemProperty seems to EM_R "property" all the time. Might be worth looking into making the behaviour more consistent.

Revision history for this message
Alexander Sack (asac) wrote :

this is relevant for daily builds only - lets lower importance to medium as we usually track archive issues here.

Changed in firefox-3.5 (Ubuntu):
importance: High → Medium
Changed in xulrunner-1.9.1 (Ubuntu):
importance: High → Medium
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package firefox-3.5 - 3.5.3+build1+nobinonly-0ubuntu6

---------------
firefox-3.5 (3.5.3+build1+nobinonly-0ubuntu6) karmic; urgency=low

  [ Fabien Tassin <email address hidden> ]
  * fix LP: #454166 - target the 'default' branch instead of tip
    - add debian/moz-rev.sh
    - update debian/mozclient/firefox-3.5.conf

  [ Alexander Sack <email address hidden> ]
  * fix LP: #455504 - abrowser does not run from Applications Menu;
    create the unversioned link in debian/rules like we do for the
    firefox name
    - update debian/rules
  * fix LP: #455517 - supersede firefox 3.0 and xulrunner-1.9 in karmic;
    add transitional packages and add Conflicts/Replaces/Provides
    accordingly.
    - update debian/control
  * fix LP: #396156 - Help→About does not function (abrowser-3.5,
    jaunty-proposed); we prepatch the required changes to
    browser/branding/awesome-browser/ tree taken from the 3.5 branding
    branch: lp:~mozillateam/firefox/awesome-browser-branding-3.5
    - add debian/patches/lp396156_prepatch_abrowser_branding.patch
    - update debian/patches/series

 -- Alexander Sack <email address hidden> Tue, 20 Oct 2009 10:42:56 +0200

Changed in firefox-3.5 (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package xulrunner-1.9.1 - 1.9.1.3+build1+nobinonly-0ubuntu6

---------------
xulrunner-1.9.1 (1.9.1.3+build1+nobinonly-0ubuntu6) karmic; urgency=low

  [ Fabien Tassin <email address hidden> ]
  * fix LP: #454166 - target the 'default' branch instead of tip;
    this just affects daily builds from this branch
    - add debian/moz-rev.sh
    - update debian/mozclient/xulrunner-1.9.1.conf

  [ Alexander Sack <email address hidden> ]
  * fix LP: #441552 - [MASTER] Firefox 3.5 prompting to restart without
    installing new addons; basically on upgrade if firefox does not find
    an reference to a previously known extension location in the new created
    extension rdf, the extension manager will fail leading to a bad startup
    sequence, basically leaving users in a instable state as no extension
    upgrades etc. will finish/work properly. The fix takes latest upstream
    patch (attach 407108) from https://bugzilla.mozilla.org/show_bug.cgi?id=521780
    - add debian/patches/lp441552_bz521780_att407108.patch
    - update debian/patches/series

 -- Alexander Sack <email address hidden> Tue, 20 Oct 2009 12:08:40 +0200

Changed in xulrunner-1.9.1 (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
In , Reed Loden (reed) wrote :
Revision history for this message
In , Reed Loden (reed) wrote :

(From update of attachment 407108)
Ubuntu is already using this patch on their 1.9.1 branch, so would like to get this backported.

Revision history for this message
In , Beltzner (beltzner) wrote :

(From update of attachment 407108)
a192=beltzner

Revision history for this message
In , Mak77 (mak77) wrote :
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.