Firefox needs to use "gtk_image_menu_item_set_always_show_image" for essential icons.

[Vish]

Icons are not displayed by default in either context menus, dialogue buttons or firefox bookmarks menu

Upstream is setting these two options to false by default.
http://bugzilla.gnome.org/show_bug.cgi?id=557469
http://bugzilla.gnome.org/show_bug.cgi?id=583352

To ensure that *essential* icons are displayed, relevant applications must be patched.

Design Suggestion:
Meanwhile, now that we have flicked the switch and set icons to be off by default, we need to fix relevant applications to match. You can help! Whenever you see a program that has menu items for objects where those menu items now don't include icons, report a bug on the program that it should use always-show-icons for those particular items. And conversely, whenever you see a program with icons on menu items for things that aren't objects, report a bug that the icons should be removed.

Examples of menu items that count as objects, and should therefore have icons: applications, documents (including any recent documents in a "File" menu), disks, partitions, folders, bookmarks, history items, IM accounts, IM statuses, user accounts.

Examples of menu items that don't count as objects, and should therefore *not* have icons: openable windows (e.g. "Edit" > "Preferences" or "Go" > "Edit Bookmarks"), toolbars (e.g. "View" > "Toolbars" > anything), actions (e.g. "Go" > "Back").

Unlike menus in Windows, whether a menu item has an equivalent toolbar button is irrelevant to whether the menu item should have an icon.
----------------

Please use this bug report only for Firefox, and report missing menu icons in other applications as separate bugs. Otherwise anyone who fixes the bug in one package will be punished by being spammed about changes in packages they have no interest in. Use a common tag ("menu-icons") for bug reports on this issue.

For further details on the related discussions and design suggestions see Bug #407621

[Ventnor-bugzilla (ventnor-bugzilla)]

So what's the problem? You're saying that bookmark menu items should always have an icon?

[Ventnor-bugzilla (ventnor-bugzilla)]

And if that's the case, should folders/smart folders that are submenus also show icons?

This really seems like an odd inconsistency from the GNOME folks, almost like a begrudging admission that icons do actually work ;-)

[Michael-monreal+moz (michael-monreal+moz)]

Well, not talking about my own preferences or feelings regarding this change here... :)

But the GNOME HIG explictly mentions¹ this case: "Show icons for bookmark entries on the Bookmarks menu that indicate the type of the bookmark, even if the user has globally turned off icons for other menu items on the desktop."

As I read this, smart bookmarks should indicate that they are smart bookmarks. I don't think "smart" folders are covered by this.

[1] http://www.gnome.org/~calum/hig-devel/menus-standard.html#menu-standard-bookmarks

[Ventnor-bugzilla (ventnor-bugzilla)]

Created attachment 388841
Patch

This has buckley's chance of making 3.5 (though you can try and request it, I guess), and if the schedule plans did change as proposed in the last meeting, then we only have 1 week for it to be certain of making 3.6.

[Dao (dao)]

Comment on attachment 388841
Patch

Can you put this in browser/base/content/browser.css with %ifdef MOZ_WIDGET_GTK2? That would be consistent with xul.css.

[Ventnor-bugzilla (ventnor-bugzilla)]

Created attachment 388881
Patch

Sure.

[Michael-monreal+moz (michael-monreal+moz)]

(In reply to comment #4)
> This has buckley's chance of making 3.5 (though you can try and request it, I
> guess), and if the schedule plans did change as proposed in the last meeting,
> then we only have 1 week for it to be certain of making 3.6.

When is 3.6 due out then? GNOME 2.28 is set for a Sep 23 release and Ubuntu will have a release shortly after that.

[Ventnor-bugzilla (ventnor-bugzilla)]

Assuming they are planning to quickly stabilize 1.9.2 in order to ship Fennec 1.0 on it (it's not 100% confirmed), the plan is to ship 3.6 "this fall" according to recent meeting notes.

[Michael-monreal+moz (michael-monreal+moz)]

Ok... "this fall" sounds like Fedora 12 would ship it (or some RC, as they did with 3.5) but Ubuntu will probably not. Probably worth asking distributions to ship the patch with 3.5 (if they ship GNOME 2.28).

[Dao (dao)]

http://hg.mozilla.org/mozilla-central/rev/c1840493c832

[Beltzner (beltzner)]

Comment on attachment 388881
Patch

a1912=beltzner

[Dao (dao)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/0592119e3de1

[Ashughes (ashughes)]

Is there a way QA can verify this on Firefox 3.5.2 without GNOME 2.28? Do we have to wait until Ubuntu/Fedora become updated?

[Michael-monreal+moz (michael-monreal+moz)]

Sure, set /desktop/gnome/interface/menus_have_icon to false in gconf or untick the checkbox in Preferences->Appearance->Interface

[Ashughes (ashughes)]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2

Our menus look the same whether OS Preferences->Appearance->Interface->"Show icons in menus" is enabled or disabled.

Is this expected behaviour?

[Michael-monreal+moz (michael-monreal+moz)]

Surely not... I think it works for me, though. Using Fx 3.5.1 and the code from the patch in userChrome.css... have you tested if menu icons disappear from other GTK apps?

[Ashughes (ashughes)]

I can see the icons disappear from other menus (Applications, Places, System). In Firefox 3.5.2 they look the same (no matter the pref setting).

[Dao (dao)]

You probably need to restart Firefox (which is suboptimal and might be a bug on its own).

[Ashughes (ashughes)]

Created attachment 391988
Screenshot

Here is a screenshot of what I am seeing. Notice the icon for Organize Bookmarks is removed when the pref is disabled. All other icons that were there before are present. Is this expected?

[Dao (dao)]

Yes.

[Ashughes (ashughes)]

Excellent. Based on that, verified1.9.1.

[Vish (vish)]

Icons are not displayed be default in either context menus, dialogue buttons or firefox bookmarks menu

Upstream is setting these two options to false by default.
http://bugzilla.gnome.org/show_bug.cgi?id=557469
http://bugzilla.gnome.org/show_bug.cgi?id=583352

To ensure that *essential* icons are displayed, relevant applications are to be patched.

Design Suggestion:
Meanwhile, now that we have flicked the switch and set icons to be off by default, we need to fix relevant applications to match. You can help! Whenever you see a program that has menu items for objects where those menu items now don't include icons, report a bug on the program that it should use always-show-icons for those particular items. And conversely, whenever you see a program with icons on menu items for things that aren't objects, report a bug that the icons should be removed.

Examples of menu items that count as objects, and should therefore have icons: applications, documents (including any recent documents in a "File" menu), disks, partitions, folders, bookmarks, history items, IM accounts, IM statuses, user accounts.

Examples of menu items that don't count as objects, and should therefore *not* have icons: openable windows (e.g. "Edit" > "Preferences" or "Go" > "Edit Bookmarks"), toolbars (e.g. "View" > "Toolbars" > anything), actions (e.g. "Go" > "Back").

Unlike menus in Windows, whether a menu item has an equivalent toolbar button is irrelevant to whether the menu item should have an icon.
----------------

Kindly identify the applications that need icons and report it here, add them by using "Also affects project".

[Andreas Nilsson (andreasn)]

Totem:
The recently opened documents under Movie

Tomboy:
The notes that comes up when pressing the capplet. (not Create Note, Notebooks, Search All Notes)

gedit:
The recently opened documents under File

GIMP:
The files under File > Open Recent

Abiword:
The recently opened documents under File
The files under Documents

Gwibber:
the active accounts under the "Accounts", perhaps those under Create as well?

[Marcus Carlson (0-launchpad-mejlamej-nu)]

See http://bugzilla.gnome.org/show_bug.cgi?id=546916 or https://bugs.launchpad.net/hundredpapercuts/+bug/387796 for a patch to show applications icons in the open with list in nautilus

[Matthew Paul Thomas (mpt)]

Please use this bug report only for Firefox, and report missing menu icons in other applications as separate bugs. Otherwise anyone who fixes the bug in one package will be punished by being spammed about changes in packages they have no interest in. Perhaps you could use a common tag ("menu-icons"?) for bug reports on this issue.

[Vish (vish)]

Nautilus has a new bug report > https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/408384

[Andreas Nilsson (andreasn)]

Created attachment 392287
quicksearch and tab dropdown

Seems this also affects the favicons for the quick search box dropdown and tabs dropdown (that both should have icons according to the new guidelines). Should that be filed as a separate bug?

[Dao (dao)]

(In reply to comment #22)
> Should that be filed as a separate bug?

Yes.

[Micah Gersten (micahg)]

This is fixed in Firefox 3.5.2 which will be released to Ubuntu in the next few days.

[Andreas Nilsson (andreasn)]

Created an attachment (id=392453)
screenshot

Related to bug 504275, GNOME recently set menus_have_icons to false by default. [1] What this means is that menus will no longer show icons.
However, bookmarks (and favicons) are exceptions that should use icons according to the guidelines [2] and those can be set to "always-show-icons" property (GtkImageMenuItem).

This also affects the tab dropdown, but I'll file another bug about that.

1. http://bugzilla.gnome.org/show_bug.cgi?id=557469
2. http://bugzilla.gnome.org/show_bug.cgi?id=588668

[Andreas Nilsson (andreasn)]

Filed those as Bug 508221 and Bug 508223

[Micah Gersten (micahg)]

This was released in Karmic -- Firefox 3.5.2

[Martin McNickle (mmcnicklebugs)]

Created an attachment (id=397040)
patch

Adds the search icons again.

[Martin McNickle (mmcnicklebugs)]

Created an attachment (id=397085)
combined rules

[Daniel Ribeiro (danielrmt)]

Using Firefox 3.5.2 in karmic. It displays correctly bookmarks and history icons, but I still think the search engines menu (see attachment) should display the icons.

[Matthew Paul Thomas (mpt)]

Daniel, yes, that would be appropriate. You could report a bug in bugzilla.mozilla.org that the search engines menu should always have icons, because -- like bookmarks and history items -- the search engines are objects that can be added to or removed from the menu.

[Daniel Ribeiro (danielrmt)]

Someone already reported it: https://bugzilla.mozilla.org/show_bug.cgi?id=508221

[Hskupin (hskupin)]

Martin, you should ask a specific person for review. Dao could be the right one.

[Dao (dao)]

I think this belongs in searchbarBindings.css, since the menuitems are anonymous...

[Gavin Sharp (gavin-sharp)]

I don't really have a strong opinion. Assuming it works, that patch seems fine to me.

[Dao (dao)]

http://hg.mozilla.org/mozilla-central/rev/c08baee44cf4

[Hskupin (hskupin)]

Verified fixed with Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a1pre) Gecko/20091009 Minefield/3.7a1pre ID:20091009030724

[Hskupin (hskupin)]

*** Bug 525714 has been marked as a duplicate of this bug. ***

[Hskupin (hskupin)]

It will probably not block, but bringing attention to drivers so we could get at least an approval for 1.9.2.

[Beltzner (beltzner)]

Henrik; the better way to bring it to drivers' attention is to email me a list of bugs that you think are safe for approval, along with quick rationale.

[Dao (dao)]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/4637996a8752

[Hskupin (hskupin)]

Verified fixed on 1.9.2 with Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2b3pre) Gecko/20091111 Namoroka/3.6b3pre ID:20091111033750

[Hskupin (hskupin)]

*** Bug 531370 has been marked as a duplicate of this bug. ***

[Hskupin (hskupin)]

*** Bug 534230 has been marked as a duplicate of this bug. ***

[Hskupin (hskupin)]

We see a couple of complains from users who run Firefox 3.5.x on a current Ubuntu release where those icons are not displayed. Can we get this fix into 1.9.1 to show all of the search engine icons again?

[Mozilla-bugs-micahscomputing (mozilla-bugs-micahscomputing)]

(From update of attachment 397085)
Requesting landing on 1.9.1 branch

[Samuel Sidler (samuel-sidler)]

(From update of attachment 397085)
We're not going to take polish fixes on 1.9.1.

[Mh+mozilla (mh+mozilla)]

(In reply to comment #17)
> (From update of attachment 397085 [details])
> We're not going to take polish fixes on 1.9.1.

FYI, the fix for bookmarks, which this fix depends on, has been pushed in 1.9.1.2...

[Gavin Sharp (gavin-sharp)]

(From update of attachment 397085)
Yeah, I think we should take this.

[Dveditz (dveditz)]

(From update of attachment 397085)
Approved for 1.9.1.8, a=dveditz for release-drivers

[Dao (dao)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/fe03d187faa9

[Hskupin (hskupin)]

Verified fixed on 1.9.1 with Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.8pre) Gecko/20100128 Shiretoko/3.5.8pre