Comment 32 for bug 376484

Revision history for this message
In , Mozbugzilla (mozbugzilla) wrote :

Created an attachment (id=289348)
Alternative patch for wildcard matching, incorporating suggestion from comment 25

(In reply to comment #31)
> Perhaps PSM could make use of Necko's TLD stuff, but NSS cannot, so I am
> looking for what we can do in NSS.

A thorough solution probably needs something similar to the database from nsEffectiveTLDService, but I assume that this is not what you want to have in NSS. Thus, incorporating your previous suggestion

> impose a new restriction, that wildcards must be followed by at least two dots
> (that is, two domains) excluding a trailing dot

is probably better than nothing, and therefore I'm proposing this updated patch and am asking for review. (If that solution gets accepted, I could then prepare another patch which removes the PORT_RegExp stuff from NSS - unless there's really a good reason to keep that code in the library.)