Comment 31 for bug 367531

Comment on attachment 575552
netwerk: single check for observer service before notifying

Review of attachment 575552:
-----------------------------------------------------------------

I'll steal the review, because there is at least one significant problem..

but, first, thanks Adam for the patch!

As you note in comment 19 this no longer shuts down the socket service when going offline. Shutting that down actually results in detaching all the active sockets which is something some subsystems are going to depend on. You do add code to close idle connections in http connection manager, but that's just a subset of things. For instance active sockets might just hang - this includes spdy sockets which are always 'active' and as you note websockets too. Also anything using the socket api - such as maybe IMAP in Thunderbird probably has this implicit assumption. So I would say that minimally

a] all the sockets should be detached
b] dns should have an offline mode where it only resolves literals and (bonus points) cache hits.