fails to extract from zip files with latin1 encoding

[chrysn]

Binary package hint: file-roller

file roller fails to extract files from zip files if the file names are encoded in latin1. the error message shown in the error dialog is:

caution: filename not matched: Sch\?ler/test.txt

to reproduce, do:

$ mkdir Schüler
$ convmv -f utf8 -t latin1 --notest Schüler
$ touch Sch*ler/test.txt
$ zip schueler.zip Sch*ler/test.txt
$ file-roller schueler.zip

and try to unpack the folder somewhere (using drag&drop). you get the error message described above.

the file attached shows the problem and was created roughly as described above.

it seems that the file name gets shell-escaped (as the problem doesn't show up with file names containing literal question marks), then passed through something that reduces unprintable characters to question marks, and then again inserted in a shell command.

(standard note: using shell commands with untrusted data can be made somewhat safe by using escaping, but (as this bug shows) escaping can be erroneous. it is usually possible to get along without passing data through shells just as well, which is much safer.)

ProblemType: Bug
DistroRelease: Ubuntu 10.04
Package: file-roller 2.30.1.1-0ubuntu2
ProcVersionSignature: Ubuntu 2.6.32-30.59-generic 2.6.32.29+drm33.13
Uname: Linux 2.6.32-30-generic i686
Architecture: i386
Date: Mon Apr 11 19:24:10 2011
ProcEnviron:
 LANGUAGE=de_AT:de
 PATH=(custom, user)
 LANG=de_AT.utf8
 SHELL=/bin/bash
SourcePackage: file-roller

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.