fglrx 2:13.350-0ubuntu1: fglrx kernel module failed to build [error: incompatible types when returning type ‘kuid_t’ but ‘KCL_TYPE_Uid’ was expected]

[Joachim Johansson]

I tried to get fglrx working together with linux-image-3.14.0-031400rc5-generic_3.14.0-031400rc5.201403022235_amd64 trying to resolve another issue.

ProblemType: Package
DistroRelease: Ubuntu 14.04
Package: fglrx 2:13.350-0ubuntu1
ProcVersionSignature: Ubuntu 3.13.0-15.35-generic 3.13.5
Uname: Linux 3.13.0-15-generic x86_64
NonfreeKernelModules: wl fglrx
.tmp.unity.support.test.0:

ApportVersion: 2.13.2-0ubuntu5
Architecture: amd64
CompizPlugins: No value set for `/apps/compiz-1/general/screen0/options/active_plugins'
CompositorRunning: compiz
CompositorUnredirectDriverBlacklist: '(nouveau|Intel).*Mesa 8.0'
CompositorUnredirectFSW: true
DKMSKernelVersion: 3.14.0-031400rc5-generic
Date: Wed Mar 5 21:12:50 2014
DistUpgraded: 2014-02-24 10:04:39,998 DEBUG enabling apt cron job
DistroCodename: trusty
DistroVariant: ubuntu
DuplicateSignature: dkms:fglrx:2:13.350-0ubuntu1:/var/lib/dkms/fglrx/13.350/build/2.6.x/firegl_public.c:1764:5: error: incompatible types when returning type ‘kuid_t’ but ‘KCL_TYPE_Uid’ was expected
GraphicsCard:
 Advanced Micro Devices, Inc. [AMD/ATI] Trinity [Radeon HD 7600G] [1002:9908] (prog-if 00 [VGA controller])
   Subsystem: ASUSTeK Computer Inc. Device [1043:1557]
InstallationDate: Installed on 2014-02-21 (12 days ago)
InstallationMedia: Ubuntu 13.10 "Saucy Salamander" - Release amd64 (20131016.1)
MachineType: ASUSTeK COMPUTER INC. U38N
PackageVersion: 2:13.350-0ubuntu1
ProcKernelCmdLine: BOOT_IMAGE=/boot/vmlinuz-3.13.0-15-generic.efi.signed root=UUID=d2bc6ca7-191c-4302-aeb2-9cbc60ed7b03 ro nomodeset xforcevesa
SourcePackage: fglrx-installer
Title: fglrx 2:13.350-0ubuntu1: fglrx kernel module failed to build
UpgradeStatus: Upgraded to trusty on 2014-02-24 (9 days ago)
dmi.bios.date: 05/29/2013
dmi.bios.vendor: American Megatrends Inc.
dmi.bios.version: U38N.209
dmi.board.asset.tag: ATN12345678901234567
dmi.board.name: U38N
dmi.board.vendor: ASUSTeK COMPUTER INC.
dmi.board.version: 1.0
dmi.chassis.asset.tag: No Asset Tag
dmi.chassis.type: 10
dmi.chassis.vendor: ASUSTeK COMPUTER INC.
dmi.chassis.version: 1.0
dmi.modalias: dmi:bvnAmericanMegatrendsInc.:bvrU38N.209:bd05/29/2013:svnASUSTeKCOMPUTERINC.:pnU38N:pvr1.0:rvnASUSTeKCOMPUTERINC.:rnU38N:rvr1.0:cvnASUSTeKCOMPUTERINC.:ct10:cvr1.0:
dmi.product.name: U38N
dmi.product.version: 1.0
dmi.sys.vendor: ASUSTeK COMPUTER INC.
version.compiz: compiz 1:0.9.11+14.04.20140303-0ubuntu1
version.fglrx-installer: fglrx-installer N/A
version.ia32-libs: ia32-libs N/A
version.libdrm2: libdrm2 2.4.52-1
version.libgl1-mesa-dri: libgl1-mesa-dri 10.1.0~rc3-0ubuntu2
version.libgl1-mesa-dri-experimental: libgl1-mesa-dri-experimental N/A
version.libgl1-mesa-glx: libgl1-mesa-glx 10.1.0~rc3-0ubuntu2
version.xserver-xorg-core: xserver-xorg-core 2:1.15.0-1ubuntu6
version.xserver-xorg-input-evdev: xserver-xorg-input-evdev 1:2.8.2-1ubuntu2
version.xserver-xorg-video-ati: xserver-xorg-video-ati N/A
version.xserver-xorg-video-intel: xserver-xorg-video-intel 2:2.99.910-0ubuntu1
version.xserver-xorg-video-nouveau: xserver-xorg-video-nouveau 1:1.0.10-1ubuntu2
xserver.bootTime: Wed Mar 5 21:17:50 2014
xserver.configfile: /etc/X11/xorg.conf
xserver.errors:
 AIGLX error: failed to open /usr/X11R6/lib64/modules/dri/fglrx_dri.so, error[/usr/X11R6/lib64/modules/dri/fglrx_dri.so: cannot open shared object file: No such file or directory]
 AIGLX error: failed to open /usr/lib64/dri/fglrx_dri.so, error[/usr/lib64/dri/fglrx_dri.so: cannot open shared object file: No such file or directory]
 AIGLX error: failed to open /usr/X11R6/lib/modules/dri/fglrx_dri.so, error[/usr/X11R6/lib/modules/dri/fglrx_dri.so: cannot open shared object file: No such file or directory]
xserver.logfile: /var/log/Xorg.0.log
xserver.version: 2:1.15.0-1ubuntu6
xserver.video_driver: fglrx

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Alberto Salvia Novella (es20490446e)]

It prevents the package (or a dependent one) from functioning correctly at all.

[Lupius (lupius)]

The guys at Suse has published a patch.

diff -rup fglrx.orig/firegl_public.c fglrx/firegl_public.c
--- fglrx.orig/firegl_public.c 2013-12-20 01:37:15.155648294 +0100
+++ fglrx/firegl_public.c 2013-12-21 01:02:47.201517242 +0100
@@ -1754,11 +1754,17 @@ KCL_TYPE_Pid ATI_API_CALL KCL_GetTgid(vo
  */
 KCL_TYPE_Uid ATI_API_CALL KCL_GetEffectiveUid(void)
 {
+#ifdef CONFIG_UIDGID_STRICT_TYPE_CHECKS
+ return __kuid_val(current_euid());
+#else
+
 #ifdef current_euid
     return current_euid();
 #else
     return current->euid;
 #endif
+
+#endif
 }

 /** /brief Delay execution for the specified number of microseconds
diff -rup fglrx.orig/kcl_acpi.c fglrx/kcl_acpi.c
--- fglrx.orig/kcl_acpi.c 2013-12-20 01:13:55.000000000 +0100
+++ fglrx/kcl_acpi.c 2013-12-21 01:06:00.158734992 +0100
@@ -792,7 +792,9 @@ static unsigned int KCL_ACPI_SearchHandl
 unsigned int ATI_API_CALL KCL_ACPI_GetHandles(kcl_match_info_t *pInfo)
 {
 #if LINUX_VERSION_CODE > KERNEL_VERSION(2,6,12)
- #if LINUX_VERSION_CODE >= KERNEL_VERSION(3,8,0)
+ #if LINUX_VERSION_CODE >= KERNEL_VERSION(3,13,0)
+ pInfo->video_handle = pInfo->pcidev->dev.acpi_node.companion;
+ #elif LINUX_VERSION_CODE >= KERNEL_VERSION(3,8,0)
         pInfo->video_handle = pInfo->pcidev->dev.acpi_node.handle;
     #elif LINUX_VERSION_CODE > KERNEL_VERSION(2,6,19)
         pInfo->video_handle = pInfo->pcidev->dev.archdata.acpi_handle;
@@ -996,6 +998,10 @@ int ATI_API_CALL KCL_ACPI_ParseTable(cha
     {
         return KCL_ACPI_ERROR;
     }
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(3,9,1)
+ ((acpi_tbl_table_handler)handler)(hdr);
+#else
     ((acpi_table_handler)handler)(hdr);
+#endif
     return KCL_ACPI_OK;
 }

thread: http://forums.opensuse.org/showthread.php/493913-ATI-Proprietary-driver-13-12-installation-fails-in-openSUSE-13-1

[Evan Langlois (uudruid74)]

I seem to have the #ifdef CONFIG_UIDGID_STRICT_TYPE_CHECKS patch installed in the source tree already, but it still fails to build. I had to add a -DCONFIG_UIDGID_STRICT_TYPE_CHECKS into the makefile to get it to build. About to see if manually installing it worked ... I'm kinda out in the open here!

Might want to have the installer GUI mention when this fails and automatically display the LOG to people. Most people aren't running the installer from a terminal, few end-users read the screen, especially when a box doesn't pop-up in their face. All they know is that "it didn't work".

[Evan Langlois (uudruid74)]

Nope - apparently the Xorg side isn't getting installed. I could manually install the module into the kernel, but since the installer stopped at the kernel build, it evidently didn't finish the rest maybe? Xorg tries to load fglrx, but can't. Still playing with it, but it's getting there. Do the ATI guys watch here, or does someone push this info upstream to AMD?