Le 20/09/2014 00:08, Aron Xu a écrit : >>> ------- >>> -> fcitx: >> >>> * BLOCKER: presagege is missing as a build-dep, do you mind either not >> building with it (optional dep) or add it and check it matches the MIR >> criterias? >> >> Added and checked presage and libtinyxml (b-d/dep of presage) to MIR. >> Live without presage is doable, but better avoid that. >> >> -> Thanks, looking to it. >> >>> * BLOCKER: there are some LGPL files and no COPYING.LGPL file, please >> ship it in the upstream tarball. >> >> https://github.com/fcitx/fcitx/issues/169 >> >> I can commit but usually don't do that directly. >> >> -> Same than for brise, we need a release with this change before being >> able to promote to main. >> > > Uploaded to Debian, will sync to Ubuntu after being published. Ack, keep me posted. > > >> >>> * NEED INFO/FIXING: fcitx-libs-gclient (and a lot of other binary packages): package-name-doesnt-match-sonames. Do you know why we don't follow upstream soname? They are at 0, so package name should be fcitx-libs-gclient0 as it's a public library. Otherwise, it should be in a private path. >>> * NEED FIXING: I noted the remark on fcitx-libs in debian/README.source, and even if I'm not a fan of the current approach of the 3 libraries in the same package, I think we can live with it. However, we need to have a soname in the end, so that the binary package name can be bumped for any soname breaking in one of the 3 libraries (as some rdepends are not frmothe same source pacakage, like kde-config-fcitx or youker-assistant). >> >> The reason is that we have done this for fcitx-libs before, so that >> following the same convention. We plan to change that when next major >> release of Fcitx is out, and for now the API/ABI is pretty stable for >> a while so there is no real pressure to rush for that. >> >> -> Still, this is a main criteria definition. So either have it >> committed to the packaging github and I can accept without the change >> being in ubuntu yet (please plan for the first library bump), either >> ship with the soname change now to get it acked to main. >> > > This is done in Debian git: > http://anonscm.debian.org/cgit/pkg-ime/fcitx.git/commit/?id=07455aef1c1f19d85d5b68acaaa47ef3f6f464e7 Any upload planned with the fix? > > >> >>> * NEED FIXING: even if it's wrap under a sh call, better to be coherent and get the script executable: W: fcitx-bin: script-not-executable usr/share/fcitx/data/env_setup.sh >> >> This is intentional done by upstream, so after some communication I >> don't see strong reason to maintain a diff. >> >> -> Ack. >> >>> * NEED FIXING: debian/copyright: >>> - fcitx-4.2.8.4/src/frontend/qt/keyserver_x11.h: missing copyright to 2004 Jaroslaw Staniek