far2ledit command fails to open files in /etc

[Unxed]

[ Impact ]

The far2ledit command incorrectly opens an empty editor when the file path starts with /e, impacting users editing configuration files (often in /etc). This fix corrects the command-line parsing, restoring the expected file editing functionality.

[ Test Plan ]

1. Install the updated far2l (after applying the patch).

2. Run far2ledit /etc/hosts and verify /etc/hosts opens correctly.

3. Compare with the current version from the official repositories where this command opens an empty editor.

[ Where problems could occur ]

The fix alters command-line parsing. Regressions are possible if other valid options are now misinterpreted. Test several random far2l and far2ledit command-line options, including at least one involving file path.

[ Other Info ]

This fix, extensively tested in a public PPA with no reported regressions, addresses a specific parsing issue with minimal code changes. It's crucial for usability and system administration, particularly for editing files within /etc. The patches cover both 24.04 LTS and 24.10.

ProblemType: Bug
DistroRelease: Ubuntu 24.04
Package: far2l 2.6.0~beta+ds-1ubuntu0.1
ProcVersionSignature: User Name 6.8.0-31.31-generic 6.8.1
Uname: Linux 6.8.0-31-generic x86_64
ApportVersion: 2.28.1-0ubuntu2
Architecture: amd64
CasperMD5CheckMismatches: ./boot/grub/grub.cfg
CasperMD5CheckResult: fail
CurrentDesktop: ubuntu:GNOME
Date: Wed Oct 9 08:33:14 2024
InstallationDate: Installed on 2024-04-29 (163 days ago)
InstallationMedia: Ubuntu 24.04 LTS "Noble Numbat" - Release amd64 (20240424)
ProcEnviron:
 LANG=en_US.UTF-8
 PATH=(custom, no user)
 SHELL=/bin/bash
 TERM=xterm-256color
 XDG_RUNTIME_DIR=<set>
SourcePackage: far2l
UpgradeStatus: No upgrade log present (probably fresh install)

[Unxed (unxed)]

patch for 24.10

[Unxed (unxed)]

patch for 24.04

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "fix_far2ledit_2410.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

[Steve Langasek (vorlon)]

Hello Unxed, or anyone else affected,

Accepted far2l into oracular-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/far2l/2.6.3~beta+ds-1ubuntu4.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-oracular to verification-done-oracular. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-oracular. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Steve Langasek (vorlon)]

Hello Unxed, or anyone else affected,

Accepted far2l into noble-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/far2l/2.6.0~beta+ds-1ubuntu0.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-noble to verification-done-noble. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-noble. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Unxed (unxed)]

Tested
2.6.0~beta+ds-1ubuntu0.3
from
https://launchpad.net/ubuntu/+source/far2l/2.6.0~beta+ds-1ubuntu0.3/+build/29170121

in 24.04.

The bug is fixed.

[Dmitry Shachnev (mitya57)]

Tested version from oracular-proposed:

$ apt policy far2l
far2l:
  Installed: 2.6.3~beta+ds-1ubuntu4.1
  Candidate: 2.6.3~beta+ds-1ubuntu4.1
  Version table:
 *** 2.6.3~beta+ds-1ubuntu4.1 100
        100 http://archive.ubuntu.com/ubuntu oracular-proposed/universe amd64 Packages
        100 /var/lib/dpkg/status
     2.6.3~beta+ds-1ubuntu4 500
        500 http://archive.ubuntu.com/ubuntu oracular/universe amd64 Packages

- far2ledit /etc/hosts — works, opens the file correctly
- far2l -e /etc/hosts — also works, does the same
- far2ledit --help; far2l /h — show help as expected

So marking as verified for Oracular.

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for far2l has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package far2l - 2.6.0~beta+ds-1ubuntu0.3

---------------
far2l (2.6.0~beta+ds-1ubuntu0.3) noble; urgency=medium

  * Backport upstream patch to fix mouse and clipboard in WSL (LP: #2083233).
  * Backport upstream patch to fix opening files from /etc in far2ledit
    (LP: #2084045).
  * Backport upstream patch to fix highlighting of smarty PHP templates
    (LP: #2084094).

 -- Dmitry Shachnev <email address hidden> Thu, 10 Oct 2024 21:52:11 +0300

[Launchpad Janitor (janitor)]

This bug was fixed in the package far2l - 2.6.3~beta+ds-1ubuntu4.1

---------------
far2l (2.6.3~beta+ds-1ubuntu4.1) oracular; urgency=medium

  * Backport upstream patch to fix opening files from /etc in far2ledit
    (LP: #2084045).

 -- Dmitry Shachnev <email address hidden> Thu, 10 Oct 2024 20:36:08 +0300