Trying to copy text from lnav to clipboard leads to empty clipboard

[Unxed]

[ Impact ]

This happens due to error in OSC52 protocol implementation in far2l internal terminal emulator.

OSC52 is an actively implemented standard (already supported by Konsole from KDE, for example) for clipboard interaction from console applications. Its implementation in far2l contained a bug that resulted in an empty clipboard after the copy procedure.

The bug affects all users of applications that support OSC52, as well as those that will support it in the near future, for the entire duration of the LTS release support.

[ Test Plan ]

The simplest way to test is to try copying a string like "copypasta!" to the clipboard by running the following command inside far2l:

printf "\033]52;c;Y29weXBhc3RhIQ==\a\n"

Upon pressing "Allow once", the string "copypasta!" should appear in the clipboard. If the bug is present, the clipboard will be empty.

You can also test this using the lnav application itself:

Run lnav inside far2l. Select a line from the log. Press m to mark. Press c to copy to clipboard. Select "Allow once". Try to paste in any other app. Expected behavior: the log line should be in the clipboard as it works in the kitty terminal, for example.

[ Where problems could occur ]

Potentially it may broke OSC52, but as it is already broken, it does not look like a serious risk factor.

[ Other Info ]

Already fixed in far2l master:
https://github.com/elfmz/far2l/pull/2371/files

ProblemType: Bug
DistroRelease: Ubuntu 24.04
Package: far2l 2.6.0~beta+ds-1ubuntu0.1
ProcVersionSignature: User Name 6.8.0-31.31-generic 6.8.1
Uname: Linux 6.8.0-31-generic x86_64
ApportVersion: 2.28.1-0ubuntu2
Architecture: amd64
CasperMD5CheckMismatches: ./boot/grub/grub.cfg
CasperMD5CheckResult: fail
CurrentDesktop: ubuntu:GNOME
Date: Tue Sep 3 13:17:34 2024
InstallationDate: Installed on 2024-04-29 (127 days ago)
InstallationMedia: Ubuntu 24.04 LTS "Noble Numbat" - Release amd64 (20240424)
ProcEnviron:
 LANG=en_US.UTF-8
 PATH=(custom, no user)
 SHELL=/bin/bash
 TERM=xterm-256color
 XDG_RUNTIME_DIR=<set>
SourcePackage: far2l
UpgradeStatus: No upgrade log present (probably fresh install)

[Launchpad Janitor (janitor)]

This bug was fixed in the package far2l - 2.6.3~beta+ds-1ubuntu3

---------------
far2l (2.6.3~beta+ds-1ubuntu3) oracular; urgency=medium

  * Add a patch to fix broken osc52 in VT (LP: #2078844).

 -- Dmitry Shachnev <email address hidden> Wed, 04 Sep 2024 09:38:08 +0300

[Timo Aaltonen (tjaalton)]

Hello Unxed, or anyone else affected,

Accepted far2l into noble-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/far2l/2.6.0~beta+ds-1ubuntu0.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-noble to verification-done-noble. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-noble. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Unxed (unxed)]

Tested 2.6.0~beta+ds-1ubuntu0.2, fix confirmed.

[Launchpad Janitor (janitor)]

This bug was fixed in the package far2l - 2.6.0~beta+ds-1ubuntu0.2

---------------
far2l (2.6.0~beta+ds-1ubuntu0.2) noble; urgency=medium

  * Backport upstream patch to fix file selection from keyboard on Wayland
    (LP: #2076972).
  * Backport upstream patch to enable esc expiration in kernel console
    (LP: #2077270).
  * Backport upstream patch to fix broken osc52 in VT (LP: #2078844).

 -- Dmitry Shachnev <email address hidden> Sun, 08 Sep 2024 20:02:37 +0300

[Andreas Hasenack (ahasenack)]

The verification of the Stable Release Update for far2l has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.