Activity log for bug #1170325

Date Who What changed Old value New value Message
2013-04-18 12:13:00 rustx bug added bug
2013-04-18 12:13:00 rustx attachment added new proposed version for virtual.rb https://bugs.launchpad.net/bugs/1170325/+attachment/3647470/+files/patch_facter_1.6.5.diff
2013-04-18 12:15:56 Ubuntu Foundations Team Bug Bot tags patch
2013-04-18 12:16:02 Ubuntu Foundations Team Bug Bot bug added subscriber Ubuntu Review Team
2013-04-18 13:25:20 Robie Basak bug added subscriber Robie Basak
2013-04-24 13:15:01 rustx attachment added test case with bug https://bugs.launchpad.net/ubuntu/+source/facter/+bug/1170325/+attachment/3652273/+files/new_version.txt
2013-04-24 13:17:12 rustx attachment added old_version.txt https://bugs.launchpad.net/ubuntu/+source/facter/+bug/1170325/+attachment/3652274/+files/old_version.txt
2013-04-24 13:17:42 rustx attachment added new_version.txt https://bugs.launchpad.net/ubuntu/+source/facter/+bug/1170325/+attachment/3652275/+files/new_version.txt
2013-04-25 08:46:59 Sebastien Bacher bug added subscriber Ubuntu Sponsors Team
2013-05-15 07:53:10 Adam Conrad nominated for series Ubuntu Precise
2013-05-15 07:53:10 Adam Conrad bug task added facter (Ubuntu Precise)
2013-05-15 07:53:10 Adam Conrad nominated for series Ubuntu Quantal
2013-05-15 07:53:10 Adam Conrad bug task added facter (Ubuntu Quantal)
2013-05-15 07:53:42 Adam Conrad nominated for series Ubuntu Raring
2013-05-15 07:53:42 Adam Conrad bug task added facter (Ubuntu Raring)
2013-05-20 15:31:34 Robie Basak description On ubuntu 12.04 LTS, the official version for the facter package is 1.6.5-ubuntu1. ii facter 1.6.5-1ubuntu1 collect and display facts about the system The is_virtual? method is not recognized on last version of KVM, because of the output of /proc/cpuinfo, which does not contains “Qemu Server” Infos. model name : Common KVM processor The workaround was added in the next versions of facter, and so I would like to provide you this patch, which fixes this bug on Ubuntu 12.04 LTS. Best regards [Impact] facter recognises a /proc/cpuinfo CPU model of "Common KVM processor" as a physical machine. facter is most often used with puppet, and causes puppet manifests to mis-classify virtual machines of this type and apply incorrect rules where the puppet manifests supplied by system administrators differ on this criterion. [Stable and Development Fix] A cherry-pick of the upstream fix, modified to be made minimal (one line). See the quilt patch for details. [Test Case 1] Run "facter is_virtual". On a physical machine, this should say false. On a virtual machine reporting in /proc/cpuinfo as "QEMU Virtual CPU" as well as a virtual machine reporting in /proc/cpuinfo as "Common KVM Processor", "facter is_virtual" should say true. [Test Case 2] As a shortcut, on Quantal and Raring you can fake the /proc/cpuinfo file as follows: mkdir -p /tmp/proc/{lower,upper,combined} cd /tmp/proc mount -t proc none lower mount -t tmpfs -o mode=755 none upper mount -t overlayfs -o lowerdir=lower,upperdir=upper none combined stop rsyslogd stop acpid umount /proc && mount --bind combined /proc Then you can edit /proc/cpuinfo and run facter to test behaviour as per Test Case 1. This is a hack and does not appear to work correctly in Precise. [Regression Potential] It looks like detection of other model strings in /proc/cpuinfo may have regressed upstream, fixed by a later commit. It's important to test that both model strings of "QEMU Virtual CPU" and "Common KVM processor" detect as virtual, and that another string (eg. "Other") detects as physical. [Original Description] On ubuntu 12.04 LTS, the official version for the facter package is 1.6.5-ubuntu1. ii facter 1.6.5-1ubuntu1 collect and display facts about the system The is_virtual? method is not recognized on last version of KVM, because of the output of /proc/cpuinfo, which does not contains “Qemu Server” Infos. model name : Common KVM processor The workaround was added in the next versions of facter, and so I would like to provide you this patch, which fixes this bug on Ubuntu 12.04 LTS. Best regards
2013-05-21 08:47:41 Robie Basak facter (Ubuntu): status New Triaged
2013-05-21 08:47:43 Robie Basak facter (Ubuntu Precise): status New Triaged
2013-05-21 08:47:45 Robie Basak facter (Ubuntu Quantal): status New Triaged
2013-05-21 08:47:47 Robie Basak facter (Ubuntu Raring): status New Triaged
2013-05-24 16:09:13 Launchpad Janitor facter (Ubuntu): status Triaged Fix Released
2013-05-30 19:16:34 Brian Murray removed subscriber Ubuntu Sponsors Team
2013-06-05 00:41:08 Chris Halse Rogers facter (Ubuntu Precise): status Triaged Fix Committed
2013-06-05 00:41:14 Chris Halse Rogers bug added subscriber Ubuntu Stable Release Updates Team
2013-06-05 00:41:18 Chris Halse Rogers bug added subscriber SRU Verification
2013-06-05 00:41:26 Chris Halse Rogers tags patch patch verification-needed
2013-06-06 16:58:11 Brian Murray facter (Ubuntu Quantal): status Triaged Fix Committed
2013-06-06 16:59:48 Brian Murray facter (Ubuntu Raring): status Triaged Fix Committed
2013-09-19 08:14:24 Robie Basak description [Impact] facter recognises a /proc/cpuinfo CPU model of "Common KVM processor" as a physical machine. facter is most often used with puppet, and causes puppet manifests to mis-classify virtual machines of this type and apply incorrect rules where the puppet manifests supplied by system administrators differ on this criterion. [Stable and Development Fix] A cherry-pick of the upstream fix, modified to be made minimal (one line). See the quilt patch for details. [Test Case 1] Run "facter is_virtual". On a physical machine, this should say false. On a virtual machine reporting in /proc/cpuinfo as "QEMU Virtual CPU" as well as a virtual machine reporting in /proc/cpuinfo as "Common KVM Processor", "facter is_virtual" should say true. [Test Case 2] As a shortcut, on Quantal and Raring you can fake the /proc/cpuinfo file as follows: mkdir -p /tmp/proc/{lower,upper,combined} cd /tmp/proc mount -t proc none lower mount -t tmpfs -o mode=755 none upper mount -t overlayfs -o lowerdir=lower,upperdir=upper none combined stop rsyslogd stop acpid umount /proc && mount --bind combined /proc Then you can edit /proc/cpuinfo and run facter to test behaviour as per Test Case 1. This is a hack and does not appear to work correctly in Precise. [Regression Potential] It looks like detection of other model strings in /proc/cpuinfo may have regressed upstream, fixed by a later commit. It's important to test that both model strings of "QEMU Virtual CPU" and "Common KVM processor" detect as virtual, and that another string (eg. "Other") detects as physical. [Original Description] On ubuntu 12.04 LTS, the official version for the facter package is 1.6.5-ubuntu1. ii facter 1.6.5-1ubuntu1 collect and display facts about the system The is_virtual? method is not recognized on last version of KVM, because of the output of /proc/cpuinfo, which does not contains “Qemu Server” Infos. model name : Common KVM processor The workaround was added in the next versions of facter, and so I would like to provide you this patch, which fixes this bug on Ubuntu 12.04 LTS. Best regards [Impact] facter recognises a /proc/cpuinfo CPU model of "Common KVM processor" as a physical machine. facter is most often used with puppet, and causes puppet manifests to mis-classify virtual machines of this type and apply incorrect rules where the puppet manifests supplied by system administrators differ on this criterion. [Stable and Development Fix] A cherry-pick of the upstream fix, modified to be made minimal (one line). See the quilt patch for details. [Test Case 1] Run "facter is_virtual". On a physical machine, this should say false. On a virtual machine reporting in /proc/cpuinfo as "QEMU Virtual CPU" as well as a virtual machine reporting in /proc/cpuinfo as "Common KVM Processor", "facter is_virtual" should say true. [Test Case 2] As a shortcut, on Quantal and Raring you can fake the /proc/cpuinfo file as follows: mkdir -p /tmp/proc/{lower,upper,combined} cd /tmp/proc mount -t proc none lower mount -t tmpfs -o mode=755 none upper mount -t overlayfs -o lowerdir=lower,upperdir=upper none combined stop rsyslog stop acpid umount /proc && mount --bind combined /proc Then you can edit /proc/cpuinfo and run facter to test behaviour as per Test Case 1. This is a hack and does not appear to work correctly in Precise. [Regression Potential] It looks like detection of other model strings in /proc/cpuinfo may have regressed upstream, fixed by a later commit. It's important to test that both model strings of "QEMU Virtual CPU" and "Common KVM processor" detect as virtual, and that another string (eg. "Other") detects as physical. [Original Description] On ubuntu 12.04 LTS, the official version for the facter package is 1.6.5-ubuntu1. ii facter 1.6.5-1ubuntu1 collect and display facts about the system The is_virtual? method is not recognized on last version of KVM, because of the output of /proc/cpuinfo, which does not contains “Qemu Server” Infos. model name : Common KVM processor The workaround was added in the next versions of facter, and so I would like to provide you this patch, which fixes this bug on Ubuntu 12.04 LTS. Best regards
2013-09-19 08:31:47 Robie Basak tags patch verification-needed patch verification-done
2013-09-19 09:56:03 Launchpad Janitor facter (Ubuntu Quantal): status Fix Committed Fix Released
2013-09-19 09:56:10 Colin Watson removed subscriber Ubuntu Stable Release Updates Team
2013-09-19 09:56:28 Launchpad Janitor facter (Ubuntu Raring): status Fix Committed Fix Released
2021-10-14 05:06:01 Steve Langasek facter (Ubuntu Precise): status Fix Committed Won't Fix