disable Mail Notification eplugin by default

Bug #331571 reported by Ken VanDine on 2009-02-19
40
This bug affects 1 person
Affects Status Importance Assigned to Milestone
evolution (Ubuntu)
Low
Ken VanDine
Jaunty
Low
Ken VanDine

Bug Description

Binary package hint: evolution

With the new notification system in Jaunty, we have evolution-indicator for message notification. We should disable the mail notification eplugin by default in favor of the evolution-indicator.

However, ideally we would enable it if GDMSESSION=gnome-stracciatella

Related branches

Changed in evolution:
assignee: nobody → ken-vandine
status: New → Confirmed
syldeb35 (sylvain-debray) wrote :

Well noted for the duplicate.
However, the new plug-in didn't notice if the new mail is not in Inbox. (Auto sorted mails)
output in the .xsession-errors:
** (evolution:9806): DEBUG: Not inbox
and no config options.

Changed in evolution:
importance: Undecided → Low
Ken VanDine (ken-vandine) wrote :

Suggested patch

Martin Pitt (pitti) wrote :

We can't integrate this into stracciatella if we change gconf defaults. Also, changing the default key wouldn't work for people who have explicitly enabled it in their personal gconf tree.

I see two alternatives:

 * Make the plugin disable/quit itself if the indicator plugin is active (would be suitable for upstreaming)
 * Make the plugin disable/quit itself if GNOME_SESSION!=gnome-stracciatella (ubuntu specific, can't upstream)

Ken VanDine (ken-vandine) wrote :

My worry with making the plugin disable itself is applications that might be depending on that plugin being enabled to poll for new mail. That plugin doesn't just provide the icon, it provides dbus alerts for new mail.

Ken VanDine [2009-02-25 14:52 -0000]:
> My worry with making the plugin disable itself is applications that
> might be depending on that plugin being enabled to poll for new mail.
> That plugin doesn't just provide the icon, it provides dbus alerts for
> new mail.

Ah, I see. So the indicator plugin doesn't provide those, or at least
not the same? In this case I think it's entirely reasonable to just
suppress the applet itself, but leave the plugin running.

Bowmore (bowmore) wrote :

> In this case I think it's entirely reasonable to just
> suppress the applet itself, but leave the plugin running.

I don't think this is a good enough solution.

Sure, creating a bridge for bug #1 users is one thing but to adopt to it's annoying behaviour is not an option. This applet aka alert! makes no sense nor do the OK and Cancel buttons. So, please make this event informative, cf a printout job.

Ken VanDine (ken-vandine) wrote :

Propsed patch will check if GDMSESSION=gnome-stracciatella, if that isn't true it will disable the status icon from both the notification area and from the config UI for the plugin.

Sebastien Bacher (seb128) wrote :

thank you for your work, why do you return enable directly in enable_status()?

Ken VanDine (ken-vandine) wrote :

Not intentional, i had some debugging code in there and I missed a line when deleting it. I am attaching a new patch without it.

Martin Pitt (pitti) wrote :

Ken, thanks! I like that approach because it doesn't break stracciatella, and doesn't need gconf schema modifications (which are unreliable).

So with the default Ubuntu session, this will just hide the evo status icon?

Great, thanks!

Ken VanDine (ken-vandine) wrote :

Yes, exactly. It will also hide the status icon portion of the configuration dialog.

Launchpad Janitor (janitor) wrote :
Download full text (4.0 KiB)

This bug was fixed in the package evolution - 2.25.92-0ubuntu1

---------------
evolution (2.25.92-0ubuntu1) jaunty; urgency=low

  * New upstream version:
    Bug Fixes:
    - #238346 : Set timezones from component to the calendar first, then add events
    - #333716 : Do not store incomplete or broken files in a cache
    - #404232 : Rebuild view immediately for an advanced search too
    - #404232 : search bar text is set, thus the text will not be empty, which is considered as "no search" these days.
    - #529037 : Disconnect signals on ESource-s too, not only on ECal-s
    - #548623 : No auto-proxy at the moment
    - #550114 : Replaced 'compute_mouse_over' with 'get_mouse_over', now works with cached values 'motion_row', 'motion_col'
    - #550114 : Show proper tooltip in table with grouping columns
    - #551470 : Do not force adding "--
    - #554458 : Make content type from a mime type first
    - #555888 : Do not overwrite user settings with system proxy settings
    - #558366 : Set default timezone to resolve floating DATE-TIME properly
    - #559027 : Do not set date for 'None' value
    - #559719 : Use it's own/unique name for the property on the 'epl' and free the widget only if it wasn't freed yet
    - #561465 : Expand 'Attendee' column instead of the last
    - #563212 : Ensure empty GError before filling it
    - #564229 : Do not use uninitialized variable
    - #564229 : Initialize the EPluginUI registry during class initialization, so that it's sure to be there when we need it
    - #567089 : Do not crash when no From set yet
    - #567949 : Do not free memory before done with it
    - #568176 : Make the migration dialog look better
    - #569700 : Stop reading from a network when operation was canceled
    - #569986 :
    - #570364 :
    - #571625 : Use black/white for foreground instead of active/inactive text color
    - #571721 :
    - #572268 : Do not duplicate "Loading..." node when adding to existing node
    - #572348 : Call gtk_status_icon_set_tooltip_text
    - #572399 : Do not read from invalid iterator after call of row changed
    - #572543 : Always look for alternative apps for application/octet-stream
    - #572903 :
    - #572950 : Fix ordering of -I compiler directives
    - #572962 : Pass e_shell_dbus_initialise
    - #572975 : Destroy file chooser dialog early enough to not have hidden any other windows below it
    - #573198 :
    $566556 : Make it use the proper action.
    Other contributions:
    Build a "GUI" executable.
    Do not use non-zero page size in an adjustment, it's deprecated now.
    Format signature/encryption information nicer.
    Function-declaration compiler warning.
    Migrate from deprecated gtk_window_set_policy to gtk_window_set_resizable
    Remove deprecated gtk_combo_set_case_sensitive
    Remove useless and deprecated gtk_layout_freeze and gtk_layout_thaw calls.
    Substitute some deprecated gtk functions.
  * debian/control:
    - updated evolution-data-server requirement
  * debian/patches/04_autoconf.patch:
    - new version update
  * debian/patches/62_no_upstream_email_notification_by_default.patch:
    - change by Ken VanDine to not enable the notification icon by ...

Read more...

Changed in evolution:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Bug attachments