[SRU] Add carddav scope to google-contacts.service

[Khurshid Alam]

[Impact]
Now that Yakkety is going to have eds 3.22.6 and as upstream released the fix for 3.22.6, it automatically became eligible for backporting to Yakkety.

[Test case]
After update, users should be able to sync contacts with google carddav server via syncevolution.

[Regression Potential]
None.

[Original Description]
It seems google-contacts.service file Google Contacts API (Gdata) https://www.google.com/m8/feeds/ which is NOT same as CardDav. As a result when some application( ex. Syncevolution) tries to access it (through oauth2), it gives “authentication failed error”.

For example, running following command:

'''

SYNCEVOLUTION_DEBUG=1 syncevolution --print-databases –daemon=no\

loglevel=2 backend=carddav username=uoa:3,google-contacts\

syncURL=https://www.googleapis.com/.well-known/carddav

'''
gives following error:

 “𝗣𝗥𝗢𝗣𝗙𝗜𝗡𝗗: 𝗡𝗲𝗼𝗻 𝗲𝗿𝗿𝗼𝗿 𝗰𝗼𝗱𝗲 𝟭: 𝟰𝟬𝟯 𝗙𝗼𝗿𝗯𝗶𝗱𝗱𝗲𝗻, 𝗺𝘂𝘀𝘁 𝗻𝗼𝘁 𝗿𝗲𝘁𝗿𝘆”

Adding the carddav scope solves the issue. 'https://www.googleapis.com/auth/carddav'

evolution-data-server-online-accounts provides these files.

Patch:

--- a/modules/ubuntu-online-accounts/google-contacts.service.in.in
+++ b/modules/ubuntu-online-accounts/google-contacts.service.in.in
@@ -17,7 +17,7 @@
           <setting name="RedirectUri">https://localhost/</setting>
           <setting name="ClientId">796629365126-a2o58ak3l6nuk9bto6sr5aoku0vh5enc.apps.googleusercontent.com</setting>
           <setting name="ClientSecret">YVigZ5Po5p83_CrwQk-p5SwP</setting>
- <setting type="as" name="Scope">['https://www.googleapis.com/auth/userinfo.email','https://mail.google.com/','https://www.google.com/m8/feeds/','https://www.googleapis.com/auth/calendar']</setting>
+ <setting type="as" name="Scope">['https://www.googleapis.com/auth/userinfo.email','https://mail.google.com/','https://www.google.com/m8/feeds/','https://www.googleapis.com/auth/calendar','https://www.googleapis.com/auth/carddav']]</setting>
         </group>
       </group>
     </group>

Note:

1. Ubuntu already enabled carddav in google developer console (lp:1433943)

2. It requires to grant access twice; one for UOA and one for Evolution (server side). Then only it works (https://bugs.launchpad.net/ubuntu/+source/unity-control-center/+bug/1522360)

[Khurshid Alam (khurshid-alam)]

Just providing the patch file for now.

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "add-carddav-scope.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

[Khurshid Alam (khurshid-alam)]

Upstream-Bug: https://bugzilla.gnome.org/show_bug.cgi?id=778775

[Khurshid Alam (khurshid-alam)]

Fix committed for eds-3.23.x (https://git.gnome.org/browse/evolution-data-server/commit/?id=ce81845)

[Jeremy Bícha (jbicha)]

Khurshid, could you update the bug description for an SRU? I would like to update evolution to 3.22.6 in Ubuntu 16.10 (LP: #1664222). This fix was included in 3.22.6.

https://wiki.ubuntu.com/StableReleaseUpdates#SRU_Bug_Template

[Launchpad Janitor (janitor)]

This bug was fixed in the package evolution-data-server - 3.22.6-1ubuntu1

---------------
evolution-data-server (3.22.6-1ubuntu1) zesty; urgency=medium

  * Merge with Debian (LP: #1628792). Remaining Ubuntu changes:
    - debian/control:
      + Build-depend on libaccounts-glib-dev and libsignon-glib-dev
    - debian/rules:
      + Enable Ubuntu online accounts
    - debian/control,
      debian/evolution-data-server.install:
      debian/evolution-data-server-online-accounts.install:
      + Split online accounts support into a separate package
  * Add evolution-data-server.postinst to recommend restarting
    after updating. Logging out then logging back in is not sufficient.

evolution-data-server (3.22.6-1) unstable; urgency=medium

  * New upstream release.

 -- Jeremy Bicha <email address hidden> Mon, 13 Mar 2017 20:20:52 -0400

[Khurshid Alam (khurshid-alam)]

Done.