Lower case letter in "TCP-UNKNOwN" causing problems - patch

Bug #1474821 reported by Wise Melon
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
etherape (Debian)
Fix Released
Unknown
etherape (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

I have recently noticed that when setting the colour codes for protocols (so that they only ever use a certain specified colour, if the colour is specified) that the protocol "TCP-UNKNOwN" has a lower case letter in it, which means that because the colour coding settings only accept capital letters for protocol names that setting a colour for that protocol actually does the opposite of its intentions, as no protocol is called "TCP-UNKNOWN", and thus meaning that the protocol called "TCP-UNKNOwN" can't use that colour, and nor can any other protocol.

So I have created a patch which I have tested on a Ubuntu Gnome 15.04 32-bit VM, and it works as it should and fixes the problem. It also does not appear to cause any other problems.

Tags: patch
description: updated
summary: - Lower case letter in "TCP-UNKNOwN" causing problems
+ Lower case letter in "TCP-UNKNOwN" causing problems - patch
tags: added: patch
Revision history for this message
Wise Melon (wise-melon-deactivatedaccount) wrote :
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "etherape-0.9.13_TCP-UNKNOWN-protocol_fix.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

Revision history for this message
Michael Terry (mterry) wrote :

Thanks for the patch! I've uploaded this to wily.

Revision history for this message
Wise Melon (wise-melon-deactivatedaccount) wrote :

@Michael Terry, that is good news! Should I change (or you change) the status of this bug report? Or has the fix not been released yet in Wily?

Revision history for this message
Michael Terry (mterry) wrote :

It hasn't been released yet; going through all the building/testing. It'll automatically close when it is released.

(plus, looks like there's an unrelated build failure on amd64 and ppc64el that is holding it up... I'll see if I can figure that out.)

Revision history for this message
Wise Melon (wise-melon-deactivatedaccount) wrote :

Strange that there was a build failure, but I have tested it in a 15.10 VM, and it works fine. Though that was a 32-bit VM and not a 64-bit one due to there being a small amount of RAM assigned to it.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package etherape - 0.9.13-1ubuntu1

---------------
etherape (0.9.13-1ubuntu1) wily; urgency=medium

  [ Yerenkov Scott ]
  * debian/patches/fix-typo.patch:
    - Fix UNKNOwN typo (LP: #1474821)

 -- Michael Terry <email address hidden> Wed, 16 Sep 2015 13:24:04 -0400

Changed in etherape (Ubuntu):
status: New → Fix Released
Revision history for this message
Michael Terry (mterry) wrote :

Oh, sorry I got your name slightly wrong. I had to guess before you changed it in Launchpad.

Figured out what was holding up the build and restarted it. As you can see, the patch landed. Thanks!

Changed in etherape (Debian):
status: Unknown → New
Revision history for this message
Wise Melon (wise-melon-deactivatedaccount) wrote :

It's fine, I'm the only person with "Yerenkov-Scott" in their name so far as I know, and you give the bug report number so that's fine!

I'm glad to hear that you figured out what was holding the build up and fixed it!

Changed in etherape (Debian):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.