[karmic] esperanza uses its own copy of the xmms2 icon

Bug #342221 reported by Benjamin Drung
4
Affects Status Importance Assigned to Milestone
esperanza (Ubuntu)
Fix Released
Wishlist
Unassigned

Bug Description

Binary package hint: esperanza

esperanza provides the xmms2 icon only as nontransparent xmp file, but xmms2 provides the icon as transparent svg and png files.

Revision history for this message
Benjamin Drung (bdrung) wrote :

esperanza (0.4.0-3ubuntu3) jaunty; urgency=low

  * Remove debian/experanza.xpm and use xmms2 icon instead (LP: #342221).
  * debian/control: Move xmms2-core from Suggests to Depends because this
    package contains the xmms2 icon.
  * debian/changelog: Correct Categories entry.
  * debian/esperanza.1: Correct umlaut.

 -- Benjamin Drung <email address hidden> Fri, 13 Mar 2009 12:47:11 +0100

Revision history for this message
Scott Ritchie (scottritchie) wrote :

I've been reviewing this change for a bit, and I'm still not sure that forcing a depends on xmms2 is the right thing. Isn't it possible that a user might not want a local xmms2 daemon running but still be using esperanza to connect to a remote one?

Revision history for this message
Benjamin Drung (bdrung) wrote :

Then the icons of xmms2 must be split from the xmms2-core package. If you put the xmms2 icons in an extra xmms2-icon package, then esperanza must depend on xmms2-icon instead of xmms2-core.

Revision history for this message
Benjamin Drung (bdrung) wrote :

Here is the debdiff for moving the xmms2 icons to an extra package.

Revision history for this message
Benjamin Drung (bdrung) wrote :

Here is the new debdiff for esperanza depending on the previous posted patch for xmms2.

esperanza (0.4.0-3ubuntu3) jaunty; urgency=low

  * Remove debian/experanza.xpm and use xmms2 icon instead (LP: #342221).
  * debian/control: Move xmms2-core from Suggests to Depends because this
    package contains the xmms2 icon.
  * debian/changelog: Correct Categories entry.
  * debian/esperanza.1: Correct umlaut.

 -- Benjamin Drung <email address hidden> Fri, 13 Mar 2009 12:47:11 +0100

Revision history for this message
Benjamin Drung (bdrung) wrote :

I have posted the wrong changelog entry. Here is the correct one:

esperanza (0.4.0-3ubuntu3) jaunty; urgency=low

  * Remove debian/experanza.xpm and use xmms2 icon instead (LP: #342221).
  * debian/control: Add xmms2-icon to Depends.
  * debian/changelog: Correct Categories entry.
  * debian/esperanza.1: Correct umlaut.

 -- Benjamin Drung <email address hidden> Sat, 11 Apr 2009 22:53:45 +0200

Revision history for this message
Iain Lane (laney) wrote :

Let's defer this change to Karmic; it's too late now to include changes to such a trivial issue.

I would appreciate it very much if you could forward these changes to Debian so that we can get them semi-automatically instead of maintaining the change in Ubuntu. Indeed it is possible that we might decide not to carry such a change at all, as everything we do differently to Debian carries a cost in terms of maintainer time and effort. So convincing Debian to adopt our good ideas means everybody wins. See [0] for more information.

[0] https://wiki.ubuntu.com/Debian/Bugs

Changed in esperanza (Ubuntu):
importance: Undecided → Wishlist
status: New → Triaged
summary: - esperanza uses its own copy of the xmms2 icon
+ [karmic] esperanza uses its own copy of the xmms2 icon
Revision history for this message
Nick Ellery (nick.ellery) wrote :

Hi, can you please provide a new debdiff against karmic? Thanks.

Changed in esperanza (Ubuntu):
status: Triaged → Incomplete
Revision history for this message
Benjamin Drung (bdrung) wrote :

Currently, no. Bug #394938 needs to be fixed first otherwise this patch is useless.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package esperanza - 0.4.0+git20090708-1

---------------
esperanza (0.4.0+git20090708-1) unstable; urgency=high

  * New upstream snapshot.
    + Compatible to xmms2 0.6DrMattDestruction (Closes: #531418, #528825,
      LP: #394938).
    + Fix crash on shutdown (Closes: #485918).
  * Add myself to uploaders.
  * debian/control: Split Build-Depends line.
  * Added debian/watch (sync from Ubuntu).
  * Added debian/esperanza.1, debian/manpages and run dh_installman in
    binary-arch target (sync from Ubuntu).
  * Added debian/esperanza.desktop and add xmms2-icon to Depends
    (Closes: #444937, LP: #342221).
  * Bump Standard-Version to 3.8.2, no changes needed.
  * Extend binary package description.
  * Update debian/copyright to use the format described in DEP 5.
  * Remove Thomas Jollans <email address hidden> from Uploaders.
  * Switch to cdbs and debhelper v7.
  * Add 0001-OTHER-Fixes-for-breakages-because-of-uint-removal.patch.

 -- Benjamin Drung <email address hidden> Mon, 24 Aug 2009 13:01:41 +0100

Changed in esperanza (Ubuntu):
status: Incomplete → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.