proposed-migration for eso-midas 23.02pl1.0-1build1

[Steve Langasek]

eso-midas 23.02pl1.0-1build1 is built in -proposed but not on armhf. This will not block migration because armhf binaries are being removed from the release pocket, but unless addressed will regress armhf availability of this package in 24.04 LTS.

[Adrien Nader (adrien)]

Build now fails on all arches with

    # of pixels used = 843920 from 1,1 to 880,959 (in pixels)
    FITS file newVIMOS.fits will have 4 extensions
    *** buffer overflow detected ***: terminated

This is the same issue as back in March when this bug was created (I had seen the issue and found it again in my logs).

[Adrien Nader (adrien)]

For reference, backtrace of the issue (I've inserted a call to gdb for "prepa.exe" in the "inmidas" shell script. There are tons of fortify warnings during build. Also, note that the Debian maintainer disabled implicit function declarations, citing that the code is very old, and indeed, it started in the 80s.

*** buffer overflow detected ***: terminated

Program received signal SIGABRT, Aborted.
0x00007ffff7be7b1c in pthread_kill () from /lib/x86_64-linux-gnu/libc.so.6
(gdb) bt
#0 0x00007ffff7be7b1c in pthread_kill () from /lib/x86_64-linux-gnu/libc.so.6
#1 0x00007ffff7b8e26e in raise () from /lib/x86_64-linux-gnu/libc.so.6
#2 0x00007ffff7b718ff in abort () from /lib/x86_64-linux-gnu/libc.so.6
#3 0x00007ffff7b727b6 in ?? () from /lib/x86_64-linux-gnu/libc.so.6
#4 0x00007ffff7c7fc19 in __fortify_fail () from /lib/x86_64-linux-gnu/libc.so.6
#5 0x00007ffff7c7f5d4 in __chk_fail () from /lib/x86_64-linux-gnu/libc.so.6
#6 0x00007ffff7c80db5 in __snprintf_chk () from /lib/x86_64-linux-gnu/libc.so.6
#7 0x00007ffff7ed39e5 in snprintf (__fmt=0x7ffff7f0dbc7 "%10d", __n=88, __s=0x7ffff7f7168a <work+10> "") at /usr/include/x86_64-linux-gnu/bits/stdio2.h:54
#8 MID_DSPKEY (name=name@entry=0x5555555a5778 <TOKEN+248> "myvals", dflag=63 '?') at midkeya.c:494
#9 0x0000555555580869 in DO_KEYS (key_task=key_task@entry=82 'R', prompt=prompt@entry=0x7fffffffdc10 "T") at prepc4.c:197
#10 0x000055555557f28f in prepx (kswitch=<optimized out>, cxpntr=cxpntr@entry=0x55555559f480 <wstr> " 23FEBpl1.0 PC/Linux", ' ' <repeats 12 times>, "-23.02pl1.0/midwork/MIDAS01.PID",
    ixpntr=ixpntr@entry=0x7fffffffdf90) at prepx.c:748
#11 0x000055555555ac53 in main () at prepa.c:168