Enigmail uses mailnews.wraplength unconditionally when signing (ignoring "Enable Word Wrap" setting from the "Toggle Word Wrap" addon)

Bug #1017563 reported by Daniel Hahler on 2012-06-25
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Enigmail
Fix Released
Medium
enigmail (Ubuntu)
Low
Unassigned

Bug Description

Enigmail appears to always use the mailnews.wraplength setting to wrap lines
before sending, also if "Enable Word Wrap" has been disabled for this
particular message.

mailnews.wraplength=72 is the default and good in most cases, but sometimes I
like to disable it for a single message. But Enigmail then re-wraps the message
before signing.

This does not happen when using mailnews.wraplength=0.

It appears that Enigmail should just honor the "Enable Word Wrap" setting for
the message and not apply any wrapping at least in that case.

ProblemType: Bug
DistroRelease: Ubuntu 12.04
Package: enigmail 2:1.4.2-0ubuntu0.12.04.1
ProcVersionSignature: Ubuntu 3.2.0-26.41-generic 3.2.19
Uname: Linux 3.2.0-26-generic x86_64
ApportVersion: 2.0.1-0ubuntu10
Architecture: amd64
Date: Mon Jun 25 17:38:19 2012
InstallationMedia: Ubuntu 12.04 LTS "Precise Pangolin" - Release amd64 (20120425)
SourcePackage: enigmail
UpgradeStatus: No upgrade log present (probably fresh install)

Daniel Hahler (blueyed) wrote :
Changed in enigmail:
importance: Unknown → Medium
status: Unknown → Won't Fix
Changed in enigmail:
status: Won't Fix → Fix Released
Micah Gersten (micahg) wrote :

We should get this with the Enigmail 1.4.3 update

Changed in enigmail (Ubuntu):
importance: Undecided → Low
status: New → Triaged
Micah Gersten (micahg) wrote :

This should be available in all releases now.

Changed in enigmail (Ubuntu):
status: Triaged → Fix Released
Daniel Hahler (blueyed) on 2012-08-13
summary: Enigmail uses mailnews.wraplength unconditionally when signing (ignoring
- "Enable Word Wrap" setting)
+ "Enable Word Wrap" setting from the "Toggle Word Wrap" addon)
B Bobo (yout-bobo123) wrote :

I have Enigmail 1.4.6, but not the Toggle Word Wrap addon, and I am still seeing forced wrapping on outgoing messages, even those that are not signed by Enigmail. I have set mail.wrap_long_lines=false and mail.compose.wrap_to_window_width=false, so why is wrapping still happening? That seems to be a bug. Setting mailnews.wraplength=0 completely disables wrapping.

B Bobo (yout-bobo123) wrote :

Should this bug report be re-opened if the bug I am seeing is the same?

Daniel Hahler (blueyed) wrote :

It looks like Thunderbird itself has a bug with wrapping in plain text.

If I disable all addons ("thunderbird -safe-mode") and then edit a draft, Thunderbird wraps it to about mailnews.wraplength-12 (60, if 72 (the default) is configured).

This appears to get applied after any addon handling (like with Enigmail and External Editor), or when re-editing a draft.

TEST CASE:

1. Create a new message (plain text)
2. Enter the following text:
1 3 5 7 9 1 3 5 7 9 1 3 5 7 9 1 3 5 7 9 1 3 5 7 9 1 3 5 7 9 1 3 5 7 9 1 3 5 7 9 1 3 5 7 9
3. Thunderbird will wrap it after 60 chars, although 72 is configured

Daniel Hahler (blueyed) wrote :

Just for information, this code (re-)wraps the text in Enigmail, using wraplength-2:

          if (wrapWidth && editor.wrapWidth > 0) {
            editor.wrapWidth = wrapWidth - 2;
            wrapper.rewrap(true);
            editor.wrapWidth = wrapWidth;
          }

(from extensions/enigmail/ui/content/enigmailMsgComposeOverlay.js)

Daniel Hahler (blueyed) wrote :

Also, note that enigmail changes the mailnews.send_plaintext_flowed setting to false by default.

And when you manually enable it, it will still wrap.

I have created a ticket for Enigmail about this at: https://sourceforge.net/p/enigmail/bugs/131/

Daniel Hahler (blueyed) wrote :

See also the "Toggle Word Wrap" addon at: https://addons.mozilla.org/en-US/thunderbird/addon/toggle-word-wrap/

This allows to toggle word wrapping using a hotkey (Ctrl-Shift-W).

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.