comint-watch-for-password-prompt does not catch sudo prompt

Bug #162890 reported by Chris Conway
4
Affects Status Importance Assigned to Milestone
emacs22 (Ubuntu)
Fix Released
Undecided
Michael Olson

Bug Description

Binary package hint: emacs22

The password prompt in sudo changed between feisty and gutsy, but the default comint-password-prompt-regexp has not changed to catch it, The user can always type M-x send-invisible, but it would be nice if the default install caught prompts from all the usual suspects.

Fix: in comint.el,
<pre>
(defcustom comint-password-prompt-regexp
   "\\(\\([Oo]ld \\|[Nn]ew \\|'s \\|login \\|Kerberos \\|CVS \\|UNIX \\| SMB \\|\\[sudo\\] \\|^\\)[Pp]assword\\( (again)\\)?\\|pass phrase\\|\\(Enter\\|Repeat\\|Bad\\) passphrase\\)\\(?:, try again\\)?\\(?: for [^:]+\\)?:\\s *\\'"
    "*Regexp matching prompts for passwords in the inferior process.
This is used by `comint-watch-for-password-prompt'."
  :type 'regexp
  :group 'comint)
</pre>

Related branches

CVE References

Revision history for this message
Reinhard Tartler (siretart) wrote :

I noticed this problem as well, but didn't test that regex yet.

Changed in emacs22:
status: New → Confirmed
Revision history for this message
Romain Francoise (rfrancoise) wrote :

This is fixed upstream in the Emacs 22 release branch:

2007-10-23 Chris Moore <email address hidden>

        * comint.el (comint-password-prompt-regexp):
        Handle `[sudo] password'-style prompt.

Michael Olson (mwolson)
Changed in emacs22:
assignee: nobody → mwolson
status: Confirmed → In Progress
Revision history for this message
Eddy Mulyono (eddymul) wrote :
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package emacs22 - 22.1-0ubuntu10

---------------
emacs22 (22.1-0ubuntu10) hardy; urgency=low

  * debian/control: Conflict and Replace emacs22-common-non-dfsg
    (LP: #172389). Thanks to Jamie Raymond for the report.
  * debian/emacs.prerm: Remove alternatives in reverse creation order
    (LP: #162932). Thanks to James Troup for the report.
  * debian/emacs.menu.in:
    - Use Applications/Editors instead of Apps/Editors as per menu policy.
    - Move menu definition for "emacs -nw" here, and delete
      emacs-common.menu.in. This way, if the user installs emacs22-nox,
      they will not have an unwanted menu item added (LP: #157984).
      Thanks to Ryan for the report.
  * debian/patches:
    - feature-spell-warning.diff: New patch that displays a warning when
      spell is used and the spell binary is not installed (LP: #154989).
    - fix-comint-sudo.diff: New patch that causes comint to recognize the
      sudo prompt used by Ubuntu (LP: #162890).
    - Rename CVE-2007-6109.diff to fix-format-overflow.diff so that it
      shows up in README.Debian. Add patch header as well.
    - fix-local-vars-security.diff: Add CVE ID.
  * debian/README.in:
    - Place Ubuntu rather than Debian in the header line.
    - Add link to further explanation for why we use a separate package.
    - Clarify what "this package" means.
    - Together this fixes LP: #180164. Thanks to era for the report and
      patch.
  * debian/rules: Don't build debian/emacs-common.menu and don't call
    dh_installmenu -i.

 -- <email address hidden> (Michael W. Olson (GNU address)) Tue, 08 Jan 2008 18:00:57 -0500

Changed in emacs22:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.